Bug 895429 - Change nooverflow attribute to overflows; r= Jared Wein [:jaws]

browser/base/content/browser.js

@@ -2182,7 +2182,7 @@ function UpdateUrlbarSearchSplitterState()
       splitter.setAttribute("resizebefore", "flex");
       splitter.setAttribute("resizeafter", "flex");
       splitter.setAttribute("skipintoolbarset", "true");
-      splitter.setAttribute("nooverflow", "true");
+      splitter.setAttribute("overflows", "false");
       splitter.className = "chromeclass-toolbar-additional";
     }
     urlbar.parentNode.insertBefore(splitter, ibefore);

browser/base/content/browser.xul

@@ -555,7 +555,7 @@
         <toolbaritem id="urlbar-container" align="center" flex="400" persist="width"
                      forwarddisabled="true" title="&locationItem.title;" removable="false"
                      customizableui-areatype="toolbar"
-                     class="chromeclass-location" nooverflow="true">
+                     class="chromeclass-location" overflows="false">
           <toolbarbutton id="back-button" class="toolbarbutton-1 chromeclass-toolbar-additional"
                          label="&backCmd.label;"
                          command="Browser:BackOrBackDuplicate"
@@ -676,7 +676,7 @@
                        label="&webrtcIndicatorButton.label;"
                        tooltiptext="&webrtcIndicatorButton.tooltip;"
                        customizableui-areatype="toolbar"
-                       nooverflow="true">
+                       overflows="false">
           <menupopup onpopupshowing="WebrtcIndicator.fillPopup(this);"
                      onpopuphiding="WebrtcIndicator.clearPopup(this);"
                      oncommand="WebrtcIndicator.menuCommand(event.target);"/>
@@ -799,7 +799,7 @@
         <toolbarbutton id="social-share-button"
                        class="toolbarbutton-1 chromeclass-toolbar-additional"
                        hidden="true"
-                       nooverflow="true"
+                       overflows="false"
                        label="&sharePageCmd.label;"
                        tooltiptext="&sharePageCmd.label;"
                        customizableui-areatype="toolbar"
@@ -810,7 +810,7 @@
                      removable="false"
                      title="&socialToolbar.title;"
                      hidden="true"
-                     nooverflow="true"
+                     overflows="false"
                      customizableui-areatype="toolbar"
                      observes="socialActiveBroadcaster">
         <toolbarbutton id="social-notification-icon" class="default-notification-icon toolbarbutton-1 notification-anchor-icon"

browser/components/customizableui/src/CustomizableUI.jsm

@@ -951,7 +951,7 @@ let CustomizableUIInternal = {
         node.setAttribute("disabled", true);
       }
       node.setAttribute("removable", aWidget.removable);
-      node.setAttribute("nooverflow", aWidget.nooverflow);
+      node.setAttribute("overflows", aWidget.overflows);
       node.setAttribute("label", this.getLocalizedProperty(aWidget, "label"));
       node.setAttribute("tooltiptext", this.getLocalizedProperty(aWidget, "tooltiptext"));
       //XXXunf Need to hook this up to a <key> element or something.
@@ -1612,7 +1612,7 @@ let CustomizableUIInternal = {
       instances: new Map(),
       currentArea: null,
       removable: false,
-      nooverflow: false,
+      overflows: true,
       defaultArea: null,
       allowedAreas: [],
       shortcut: null,
@@ -1645,7 +1645,7 @@ let CustomizableUIInternal = {
       }
     }
 
-    const kOptBoolProps = ["removable", "showInPrivateBrowsing", "nooverflow"]
+    const kOptBoolProps = ["removable", "showInPrivateBrowsing", "overflows"];
     for (let prop of kOptBoolProps) {
       if (typeof aData[prop] == "boolean") {
         widget[prop] = aData[prop];
@@ -2396,7 +2396,7 @@ OverflowableToolbar.prototype = {
     while (child && this._target.clientWidth < this._target.scrollWidth) {
       let prevChild = child.previousSibling;
 
-      if (!child.hasAttribute("nooverflow")) {
+      if (child.getAttribute("overflows") != "false") {
         this._collapsed.set(child.id, this._target.clientWidth);
         child.classList.add("overflowedItem");
         child.setAttribute("customizableui-anchorid", this._chevron.id);