Bug 1964092 - Add JSLargeAllocationFailure and JSOutOfMemory to fenix crash pings r=afranchuk,android-reviewers,nalexander

Differential Revision: https://phabricator.services.mozilla.com/D248667
This commit is contained in:
Matthew Gaudet
2025-05-13 14:53:22 +00:00
committed by mgaudet@mozilla.com
parent 8c3f2e805e
commit 5498e0b756
3 changed files with 41 additions and 1 deletions

View File

@@ -701,6 +701,40 @@ memory:
send_in_pings:
- crash
js_large_allocation_failure:
type: string
description: >
A large allocation couldn't be satisfied: What was
its state when the crash happened.
notification_emails:
- mgaudet@mozilla.com
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1964092
data_reviews:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1964092
data_sensitivity:
- technical
expires: never
send_in_pings:
- crash
js_out_of_memory:
type: string
description: >
A small allocation couldn't be satisfied: What was
its state when the crash happened.
notification_emails:
- mgaudet@mozilla.com
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1964092
data_reviews:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1964092
data_sensitivity:
- technical
expires: never
send_in_pings:
- crash
low_physical:
type: quantity
unit: events

View File

@@ -154,6 +154,8 @@ class GleanCrashReporterService(
GleanMemory.availablePhysical.setIfNonNull(extras["AvailablePhysicalMemory"])
GleanMemory.availableSwap.setIfNonNull(extras["AvailableSwapMemory"])
GleanMemory.availableVirtual.setIfNonNull(extras["AvailableVirtualMemory"])
GleanMemory.jsLargeAllocationFailure.setIfNonNull(extras["JSLargeAllocationFailure"])
GleanMemory.jsOutOfMemory.setIfNonNull(extras["JSOutOfMemory"])
GleanMemory.lowPhysical.setIfNonNull(extras["LowPhysicalMemoryEvents"])
GleanMemory.oomAllocationSize.setIfNonNull(extras["OOMAllocationSize"])
GleanMemory.purgeablePhysical.setIfNonNull(extras["PurgeablePhysicalMemory"])

View File

@@ -651,7 +651,9 @@ class GleanCrashReporterServiceTest {
"TotalPhysicalMemory": 100,
"AsyncShutdownTimeout": "{\"phase\":\"abcd\",\"conditions\":[{\"foo\":\"bar\"}],\"brokenAddBlockers\":[\"foo\"]}",
"QuotaManagerShutdownTimeout": "line1\nline2\nline3",
"StackTraces": $stackTracesAnnotation
"StackTraces": $stackTracesAnnotation,
"JSLargeAllocationFailure": "reporting",
"JSOutOfMemory": "recovered"
}
""".trimIndent(),
)
@@ -687,6 +689,8 @@ class GleanCrashReporterServiceTest {
assertEquals("beta", GleanCrash.appChannel.testGetValue())
assertEquals("123.0.0", GleanCrash.appDisplayVersion.testGetValue())
assertEquals(100L, GleanMemory.totalPhysical.testGetValue())
assertEquals("reporting", GleanMemory.jsLargeAllocationFailure.testGetValue())
assertEquals("recovered", GleanMemory.jsOutOfMemory.testGetValue())
assertEquals(
JsonObject(
mapOf(