corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1463605 - Call MarkNeedsDisplayItemRebuild() for IB split siblings too. r=mattwoodrow

Browse Source 
MozReview-Commit-ID: 4vN69YLUbIy
This commit is contained in:
Hiroyuki Ikezoe
2018-05-23 18:15:12 +09:00
parent 79840bca98
commit 4137f94965
1 changed files with 33 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
dom/animation/KeyframeEffect.cpp
View File

@@ -751,6 +751,17 @@ KeyframeEffect::BuildProperties(const ComputedStyle* aStyle)
return result;
}
template<typename FrameEnumFunc>
static void
EnumerateContinuationsOrIBSplitSiblings(nsIFrame* aFrame,
FrameEnumFunc&& aFunc)
{
while (aFrame) {
aFunc(aFrame);
aFrame = nsLayoutUtils::GetNextContinuationOrIBSplitSibling(aFrame);
}
}
void
KeyframeEffect::UpdateTargetRegistration()
{
@@ -773,11 +784,12 @@ KeyframeEffect::UpdateTargetRegistration()
effectSet->AddEffect(*this);
mInEffectSet = true;
UpdateEffectSet(effectSet);
nsIFrame* f = GetPrimaryFrame();
while (f) {
f->MarkNeedsDisplayItemRebuild();
f = f->GetNextContinuation();
}
nsIFrame* frame = GetPrimaryFrame();
EnumerateContinuationsOrIBSplitSiblings(frame,
[](nsIFrame* aFrame) {
aFrame->MarkNeedsDisplayItemRebuild();
}
);
} else if (!isRelevant && mInEffectSet) {
UnregisterTarget();
}
@@ -802,11 +814,12 @@ KeyframeEffect::UnregisterTarget()
EffectSet::DestroyEffectSet(mTarget->mElement, mTarget->mPseudoType);
}
}
nsIFrame* f = GetPrimaryFrame();
while (f) {
f->MarkNeedsDisplayItemRebuild();
f = f->GetNextContinuation();
}
nsIFrame* frame = GetPrimaryFrame();
EnumerateContinuationsOrIBSplitSiblings(frame,
[](nsIFrame* aFrame) {
aFrame->MarkNeedsDisplayItemRebuild();
}
);
}
void
@@ -1785,17 +1798,19 @@ KeyframeEffect::UpdateEffectSet(EffectSet* aEffectSet) const
nsIFrame* frame = GetStyleFrame();
if (HasAnimationOfProperty(eCSSProperty_opacity)) {
effectSet->SetMayHaveOpacityAnimation();
while (frame) {
frame->SetMayHaveOpacityAnimation();
frame = nsLayoutUtils::GetNextContinuationOrIBSplitSibling(frame);
}
EnumerateContinuationsOrIBSplitSiblings(frame,
[](nsIFrame* aFrame) {
aFrame->SetMayHaveOpacityAnimation();
}
);
}
if (HasAnimationOfProperty(eCSSProperty_transform)) {
effectSet->SetMayHaveTransformAnimation();
while (frame) {
frame->SetMayHaveTransformAnimation();
frame = nsLayoutUtils::GetNextContinuationOrIBSplitSibling(frame);
}
EnumerateContinuationsOrIBSplitSiblings(frame,
[](nsIFrame* aFrame) {
aFrame->SetMayHaveTransformAnimation();
}
);
}
}