corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1923416 - Added test case to verify transceivers are not disabled if port is 0 with bundling;r=bwc

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D226055
This commit is contained in:
Dan Baker
2024-10-18 17:32:43 +00:00
parent 4072ad124b
commit 405b6d2dea
1 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
media/webrtc/signaling/gtest/jsep_session_unittest.cpp
View File

@@ -7710,4 +7710,52 @@ TEST_F(JsepSessionTest, TestTransportAttributeValidation) {
ASSERT_FALSE(result.mError.isSome());
}
}
TEST_F(JsepSessionTest, TestBundleSupportWithZeroPort) {
AddTracks(*mSessionOff, "audio,video,video,datachannel");
AddTracks(*mSessionAns, "audio,video,video,datachannel");
std::string offer;
mSessionOff->CreateOffer(JsepOfferOptions(), &offer);
mSessionOff->SetLocalDescription(kJsepSdpOffer, offer);
mSessionAns->SetRemoteDescription(kJsepSdpOffer, offer);
std::string answer;
mSessionAns->CreateAnswer(JsepAnswerOptions(), &answer);
// Manipulate the bundling on the answer
UniquePtr<Sdp> sdp(Parse(answer));
ASSERT_TRUE(!!sdp);
size_t num_m_sections = sdp->GetMediaSectionCount();
for (size_t i = 0; i < num_m_sections; ++i) {
auto& msection = sdp->GetMediaSection(i);
const SdpAttributeList& attrs = msection.GetAttributeList();
// If this is not the last msection then ensure we have bundle only set and
// port 0.
if (!attrs.HasAttribute(SdpAttribute::kBundleOnlyAttribute) &&
i < num_m_sections - 1) {
sdp->GetMediaSection(i).GetAttributeList().SetAttribute(
new SdpFlagAttribute(SdpAttribute::kBundleOnlyAttribute));
sdp->GetMediaSection(i).SetPort(0);
} else {
// For the last msection setting port to non 0 and removing bundle only if
// it existed.
if (attrs.HasAttribute(SdpAttribute::kBundleOnlyAttribute)) {
sdp->GetMediaSection(i).GetAttributeList().RemoveAttribute(
SdpAttribute::kBundleOnlyAttribute);
}
sdp->GetMediaSection(i).SetPort(9);
}
}
auto answerSdp = sdp->ToString();
mSessionOff->SetRemoteDescription(kJsepSdpAnswer, answerSdp);
// Ensure all the transcievers are still active bug 1923416
for (const auto offerTransceiver : GetTransceivers(*mSessionOff)) {
ASSERT_TRUE(offerTransceiver.mRecvTrack.GetActive());
ASSERT_TRUE(offerTransceiver.mSendTrack.GetActive());
}
}
} // namespace mozilla