Backed out changeset 234a8e0fb95f (bug 1874952) for causing mochitests in browser_doorhanger_remembering.js. CLOSED TREE

browser/base/content/browser-siteProtections.js

@@ -2663,7 +2663,7 @@ var gProtectionsHandler = {
         } else {
           this._protectionsPopup.hidePopup();
           ConfirmationHint.show(
-            this._trackingProtectionIconContainer,
+            this.iconBox,
             "confirmation-hint-breakage-report-sent"
           );
         }

browser/base/content/browser.js

@@ -9946,7 +9946,7 @@ var ConfirmationHint = {
     );
 
     this._panel.openPopup(anchor, {
-      position: options.position ?? "bottomleft topleft",
+      position: options.position ?? "bottomcenter topleft",
       triggerEvent: options.event,
     });
   },

toolkit/components/passwordmgr/LoginManagerPrompter.sys.mjs

@@ -604,8 +604,15 @@ export class LoginManagerPrompter {
           });
           Services.logins.removeLogin(matchingLogins[0]);
           browser.focus();
+          // The "password-notification-icon" and "notification-icon-box" are hidden
+          // at this point, so approximate the location with the next closest,
+          // visible icon as the anchor.
+          const anchor = browser.ownerDocument.getElementById("identity-icon");
           lazy.log.debug("Showing the ConfirmationHint");
-          showConfirmation(browser, "confirmation-hint-password-removed");
+          anchor.ownerGlobal.ConfirmationHint.show(
+            anchor,
+            "confirmation-hint-password-removed"
+          );
         },
       });
     }

toolkit/components/satchel/FillHelpers.sys.mjs

@@ -26,15 +26,12 @@ export class GenericAutocompleteItem {
  *
  * @param {object} browser - An object representing the browser.
  * @param {string} messageId - Message ID from browser/confirmationHints.ftl
- * @param {string} [anchorId="identity-icon-box"] - ID of the element to anchor the hint to.
-                   The "password-notification-icon" and "notification-popup-box" are hidden
-                   at the point of showing the hint (for *most* cases), so approximate the
-                   location with the next closest, visible icon as the anchor.
+ * @param {string} [anchorId="identity-icon"] - ID of the element to anchor the hint to.
  */
 export function showConfirmation(
   browser,
   messageId,
-  anchorId = "identity-icon-box"
+  anchorId = "identity-icon"
 ) {
   const anchor = browser.ownerDocument.getElementById(anchorId);
   anchor.ownerGlobal.ConfirmationHint.show(anchor, messageId, {});