corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1818811 - Remove flexbox emulation talos tests. r=perftest-reviewers,sparky

Browse Source 
flexbox emulation has been on by default in the browser for a while now
(since 108), so these tests are not useful anymore.

Depends on D170944

Differential Revision: https://phabricator.services.mozilla.com/D170945
This commit is contained in:
Emilio Cobos Álvarez
2023-02-27 13:45:19 +00:00
parent 27ca94f66b
commit 09bba2afca
11 changed files with 0 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
taskcluster/ci/test/talos.yml
View File

@@ -219,38 +219,6 @@ talos-dromaeojs-profiling:
- --suite=dromaeojs
- --gecko-profile
talos-flex:
description: Talos XUL flexbox emulation enabled
try-name: flex
treeherder-symbol: T(f)
tier: 2
run-on-projects:
by-test-platform:
windows.*-32.*: []
(linux|windows10-64|macos)(?!.*shippable).*: []
(linux|windows10-64|macos)(?!.*-qr).*: []
default: [mozilla-central]
max-run-time: 1800
mozharness:
extra-options:
- --suite=flex
talos-flex-profiling:
description: Talos XUL flexbox emulation enabled with gecko profiling
try-name: flex-prof
treeherder-symbol: T-Prof(f)
tier: 3
run-on-projects:
by-test-platform:
windows.*-32.*: []
(linux|windows10-64|macos)(?!.*shippable).*: []
default: [mozilla-central]
max-run-time: 1800
mozharness:
extra-options:
- --suite=flex
- --gecko-profile
talos-g1:
description: Talos g1
try-name: g1

2
taskcluster/ci/test/test-platforms.yml
View File

@@ -46,7 +46,6 @@ linux1804-64-qr/opt:
- mochitest-webgpu
- web-platform-tests
- web-platform-tests-backlog
- linux-talos-flex
- talos
- browsertime
@@ -59,7 +58,6 @@ linux1804-64-shippable-qr/opt:
- mochitest-webgpu
- web-platform-tests
- web-platform-tests-backlog
- linux-talos-flex
- talos
- talos-profiling
- browsertime

4
taskcluster/ci/test/test-sets.yml
View File

@@ -60,7 +60,6 @@ talos-profiling:
- talos-chrome-profiling
# - talos-damp-profiling - Disabled b/c of Bug 1597734
- talos-dromaeojs-profiling
# - talos-flex-profiling - Disabled b/c of Bug 1597736
- talos-g1-profiling
- talos-g3-profiling
- talos-g4-profiling
@@ -183,9 +182,6 @@ linux1804-ccov-tests:
# on ccov builds.
- jittest
linux-talos-flex:
- talos-flex
# Windows
windows-7-tests:

2
taskcluster/test/params/mb-ship-geckoview.yml
View File

@@ -1813,7 +1813,6 @@ existing_tasks:
test-linux64-shippable/opt-talos-damp-e10s: JPZMIeOMSLGQpAMJFWQ_QQ
test-linux64-shippable/opt-talos-dromaeojs-e10s: X77YW5XZTvK_OT2Uhgck6A
test-linux64-shippable/opt-talos-dromaeojs-profiling-e10s: E0t7Tdz-QUGkaYXWq0itLg
test-linux64-shippable/opt-talos-flex-e10s: AZkSzYwqQ3OtDpdM8-sFfg
test-linux64-shippable/opt-talos-g1-e10s: Z8FpaR0yR-aMKJ6C3rSA8Q
test-linux64-shippable/opt-talos-g1-profiling-e10s: eAU0Fq_QRUWJMPQdkWZD5g
test-linux64-shippable/opt-talos-g3-e10s: GfBf46_7TUmLzQKlb782Qw
@@ -1940,7 +1939,6 @@ existing_tasks:
test-linux64/opt-talos-chrome-e10s: TPpI4NUZTX2KISiNTECneQ
test-linux64/opt-talos-damp-e10s: MdorZUfxSvKm3BCIEIg4lQ
test-linux64/opt-talos-dromaeojs-e10s: WEvrUccjRFapOxKmuJCoWw
test-linux64/opt-talos-flex-e10s: TsTtcXTzQC-lXo0jA_NJuQ
test-linux64/opt-talos-g1-e10s: Wh16qsINQTSL1J3fv4Xm7g
test-linux64/opt-talos-g3-e10s: AbJj_8xSSvibIvitur0C_A
test-linux64/opt-talos-g4-e10s: FDD0cBQ3Q6KLwTEVgvrgHw

2
taskcluster/test/params/mc-ship-geckoview.yml
View File

@@ -1813,7 +1813,6 @@ existing_tasks:
test-linux64-shippable/opt-talos-damp-e10s: JPZMIeOMSLGQpAMJFWQ_QQ
test-linux64-shippable/opt-talos-dromaeojs-e10s: X77YW5XZTvK_OT2Uhgck6A
test-linux64-shippable/opt-talos-dromaeojs-profiling-e10s: E0t7Tdz-QUGkaYXWq0itLg
test-linux64-shippable/opt-talos-flex-e10s: AZkSzYwqQ3OtDpdM8-sFfg
test-linux64-shippable/opt-talos-g1-e10s: Z8FpaR0yR-aMKJ6C3rSA8Q
test-linux64-shippable/opt-talos-g1-profiling-e10s: eAU0Fq_QRUWJMPQdkWZD5g
test-linux64-shippable/opt-talos-g3-e10s: GfBf46_7TUmLzQKlb782Qw
@@ -1940,7 +1939,6 @@ existing_tasks:
test-linux64/opt-talos-chrome-e10s: TPpI4NUZTX2KISiNTECneQ
test-linux64/opt-talos-damp-e10s: MdorZUfxSvKm3BCIEIg4lQ
test-linux64/opt-talos-dromaeojs-e10s: WEvrUccjRFapOxKmuJCoWw
test-linux64/opt-talos-flex-e10s: TsTtcXTzQC-lXo0jA_NJuQ
test-linux64/opt-talos-g1-e10s: Wh16qsINQTSL1J3fv4Xm7g
test-linux64/opt-talos-g3-e10s: AbJj_8xSSvibIvitur0C_A
test-linux64/opt-talos-g4-e10s: FDD0cBQ3Q6KLwTEVgvrgHw

2
taskcluster/test/params/mr-ship-geckoview.yml
View File

@@ -1813,7 +1813,6 @@ existing_tasks:
test-linux64-shippable/opt-talos-damp-e10s: JPZMIeOMSLGQpAMJFWQ_QQ
test-linux64-shippable/opt-talos-dromaeojs-e10s: X77YW5XZTvK_OT2Uhgck6A
test-linux64-shippable/opt-talos-dromaeojs-profiling-e10s: E0t7Tdz-QUGkaYXWq0itLg
test-linux64-shippable/opt-talos-flex-e10s: AZkSzYwqQ3OtDpdM8-sFfg
test-linux64-shippable/opt-talos-g1-e10s: Z8FpaR0yR-aMKJ6C3rSA8Q
test-linux64-shippable/opt-talos-g1-profiling-e10s: eAU0Fq_QRUWJMPQdkWZD5g
test-linux64-shippable/opt-talos-g3-e10s: GfBf46_7TUmLzQKlb782Qw
@@ -1940,7 +1939,6 @@ existing_tasks:
test-linux64/opt-talos-chrome-e10s: TPpI4NUZTX2KISiNTECneQ
test-linux64/opt-talos-damp-e10s: MdorZUfxSvKm3BCIEIg4lQ
test-linux64/opt-talos-dromaeojs-e10s: WEvrUccjRFapOxKmuJCoWw
test-linux64/opt-talos-flex-e10s: TsTtcXTzQC-lXo0jA_NJuQ
test-linux64/opt-talos-g1-e10s: Wh16qsINQTSL1J3fv4Xm7g
test-linux64/opt-talos-g3-e10s: AbJj_8xSSvibIvitur0C_A
test-linux64/opt-talos-g4-e10s: FDD0cBQ3Q6KLwTEVgvrgHw

100
testing/perfdocs/generated/talos.rst
View File

@@ -60,7 +60,6 @@ figure out what suites and tests are available to run.
# bcv (basic_compositor_video)
# chromez (about_preferences_basic:tresize)
# dromaeojs (dromaeo_css:kraken)
# flex (tart_flex:ts_paint_flex)
# ...
# Run all of the tests in the "bcv" test suite:
@@ -106,7 +105,6 @@ platform and test suites of your choosing.
| test-windows10-64/opt-talos-webgl-gli-e10s
| test-linux64-shippable/opt-talos-tp5o-e10s
| test-linux64-shippable/opt-talos-svgr-e10s
| test-linux64-shippable/opt-talos-flex-e10s
| test-linux64-shippable/opt-talos-damp-e10s
> test-windows7-32/opt-talos-webgl-gli-e10s
| test-linux64-shippable/opt-talos-bcv-e10s
@@ -6215,55 +6213,6 @@ For the sample commands found below, note that the capitalization used is import
.. dropdown:: tart_flex
:container: + anchor-id-tart_flex
* description:
| This test was created as a part of a goal to switch away from xul flexbox to css flexbox
* Contact: No longer being maintained by any team/individual
* pine: False
* preferences: {'layout.css.moz-box-flexbox-emulation.enabled': True}
* Command
.. code-block::
./mach talos-test -a tart_flex
* **Test Task**:
.. list-table:: **test-linux1804-64-qr/opt**
:widths: 30 15 15 15 15
:header-rows: 1
* - **Test Name**
- mozilla-central
- autoland
- mozilla-release
- mozilla-beta
* - **talos-flex**
- ❌
- ❌
- ❌
- ❌
.. list-table:: **test-linux1804-64-shippable-qr/opt**
:widths: 30 15 15 15 15
:header-rows: 1
* - **Test Name**
- mozilla-central
- autoland
- mozilla-release
- mozilla-beta
* - **talos-flex**
- ✅
- ❌
- ❌
- ❌
.. dropdown:: tp5
:container: + anchor-id-tp5
@@ -7519,55 +7468,6 @@ For the sample commands found below, note that the capitalization used is import
.. dropdown:: ts_paint_flex
:container: + anchor-id-ts_paint_flex
* description:
| This test was created as a part of a goal to switch away from xul flexbox to css flexbox
* Contact: No longer being maintained by any team/individual
* pine: False
* preferences: {'layout.css.moz-box-flexbox-emulation.enabled': True}
* Command
.. code-block::
./mach talos-test -a ts_paint_flex
* **Test Task**:
.. list-table:: **test-linux1804-64-qr/opt**
:widths: 30 15 15 15 15
:header-rows: 1
* - **Test Name**
- mozilla-central
- autoland
- mozilla-release
- mozilla-beta
* - **talos-flex**
- ❌
- ❌
- ❌
- ❌
.. list-table:: **test-linux1804-64-shippable-qr/opt**
:widths: 30 15 15 15 15
:header-rows: 1
* - **Test Name**
- mozilla-central
- autoland
- mozilla-release
- mozilla-beta
* - **talos-flex**
- ✅
- ❌
- ❌
- ❌
.. dropdown:: ts_paint_heavy
:container: + anchor-id-ts_paint_heavy

8
testing/talos/perfdocs/config.yml
View File

@@ -693,10 +693,6 @@ suites:
* 27;newtab-open-preload-yes.half.TART;3.14;2.96;2.97;8.37;2.98;3.00;2.96;3.05;3.12;3.48;3.07;3.23;3.05;2.88;2.92;3.06;2.90;3.01;3.19;2.90;3.18;3.11;3.04;3.16;3.21
* 28;newtab-open-preload-yes.all.TART;5.10;4.60;4.63;8.94;5.01;4.69;4.63;4.67;4.93;5.43;4.78;5.12;4.77;4.65;4.50;4.78;4.75;4.63;4.76;4.45;4.86;4.88;4.69;4.86;4.92
* 29;newtab-open-preload-yes.error.TART;35.90;37.24;38.57;40.60;36.04;38.12;38.78;36.73;36.91;36.69;38.12;36.69;37.79;35.80;36.11;38.01;36.59;38.85;37.14;37.30;38.02;38.95;37.64;37.86;36.43
tart_flex: >
- description:
| This test was created as a part of a goal to switch away from xul flexbox to css flexbox
- Contact: No longer being maintained by any team/individual
tp5n: >
- contact: fx-perf@mozilla.com
- description:
@@ -920,10 +916,6 @@ suites:
* (and/or maybe tpaint?) will regress if a new element is added to the
browser window (e.g. browser.xul) and it's frame gets created. Fix
this by ensuring it's display:none by default.
ts_paint_flex: >
- description:
| This test was created as a part of a goal to switch away from xul flexbox to css flexbox
- Contact: No longer being maintained by any team/individual
ts_paint_heavy: >
- `ts_paint <#ts_paint>`_ test run against a heavy user profile.
- contact: :mconley, Firefox Desktop Front-end team,

2
testing/talos/perfdocs/index.rst
View File

@@ -60,7 +60,6 @@ figure out what suites and tests are available to run.
# bcv (basic_compositor_video)
# chromez (about_preferences_basic:tresize)
# dromaeojs (dromaeo_css:kraken)
# flex (tart_flex:ts_paint_flex)
# ...
# Run all of the tests in the "bcv" test suite:
@@ -106,7 +105,6 @@ platform and test suites of your choosing.
| test-windows10-64/opt-talos-webgl-gli-e10s
| test-linux64-shippable/opt-talos-tp5o-e10s
| test-linux64-shippable/opt-talos-svgr-e10s
| test-linux64-shippable/opt-talos-flex-e10s
| test-linux64-shippable/opt-talos-damp-e10s
> test-windows7-32/opt-talos-webgl-gli-e10s
| test-linux64-shippable/opt-talos-bcv-e10s

3
testing/talos/talos.json
View File

@@ -9,9 +9,6 @@
"dromaeojs": {
"tests": ["dromaeo_css", "kraken"]
},
"flex": {
"tests": ["tart_flex", "ts_paint_flex"]
},
"other": {
"tests": ["a11yr", "ts_paint", "twinopen", "sessionrestore", "sessionrestore_no_auto_restore", "tabpaint", "cpstartup", "startup_about_home_paint", "pdfpaint", "cross_origin_pageload", "startup_about_home_paint_cached"]
},

12
testing/talos/talos/test.py
View File

@@ -192,12 +192,6 @@ class ts_paint_heavy(ts_paint):
profile = "simple"
@register_test()
class ts_paint_flex(ts_paint):
preferences = {"layout.css.moz-box-flexbox-emulation.enabled": True}
pine = False
@register_test()
class startup_about_home_paint(ts_paint):
"""
@@ -573,12 +567,6 @@ class tart(PageloaderTest):
pine = False
@register_test()
class tart_flex(tart):
preferences = {"layout.css.moz-box-flexbox-emulation.enabled": True}
pine = False
@register_test()
class damp(PageloaderTest):
"""