Files
tubestation/netwerk/base/nsSimpleNestedURI.h
Nika Layzell 9b70884f32 Bug 1944365 - Part 3: Store nsSimpleURI spec in contiguous memory, r=necko-reviewers,valentin
This patch adjusts nsSimpleURI to be stored as a single `mSpec` member,
with cached indices of the various separators alongside. This improves
the performance of calling `GetSpec()` on these URIs, as the caller will
be able to share the underlying string buffer.

This moves nsSimpleURI's implementation to be a bit more in-line with
nsStandardURL, hopefully reducing performance surprises, especially
around large data URIs.

nsDataChannel is updated for the new perf characteristics in part 4.

Differential Revision: https://phabricator.services.mozilla.com/D236274
2025-02-10 15:34:20 +00:00

112 lines
3.2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/**
* URI class to be used for cases when a simple URI actually resolves to some
* other sort of URI, with the latter being what's loaded when the load
* happens.
*/
#ifndef nsSimpleNestedURI_h__
#define nsSimpleNestedURI_h__
#include "nsCOMPtr.h"
#include "nsSimpleURI.h"
#include "nsINestedURI.h"
#include "nsIURIMutator.h"
namespace mozilla {
namespace net {
class nsSimpleNestedURI : public nsSimpleURI, public nsINestedURI {
protected:
nsSimpleNestedURI() = default;
explicit nsSimpleNestedURI(nsIURI* innerURI);
~nsSimpleNestedURI() = default;
public:
NS_DECL_ISUPPORTS_INHERITED
NS_DECL_NSINESTEDURI
// Overrides for various methods nsSimpleURI implements follow.
// nsSimpleURI overrides
virtual nsresult EqualsInternal(nsIURI* other,
RefHandlingEnum refHandlingMode,
bool* result) override;
virtual already_AddRefed<nsSimpleURI> StartClone() override;
NS_IMETHOD Mutate(nsIURIMutator** _retval) override;
NS_IMETHOD_(void) Serialize(ipc::URIParams& aParams) override;
// nsISerializable overrides
NS_IMETHOD Read(nsIObjectInputStream* aStream) override;
NS_IMETHOD Write(nsIObjectOutputStream* aStream) override;
protected:
nsCOMPtr<nsIURI> mInnerURI;
nsresult SetPathQueryRef(const nsACString& aPathQueryRef) override;
nsresult SetQuery(const nsACString& aQuery) override;
nsresult SetRef(const nsACString& aRef) override;
bool Deserialize(const mozilla::ipc::URIParams&);
nsresult ReadPrivate(nsIObjectInputStream* stream);
public:
class Mutator final : public nsIURIMutator,
public BaseURIMutator<nsSimpleNestedURI>,
public nsISerializable,
public nsINestedURIMutator {
NS_DECL_ISUPPORTS
NS_FORWARD_SAFE_NSIURISETTERS_RET(mURI)
explicit Mutator() = default;
private:
virtual ~Mutator() = default;
[[nodiscard]] NS_IMETHOD Deserialize(
const mozilla::ipc::URIParams& aParams) override {
return InitFromIPCParams(aParams);
}
NS_IMETHOD
Write(nsIObjectOutputStream* aOutputStream) override {
return NS_ERROR_NOT_IMPLEMENTED;
}
[[nodiscard]] NS_IMETHOD Read(nsIObjectInputStream* aStream) override {
return InitFromInputStream(aStream);
}
[[nodiscard]] NS_IMETHOD Finalize(nsIURI** aURI) override {
mURI.forget(aURI);
return NS_OK;
}
[[nodiscard]] NS_IMETHOD SetSpec(const nsACString& aSpec,
nsIURIMutator** aMutator) override {
if (aMutator) {
NS_ADDREF(*aMutator = this);
}
return InitFromSpec(aSpec);
}
[[nodiscard]] NS_IMETHOD Init(nsIURI* innerURI) override {
mURI = new nsSimpleNestedURI(innerURI);
return NS_OK;
}
friend class nsSimpleNestedURI;
};
friend BaseURIMutator<nsSimpleNestedURI>;
};
} // namespace net
} // namespace mozilla
#endif /* nsSimpleNestedURI_h__ */