Eden Chuang 113e7b3116 Bug 1905337 - Keep dispatched RefPtr<WorkerThreadRunnable> of WorkerPrivate::mPreStartRunnables. r=dom-worker-reviewers,jstutte,smaug ...

https://phabricator.services.mozilla.com/D213947 introduced a post-handling for WorkerPrivate::mPreStartRunnables once Worker initialization fails.
However, it needs corresponding WorkerThreadRunnable be kept in WorkerPrivate::mPreStartRunnables. However, [[ https://searchfox.org/mozilla-central/rev/3d173a6ad865eb778eb7a85de900e92774559ed6/dom/workers/WorkerPrivate.cpp#5928 | we did not keep it while dispatching]], and then meet UAF when executing the post-handling.

So this patch ensures the mPreStartRunnables are kept after dispatching.
And mPreStartRunnables will be cleared [[ https://searchfox.org/mozilla-central/rev/3d173a6ad865eb778eb7a85de900e92774559ed6/dom/workers/WorkerPrivate.cpp#3273,3336 | when the Worker gets into the next status "Running" or "Dead"]].

Differential Revision: https://phabricator.services.mozilla.com/D215601

2024-07-03 09:59:16 +00:00

..

loader

Bug 1894231 - P6 Remove ScriptResponseHeaderProcessor::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-06-24 22:20:52 +00:00

remoteworkers

Backed out 5 changesets (bug 1672493) for causing serviceworker related perma failures. CLOSED TREE

2024-06-27 13:02:33 +03:00

sharedworkers

Bug 1904442 - Rename GlobalTeardownObserver::GetOwner to GetOwnerWindow. r=smaug,media-playback-reviewers,dom-storage-reviewers,aosmond,padenot,asuth

2024-07-01 11:49:59 +00:00

test

Bug 1904124 - Part 1: Move all notification related tests to dom/notification/test/ r=asuth

2024-07-01 20:13:31 +00:00

ChromeWorker.cpp

…

ChromeWorker.h

…

ChromeWorkerScope.cpp

…

ChromeWorkerScope.h

…

EventWithOptionsRunnable.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

EventWithOptionsRunnable.h

Bug 1880231 - Add names to WorkerDebuggeeRunnable and WorkerDebuggerRunnable derived runnables. r=dom-worker-reviewers,smaug

2024-02-14 10:24:15 +00:00

JSExecutionManager.cpp

…

JSExecutionManager.h

…

JSSettings.h

…

MessageEventRunnable.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

MessageEventRunnable.h

Bug 1769913 - P2 WorkerParentThreadRunnable for the runnables dispatched to worker's parent thread. r=dom-worker-reviewers,asuth

2024-04-19 09:41:57 +00:00

moz.build

…

nsIWorkerChannelInfo.idl

…

nsIWorkerDebugger.idl

Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8

2024-04-04 18:45:21 +00:00

nsIWorkerDebuggerManager.idl

…

Queue.h

…

RegisterBindings.cpp

…

RuntimeService.cpp

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

RuntimeService.h

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

ScriptLoader.cpp

Bug 1894231 - P6 Remove ScriptResponseHeaderProcessor::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-06-24 22:20:52 +00:00

ScriptLoader.h

…

Worker.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

Worker.h

Bug 1858809 - Enforce Worker::PostEventWithOptions invariants. r=bwc,dom-worker-reviewers,smaug

2024-04-10 01:38:36 +00:00

WorkerChannelInfo.cpp

…

WorkerChannelInfo.h

…

WorkerCommon.h

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

WorkerCSPEventListener.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerCSPEventListener.h

…

WorkerDebugger.cpp

Bug 1896893 - [devtools] Tweak WorkerDebugger.isClosed to better reflect worker destruction. r=dom-worker-reviewers,smaug,asuth

2024-05-20 21:42:06 +00:00

WorkerDebugger.h

…

WorkerDebuggerManager.cpp

…

WorkerDebuggerManager.h

…

WorkerDocumentListener.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerDocumentListener.h

…

WorkerError.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerError.h

…

WorkerEventTarget.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerEventTarget.h

…

WorkerIPCUtils.h

Bug 1640839 - Add IPC serializer for WebIDL enums. r=mccr8,jgilbert,media-playback-reviewers,dom-storage-reviewers,janv,padenot

2024-03-02 07:50:22 +00:00

WorkerLoadInfo.cpp

Bug 1876575, part 2 - Make Workers use ancestor chain for third-partiness check - r=anti-tracking-reviewers,timhuang,asuth

2024-04-02 18:53:26 +00:00

WorkerLoadInfo.h

Bug 1876575, part 2 - Make Workers use ancestor chain for third-partiness check - r=anti-tracking-reviewers,timhuang,asuth

2024-04-02 18:53:26 +00:00

WorkerLocation.cpp

…

WorkerLocation.h

…

WorkerNavigator.cpp

Bug 1894231 - P3 Remove WorkerPrivate* in WorkerMainThreadRunnable. r=dom-worker-reviewers,extension-reviewers,smaug,rpl

2024-06-24 22:20:51 +00:00

WorkerNavigator.h

…

WorkerPrivate.cpp

Bug 1905337 - Keep dispatched RefPtr<WorkerThreadRunnable> of WorkerPrivate::mPreStartRunnables. r=dom-worker-reviewers,jstutte,smaug

2024-07-03 09:59:16 +00:00

WorkerPrivate.h

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

WorkerRef.cpp

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerRef.h

Bug 1769913 - P3 Remove WorkerRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth

2024-04-19 09:41:58 +00:00

WorkerRunnable.cpp

Bug 1894231 - P11 Remove WorkerThreadRunnable::mWorkerPrivateForPreStartCleaning. r=dom-worker-reviewers,asuth

2024-06-24 22:20:54 +00:00

WorkerRunnable.h

Bug 1894231 - P11 Remove WorkerThreadRunnable::mWorkerPrivateForPreStartCleaning. r=dom-worker-reviewers,asuth

2024-06-24 22:20:54 +00:00

WorkerScope.cpp

Bug 1878137 - Defer reporting declined IDB storage access to method calls. r=dom-storage-reviewers,asuth

2024-05-08 14:29:53 +00:00

WorkerScope.h

Bug 1887719 - More consistently use UTF8String/nsCString for URLs. r=necko-reviewers,webidl,anti-tracking-reviewers,places-reviewers,jari,kershaw,janv,smaug,hsivonen

2024-04-04 11:49:57 +00:00

WorkerStatus.h

…

WorkerTestUtils.cpp

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

WorkerTestUtils.h

Bug 1817981 - Add possibility to mark worker private being in background, r=smaug,asuth

2024-06-27 12:39:47 +00:00

WorkerThread.cpp

Bug 1905337 - Keep dispatched RefPtr<WorkerThreadRunnable> of WorkerPrivate::mPreStartRunnables. r=dom-worker-reviewers,jstutte,smaug

2024-07-03 09:59:16 +00:00

WorkerThread.h

Bug 1905337 - Keep dispatched RefPtr<WorkerThreadRunnable> of WorkerPrivate::mPreStartRunnables. r=dom-worker-reviewers,jstutte,smaug

2024-07-03 09:59:16 +00:00