a0b8501692
In this patch, we will make Safebrowsing V2 caching use the same algorithm as V4. So we remove "mMissCache" for negative caching and TableFresness check for positive caching. But Safebrowsing V2 doesn't contain negative/positive cache duration information in gethash response. So we hard-code a fixed value, 15 minutes, as cache duration. In this way, we can sync the mechanism we handle caching for V2 and V4. An extra effort for V2 here is that we need to manually record prefixes misses because we won't get any response for those prefixes(implemented in nsUrlClassifierLookupCallback::CacheMisses).
54 lines
1.6 KiB
C++
54 lines
1.6 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "Common.h"
|
|
|
|
void
|
|
TestHasPrefix(const _Fragment& aFragment, bool aExpectedHas, bool aExpectedComplete)
|
|
{
|
|
_PrefixArray array = { GeneratePrefix(_Fragment("bravo.com/"), 32),
|
|
GeneratePrefix(_Fragment("browsing.com/"), 8),
|
|
GeneratePrefix(_Fragment("gound.com/"), 5),
|
|
GeneratePrefix(_Fragment("small.com/"), 4)
|
|
};
|
|
|
|
RunTestInNewThread([&] () -> void {
|
|
UniquePtr<LookupCache> cache = SetupLookupCache<LookupCacheV4>(array);
|
|
|
|
Completion lookupHash;
|
|
nsCOMPtr<nsICryptoHash> cryptoHash = do_CreateInstance(NS_CRYPTO_HASH_CONTRACTID);
|
|
lookupHash.FromPlaintext(aFragment, cryptoHash);
|
|
|
|
bool has, confirmed;
|
|
uint32_t matchLength;
|
|
// Freshness is not used in V4 so we just put dummy values here.
|
|
TableFreshnessMap dummy;
|
|
nsresult rv =
|
|
cache->Has(lookupHash, &has, &matchLength, &confirmed);
|
|
|
|
EXPECT_EQ(rv, NS_OK);
|
|
EXPECT_EQ(has, aExpectedHas);
|
|
EXPECT_EQ(matchLength == COMPLETE_SIZE, aExpectedComplete);
|
|
EXPECT_EQ(confirmed, false);
|
|
|
|
cache->ClearAll();
|
|
});
|
|
|
|
}
|
|
|
|
TEST(LookupCacheV4, HasComplete)
|
|
{
|
|
TestHasPrefix(_Fragment("bravo.com/"), true, true);
|
|
}
|
|
|
|
TEST(LookupCacheV4, HasPrefix)
|
|
{
|
|
TestHasPrefix(_Fragment("browsing.com/"), true, false);
|
|
}
|
|
|
|
TEST(LookupCacheV4, Nomatch)
|
|
{
|
|
TestHasPrefix(_Fragment("nomatch.com/"), false, false);
|
|
}
|