Please see the bug for the motivation. This adds a new `SuggestFeature.primaryUserControlledPreference` getter that returns the feature-specific pref that lets the user toggle on/off the feature. That way we can add `QuickSuggest.clearDismissedSuggestions()`, which goes through each feature and clears that pref, and `canClearDismissedSuggestions()`, which goes through and checks whether there are any prefs that can be cleared. I also added a couple of notification topics for dismissals that the settings UI uses to update the disabled state of its Restore button. All of this will let us more easily move to the Suggest Rust component's dismissal API too, which we should sooner or later. Depends on D244865 Differential Revision: https://phabricator.services.mozilla.com/D244866
797 lines
27 KiB
JavaScript
797 lines
27 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
const lazy = {};
|
|
|
|
ChromeUtils.defineESModuleGetters(lazy, {
|
|
NimbusFeatures: "resource://nimbus/ExperimentAPI.sys.mjs",
|
|
Region: "resource://gre/modules/Region.sys.mjs",
|
|
TelemetryEnvironment: "resource://gre/modules/TelemetryEnvironment.sys.mjs",
|
|
UrlbarPrefs: "resource:///modules/UrlbarPrefs.sys.mjs",
|
|
UrlbarUtils: "resource:///modules/UrlbarUtils.sys.mjs",
|
|
});
|
|
|
|
// Suggest features classes. On init, `QuickSuggest` creates an instance of each
|
|
// class and keeps it in the `#featuresByName` map. See `SuggestFeature`.
|
|
const FEATURES = {
|
|
AddonSuggestions:
|
|
"resource:///modules/urlbar/private/AddonSuggestions.sys.mjs",
|
|
AmpSuggestions: "resource:///modules/urlbar/private/AmpSuggestions.sys.mjs",
|
|
BlockedSuggestions:
|
|
"resource:///modules/urlbar/private/BlockedSuggestions.sys.mjs",
|
|
ExposureSuggestions:
|
|
"resource:///modules/urlbar/private/ExposureSuggestions.sys.mjs",
|
|
FakespotSuggestions:
|
|
"resource:///modules/urlbar/private/FakespotSuggestions.sys.mjs",
|
|
ImpressionCaps: "resource:///modules/urlbar/private/ImpressionCaps.sys.mjs",
|
|
MDNSuggestions: "resource:///modules/urlbar/private/MDNSuggestions.sys.mjs",
|
|
OfflineWikipediaSuggestions:
|
|
"resource:///modules/urlbar/private/OfflineWikipediaSuggestions.sys.mjs",
|
|
PocketSuggestions:
|
|
"resource:///modules/urlbar/private/PocketSuggestions.sys.mjs",
|
|
SuggestBackendMerino:
|
|
"resource:///modules/urlbar/private/SuggestBackendMerino.sys.mjs",
|
|
SuggestBackendMl:
|
|
"resource:///modules/urlbar/private/SuggestBackendMl.sys.mjs",
|
|
SuggestBackendRust:
|
|
"resource:///modules/urlbar/private/SuggestBackendRust.sys.mjs",
|
|
WeatherSuggestions:
|
|
"resource:///modules/urlbar/private/WeatherSuggestions.sys.mjs",
|
|
YelpSuggestions: "resource:///modules/urlbar/private/YelpSuggestions.sys.mjs",
|
|
};
|
|
|
|
/**
|
|
* This class manages Firefox Suggest and has related helpers.
|
|
*/
|
|
class _QuickSuggest {
|
|
/**
|
|
* Prefs that will be set on the default branch when Suggest is enabled. Pref
|
|
* names are relative to `browser.urlbar.`.
|
|
*
|
|
* When Suggest is disabled, prefs will keep their defaults set in firefox.js.
|
|
*
|
|
* @returns {object}
|
|
*/
|
|
get DEFAULT_PREFS() {
|
|
return {
|
|
"quicksuggest.enabled": true,
|
|
"quicksuggest.dataCollection.enabled": false,
|
|
"suggest.quicksuggest.nonsponsored": true,
|
|
"suggest.quicksuggest.sponsored": true,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Prefs that are exposed in the UI and whose default-branch values are
|
|
* configurable via Nimbus variables. This getter returns an object that maps
|
|
* from variable names to pref names relative to `browser.urlbar`. See point 3
|
|
* in the comment inside `#initDefaultPrefs()` for more.
|
|
*
|
|
* @returns {object}
|
|
*/
|
|
get UI_PREFS_BY_VARIABLE() {
|
|
return {
|
|
quickSuggestNonSponsoredEnabled: "suggest.quicksuggest.nonsponsored",
|
|
quickSuggestSponsoredEnabled: "suggest.quicksuggest.sponsored",
|
|
quickSuggestDataCollectionEnabled: "quicksuggest.dataCollection.enabled",
|
|
};
|
|
}
|
|
|
|
/**
|
|
* @returns {string}
|
|
* The help URL for Suggest.
|
|
*/
|
|
get HELP_URL() {
|
|
return (
|
|
Services.urlFormatter.formatURLPref("app.support.baseURL") +
|
|
"firefox-suggest"
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @returns {object}
|
|
* Possible values of the `quickSuggestSettingsUi` Nimbus variable and its
|
|
* fallback pref `browser.urlbar.quicksuggest.settingsUi`. When Suggest is
|
|
* enabled, these values determine the Suggest settings that will be visible
|
|
* in `about:preferences`. When Suggest is disabled, the variable/pref are
|
|
* ignored and Suggest settings are hidden.
|
|
*/
|
|
get SETTINGS_UI() {
|
|
return {
|
|
FULL: 0,
|
|
NONE: 1,
|
|
// Only settings relevant to offline will be shown. Settings that pertain
|
|
// to online will be hidden.
|
|
OFFLINE_ONLY: 2,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* @returns {Promise}
|
|
* Resolved when Suggest initialization finishes.
|
|
*/
|
|
get initPromise() {
|
|
return this.#initResolvers.promise;
|
|
}
|
|
|
|
/**
|
|
* @returns {Array}
|
|
* Enabled Suggest backends.
|
|
*/
|
|
get enabledBackends() {
|
|
// This getter may be accessed before `init()` is called, so the backends
|
|
// may not be registered yet. Don't assume they're non-null.
|
|
return [
|
|
this.rustBackend,
|
|
this.#featuresByName.get("SuggestBackendMerino"),
|
|
this.#featuresByName.get("SuggestBackendMl"),
|
|
].filter(b => b?.isEnabled);
|
|
}
|
|
|
|
/**
|
|
* @returns {SuggestBackendRust}
|
|
* The Rust backend, which manages the Rust component.
|
|
*/
|
|
get rustBackend() {
|
|
return this.#featuresByName.get("SuggestBackendRust");
|
|
}
|
|
|
|
/**
|
|
* @returns {object}
|
|
* Global Suggest configuration stored in remote settings and ingested by
|
|
* the Rust component. See remote settings or the Rust component for the
|
|
* latest schema.
|
|
*/
|
|
get config() {
|
|
return this.rustBackend?.config || {};
|
|
}
|
|
|
|
/**
|
|
* @returns {BlockedSuggestions}
|
|
* The blocked suggestions feature.
|
|
*/
|
|
get blockedSuggestions() {
|
|
return this.#featuresByName.get("BlockedSuggestions");
|
|
}
|
|
|
|
/**
|
|
* @returns {ImpressionCaps}
|
|
* The impression caps feature.
|
|
*/
|
|
get impressionCaps() {
|
|
return this.#featuresByName.get("ImpressionCaps");
|
|
}
|
|
|
|
/**
|
|
* @returns {Set}
|
|
* The set of features that manage Rust suggestion types, as determined by
|
|
* each feature's `rustSuggestionType`.
|
|
*/
|
|
get rustFeatures() {
|
|
return new Set(this.#featuresByRustSuggestionType.values());
|
|
}
|
|
|
|
/**
|
|
* @returns {Set}
|
|
* The set of features that manage ML suggestion types, as determined by
|
|
* each feature's `mlIntent`.
|
|
*/
|
|
get mlFeatures() {
|
|
return new Set(this.#featuresByMlIntent.values());
|
|
}
|
|
|
|
get logger() {
|
|
if (!this._logger) {
|
|
this._logger = lazy.UrlbarUtils.getLogger({ prefix: "QuickSuggest" });
|
|
}
|
|
return this._logger;
|
|
}
|
|
|
|
/**
|
|
* Initializes Suggest. It's safe to call more than once.
|
|
*
|
|
* @param {object} testOverrides
|
|
* This is intended for tests only. See `#initDefaultPrefs()`.
|
|
*/
|
|
async init(testOverrides = null) {
|
|
if (this.#initStarted) {
|
|
await this.initPromise;
|
|
return;
|
|
}
|
|
this.#initStarted = true;
|
|
|
|
// Wait for dependencies to finish before initializing prefs.
|
|
//
|
|
// (1) Whether Suggest should be enabled depends on the user's region.
|
|
await lazy.Region.init();
|
|
|
|
// (2) The default-branch values of Suggest prefs that are both exposed in
|
|
// the UI and configurable by Nimbus depend on Nimbus.
|
|
await lazy.NimbusFeatures.urlbar.ready();
|
|
|
|
// (3) `TelemetryEnvironment` records the values of some Suggest prefs.
|
|
if (!this._testSkipTelemetryEnvironmentInit) {
|
|
await lazy.TelemetryEnvironment.onInitialized();
|
|
}
|
|
|
|
this.#initDefaultPrefs(testOverrides);
|
|
|
|
// Create an instance of each feature and keep it in `#featuresByName`.
|
|
for (let [name, uri] of Object.entries(FEATURES)) {
|
|
let { [name]: ctor } = ChromeUtils.importESModule(uri);
|
|
let feature = new ctor();
|
|
this.#featuresByName.set(name, feature);
|
|
if (feature.merinoProvider) {
|
|
this.#featuresByMerinoProvider.set(feature.merinoProvider, feature);
|
|
}
|
|
if (feature.rustSuggestionType) {
|
|
this.#featuresByRustSuggestionType.set(
|
|
feature.rustSuggestionType,
|
|
feature
|
|
);
|
|
}
|
|
if (feature.mlIntent) {
|
|
this.#featuresByMlIntent.set(feature.mlIntent, feature);
|
|
}
|
|
|
|
// Update the map from enabling preferences to features.
|
|
let prefs = feature.enablingPreferences;
|
|
if (prefs) {
|
|
for (let p of prefs) {
|
|
let features = this.#featuresByEnablingPrefs.get(p);
|
|
if (!features) {
|
|
features = new Set();
|
|
this.#featuresByEnablingPrefs.set(p, features);
|
|
}
|
|
features.add(feature);
|
|
}
|
|
}
|
|
}
|
|
|
|
this.#updateAll();
|
|
lazy.UrlbarPrefs.addObserver(this);
|
|
|
|
this.#initResolvers.resolve();
|
|
}
|
|
|
|
/**
|
|
* Returns a Suggest feature by name.
|
|
*
|
|
* @param {string} name
|
|
* The name of the feature's JS class.
|
|
* @returns {SuggestFeature}
|
|
* The feature object, an instance of a subclass of `SuggestFeature`.
|
|
*/
|
|
getFeature(name) {
|
|
return this.#featuresByName.get(name);
|
|
}
|
|
|
|
/**
|
|
* Returns a Suggest feature by the name of the Merino provider that serves
|
|
* its suggestions (as defined by `feature.merinoProvider`). Not all features
|
|
* correspond to a Merino provider.
|
|
*
|
|
* @param {string} provider
|
|
* The name of a Merino provider.
|
|
* @returns {SuggestProvider}
|
|
* The feature object, an instance of a subclass of `SuggestProvider`, or
|
|
* null if no feature corresponds to the Merino provider.
|
|
*/
|
|
getFeatureByMerinoProvider(provider) {
|
|
return this.#featuresByMerinoProvider.get(provider);
|
|
}
|
|
|
|
/**
|
|
* Returns a Suggest feature by the type of Rust suggestion it manages (as
|
|
* defined by `feature.rustSuggestionType`). Not all features correspond to a
|
|
* Rust suggestion type.
|
|
*
|
|
* @param {string} type
|
|
* The name of a Rust suggestion type.
|
|
* @returns {SuggestProvider}
|
|
* The feature object, an instance of a subclass of `SuggestProvider`, or
|
|
* null if no feature corresponds to the type.
|
|
*/
|
|
getFeatureByRustSuggestionType(type) {
|
|
return this.#featuresByRustSuggestionType.get(type);
|
|
}
|
|
|
|
/**
|
|
* Returns a Suggest feature by the ML intent name (as defined by
|
|
* `feature.mlIntent` and `MLSuggest`). Not all features support ML.
|
|
*
|
|
* @param {string} intent
|
|
* The name of an ML intent.
|
|
* @returns {SuggestProvider}
|
|
* The feature object, an instance of a subclass of `SuggestProvider`, or
|
|
* null if no feature corresponds to the intent.
|
|
*/
|
|
getFeatureByMlIntent(intent) {
|
|
return this.#featuresByMlIntent.get(intent);
|
|
}
|
|
|
|
/**
|
|
* Gets the Suggest feature that manages suggestions for urlbar result.
|
|
*
|
|
* @param {UrlbarResult} result
|
|
* The urlbar result.
|
|
* @returns {SuggestProvider}
|
|
* The feature instance or null if none was found.
|
|
*/
|
|
getFeatureByResult(result) {
|
|
return this.getFeatureBySource(result.payload);
|
|
}
|
|
|
|
/**
|
|
* Gets the Suggest feature that manages suggestions for a source and provider
|
|
* name. The source and provider name can be supplied from either a suggestion
|
|
* object or the payload of a `UrlbarResult` object.
|
|
*
|
|
* @param {object} options
|
|
* Options object.
|
|
* @param {string} options.source
|
|
* The suggestion source, one of: "merino", "ml", "rust"
|
|
* @param {string} options.provider
|
|
* This value depends on `source`. The possible values per source are:
|
|
*
|
|
* merino:
|
|
* The name of the Merino provider that serves the suggestion type
|
|
* ml:
|
|
* The name of the intent as determined by `MLSuggest`
|
|
* rust:
|
|
* The name of the suggestion type as defined in Rust
|
|
* @returns {SuggestProvider}
|
|
* The feature instance or null if none was found.
|
|
*/
|
|
getFeatureBySource({ source, provider }) {
|
|
switch (source) {
|
|
case "merino":
|
|
return this.getFeatureByMerinoProvider(provider);
|
|
case "rust":
|
|
return this.getFeatureByRustSuggestionType(provider);
|
|
case "ml":
|
|
return this.getFeatureByMlIntent(provider);
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Clears all dismissed suggestions, including individually dismissed
|
|
* suggestions and dismissed suggestion types.
|
|
*/
|
|
async clearDismissedSuggestions() {
|
|
// Clear the user value of each feature's primary user-controlled pref if
|
|
// its value is `false`.
|
|
for (let [name, feature] of this.#featuresByName) {
|
|
let pref = feature.primaryUserControlledPreference;
|
|
// This should never throw, but try-catch to avoid breaking the entire
|
|
// loop if `UrlbarPrefs` doesn't recognize a pref in one iteration.
|
|
try {
|
|
if (pref && !lazy.UrlbarPrefs.get(pref)) {
|
|
lazy.UrlbarPrefs.clear(pref);
|
|
}
|
|
} catch (error) {
|
|
this.logger.error("Error clearing primaryEnablingPreference", {
|
|
"feature.name": name,
|
|
pref,
|
|
error,
|
|
});
|
|
}
|
|
}
|
|
|
|
// Clear individually dismissed suggestions.
|
|
await this.blockedSuggestions?.clear();
|
|
|
|
Services.obs.notifyObservers(null, "quicksuggest-dismissals-cleared");
|
|
}
|
|
|
|
/**
|
|
* Whether there are any dismissed suggestions that can be cleared, including
|
|
* individually dismissed suggestions and dismissed suggestion types.
|
|
*
|
|
* @returns {boolean}
|
|
* Whether dismissals can be cleared.
|
|
*/
|
|
async canClearDismissedSuggestions() {
|
|
// Return true if any feature's primary user-controlled pref is `false` on
|
|
// the user branch.
|
|
for (let [name, feature] of this.#featuresByName) {
|
|
let pref = feature.primaryUserControlledPreference;
|
|
// This should never throw, but try-catch to avoid breaking the entire
|
|
// loop if `UrlbarPrefs` doesn't recognize a pref in one iteration.
|
|
try {
|
|
if (
|
|
pref &&
|
|
!lazy.UrlbarPrefs.get(pref) &&
|
|
lazy.UrlbarPrefs.hasUserValue(pref)
|
|
) {
|
|
return true;
|
|
}
|
|
} catch (error) {
|
|
this.logger.error("Error accessing primaryUserControlledPreference", {
|
|
"feature.name": name,
|
|
pref,
|
|
error,
|
|
});
|
|
}
|
|
}
|
|
|
|
// Return true if there are any individually dismissed suggestions.
|
|
let { blockedSuggestions } = this;
|
|
if (blockedSuggestions && !(await blockedSuggestions.isEmpty())) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Called when a urlbar pref changes.
|
|
*
|
|
* @param {string} pref
|
|
* The name of the pref relative to `browser.urlbar`.
|
|
*/
|
|
onPrefChanged(pref) {
|
|
// If any feature's enabling preferences changed, update it now.
|
|
let features = this.#featuresByEnablingPrefs.get(pref);
|
|
if (!features) {
|
|
return;
|
|
}
|
|
|
|
let isPrimaryUserControlledPref = false;
|
|
|
|
for (let f of features) {
|
|
f.update();
|
|
if (pref == f.primaryUserControlledPreference) {
|
|
isPrimaryUserControlledPref = true;
|
|
}
|
|
}
|
|
|
|
if (isPrimaryUserControlledPref) {
|
|
Services.obs.notifyObservers(null, "quicksuggest-dismissals-changed");
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Called when a urlbar Nimbus variable changes.
|
|
*
|
|
* @param {string} variable
|
|
* The name of the variable.
|
|
*/
|
|
onNimbusChanged(variable) {
|
|
// If a change occurred to a variable that corresponds to a pref exposed in
|
|
// the UI, sync the variable to the pref on the default branch.
|
|
if (this.UI_PREFS_BY_VARIABLE.hasOwnProperty(variable)) {
|
|
this.#syncUiVariablesToPrefs({
|
|
[variable]: this.UI_PREFS_BY_VARIABLE[variable],
|
|
});
|
|
}
|
|
|
|
// Update features.
|
|
this.#updateAll();
|
|
}
|
|
|
|
/**
|
|
* Returns whether a given URL and result URL map back to the same original
|
|
* suggestion URL.
|
|
*
|
|
* Some features may create result URLs that are potentially unique per query.
|
|
* Typically this is done by modifying an original suggestion URL at query
|
|
* time, for example by adding timestamps or query-specific search params. In
|
|
* that case, a single original suggestion URL will map to many result URLs.
|
|
* This function returns whether the given URL and result URL are equal
|
|
* excluding any such modifications.
|
|
*
|
|
* @param {string} url
|
|
* The URL to check, typically from the user's history.
|
|
* @param {UrlbarResult} result
|
|
* The Suggest result.
|
|
* @returns {boolean}
|
|
* Whether `url` is equivalent to the result's URL.
|
|
*/
|
|
isUrlEquivalentToResultUrl(url, result) {
|
|
let feature = this.getFeatureByResult(result);
|
|
return feature
|
|
? feature.isUrlEquivalentToResultUrl(url, result)
|
|
: url == result.payload.url;
|
|
}
|
|
|
|
/**
|
|
* Sets appropriate default-branch values of Suggest prefs depending on
|
|
* whether Suggest should be enabled by default.
|
|
*
|
|
* @param {object} testOverrides
|
|
* This is intended for tests only. Pass to force the following:
|
|
* `{ shouldEnable, migrationVersion, defaultPrefs }`
|
|
*/
|
|
#initDefaultPrefs(testOverrides = null) {
|
|
// Updating prefs is tricky and it's important to preserve the user's
|
|
// choices, so we describe the process in detail below. tl;dr:
|
|
//
|
|
// * Prefs exposed in the UI should be sticky.
|
|
// * Prefs that are both exposed in the UI and configurable via Nimbus
|
|
// should be added to `UI_PREFS_BY_VARIABLE`.
|
|
// * Prefs in `UI_PREFS_BY_VARIABLE` should not be specified as
|
|
// `fallbackPref` for their Nimbus variables. Access these prefs directly
|
|
// instead of through their variables.
|
|
//
|
|
// The pref-update process is described next.
|
|
//
|
|
// 1. Determine whether Suggest should be enabled by default, which depends
|
|
// on the user's region and locale.
|
|
//
|
|
// 2. Set prefs on the default branch according to whether Suggest is
|
|
// enabled. We use the default branch and not the user branch because we
|
|
// want to distinguish default prefs from the user's choices.
|
|
//
|
|
// In particular it's important to consider prefs that are exposed in the
|
|
// UI, like whether sponsored suggestions are enabled. Once the user
|
|
// makes a choice to change a default, we want to preserve that choice
|
|
// indefinitely regardless of whether Suggest is currently enabled or
|
|
// will be enabled in the future. User choices are of course recorded on
|
|
// the user branch, so if we set defaults on the user branch too, we
|
|
// wouldn't be able to distinguish user choices from default values. This
|
|
// is also why prefs that are exposed in the UI should be sticky. Unlike
|
|
// non-sticky prefs, sticky prefs retain their user-branch values even
|
|
// when those values are the same as the ones on the default branch.
|
|
//
|
|
// It's important to note that the defaults we set here do not persist
|
|
// across app restarts. (This is a feature of the pref service; prefs set
|
|
// programmatically on the default branch are not stored anywhere
|
|
// permanent like firefox.js or user.js.) That's why BrowserGlue calls
|
|
// `init()` on every startup.
|
|
//
|
|
// 3. Some prefs are both exposed in the UI and configurable via Nimbus,
|
|
// like whether data collection is enabled. We absolutely want to
|
|
// preserve the user's past choices for these prefs. But if the user
|
|
// hasn't yet made a choice for a particular pref, then it should be
|
|
// configurable.
|
|
//
|
|
// For any such prefs that have values defined in Nimbus, we set their
|
|
// default-branch values to their Nimbus values. (These defaults
|
|
// therefore override any set in the previous step.) If a pref has a user
|
|
// value, accessing the pref will return the user value; if it does not
|
|
// have a user value, accessing it will return the value that was
|
|
// specified in Nimbus.
|
|
//
|
|
// This isn't strictly necessary. Since prefs exposed in the UI are
|
|
// sticky, they will always preserve their user-branch values regardless
|
|
// of their default-branch values, and as long as a pref is listed as a
|
|
// `fallbackPref` for its corresponding Nimbus variable, Nimbus will use
|
|
// the user-branch value. So we could instead specify fallback prefs in
|
|
// Nimbus and always access values through Nimbus instead of through
|
|
// prefs. But that would make preferences UI code a little harder to
|
|
// write since the checked state of a checkbox would depend on something
|
|
// other than its pref. Since we're already setting default-branch values
|
|
// here as part of the previous step, it's not much more work to set
|
|
// defaults for these prefs too, and it makes the UI code a little nicer.
|
|
//
|
|
// 4. Migrate prefs as necessary. This refers to any pref changes that are
|
|
// neccesary across app versions: introducing and initializing new prefs,
|
|
// removing prefs, or changing the meaning of existing prefs.
|
|
|
|
let defaults = Services.prefs.getDefaultBranch("browser.urlbar.");
|
|
|
|
// Before setting defaults, save their original unmodifed values as defined
|
|
// in `firefox.js` so we can restore them if Suggest becomes disabled.
|
|
if (!this.#unmodifiedDefaultPrefs) {
|
|
this.#unmodifiedDefaultPrefs = Object.fromEntries(
|
|
Object.keys(this.DEFAULT_PREFS).map(pref => [
|
|
pref,
|
|
defaults.getBoolPref(pref),
|
|
])
|
|
);
|
|
}
|
|
|
|
// 1. Determine whether Suggest should be enabled by default
|
|
let shouldEnableSuggest;
|
|
if (testOverrides?.hasOwnProperty("shouldEnable")) {
|
|
shouldEnableSuggest = testOverrides.shouldEnable;
|
|
} else {
|
|
shouldEnableSuggest =
|
|
lazy.Region.home == "US" &&
|
|
Services.locale.appLocaleAsBCP47.substring(0, 2) == "en";
|
|
}
|
|
|
|
// 2. Set default-branch prefs according to whether Suggest should be
|
|
// enabled
|
|
if (testOverrides?.defaultPrefs) {
|
|
this.#intendedDefaultPrefs = testOverrides.defaultPrefs;
|
|
} else {
|
|
this.#intendedDefaultPrefs = shouldEnableSuggest
|
|
? this.DEFAULT_PREFS
|
|
: this.#unmodifiedDefaultPrefs;
|
|
}
|
|
|
|
for (let [name, value] of Object.entries(this.#intendedDefaultPrefs)) {
|
|
defaults.setBoolPref(name, value);
|
|
}
|
|
|
|
// 3. Set default-branch values for prefs that are both exposed in the UI
|
|
// and configurable via Nimbus
|
|
this.#syncUiVariablesToPrefs(this.UI_PREFS_BY_VARIABLE);
|
|
|
|
// 4. Migrate prefs across app versions
|
|
this._ensureFirefoxSuggestPrefsMigrated(shouldEnableSuggest, testOverrides);
|
|
}
|
|
|
|
/**
|
|
* Sets default-branch values for prefs that are both exposed in the UI and
|
|
* configurable via Nimbus.
|
|
*
|
|
* @param {object} uiPrefsByVariable
|
|
* A plain JS object that maps Nimbus variable names to their corresponding
|
|
* prefs. This should always be `UI_PREFS_BY_VARIABLE` or a subset of it.
|
|
*/
|
|
#syncUiVariablesToPrefs(uiPrefsByVariable) {
|
|
let defaults = Services.prefs.getDefaultBranch("browser.urlbar.");
|
|
for (let [variable, pref] of Object.entries(uiPrefsByVariable)) {
|
|
let value = lazy.NimbusFeatures.urlbar.getVariable(variable);
|
|
if (value === undefined) {
|
|
value = this.#intendedDefaultPrefs[pref];
|
|
}
|
|
defaults.setBoolPref(pref, value);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Updates all features.
|
|
*/
|
|
#updateAll() {
|
|
// IMPORTANT: This method is a `NimbusFeatures.urlbar.onUpdate()` callback,
|
|
// which means it's called on every change to any pref that is a fallback
|
|
// for a urlbar Nimbus variable.
|
|
|
|
// Update features.
|
|
for (let feature of this.#featuresByName.values()) {
|
|
feature.update();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The current version of the Firefox Suggest prefs.
|
|
*
|
|
* @returns {number}
|
|
*/
|
|
get MIGRATION_VERSION() {
|
|
return 2;
|
|
}
|
|
|
|
/**
|
|
* Migrates Firefox Suggest prefs to the current version if they haven't been
|
|
* migrated already.
|
|
*
|
|
* @param {boolean} shouldEnableSuggest
|
|
* Whether Suggest should be enabled right now.
|
|
* @param {object} testOverrides
|
|
* This is intended for tests only. Pass to force a migration version:
|
|
* `{ migrationVersion }`
|
|
*/
|
|
_ensureFirefoxSuggestPrefsMigrated(shouldEnableSuggest, testOverrides) {
|
|
let currentVersion =
|
|
testOverrides?.migrationVersion !== undefined
|
|
? testOverrides.migrationVersion
|
|
: this.MIGRATION_VERSION;
|
|
let lastSeenVersion = Math.max(
|
|
0,
|
|
lazy.UrlbarPrefs.get("quicksuggest.migrationVersion")
|
|
);
|
|
if (currentVersion <= lastSeenVersion) {
|
|
// Migration up to date.
|
|
return;
|
|
}
|
|
|
|
// Migrate from the last-seen version up to the current version.
|
|
let version = lastSeenVersion;
|
|
for (; version < currentVersion; version++) {
|
|
let nextVersion = version + 1;
|
|
let methodName = "_migrateFirefoxSuggestPrefsTo_" + nextVersion;
|
|
try {
|
|
this[methodName](shouldEnableSuggest);
|
|
} catch (error) {
|
|
console.error(
|
|
`Error migrating Firefox Suggest prefs to version ${nextVersion}:`,
|
|
error
|
|
);
|
|
break;
|
|
}
|
|
}
|
|
|
|
// Record the new last-seen migration version.
|
|
lazy.UrlbarPrefs.set("quicksuggest.migrationVersion", version);
|
|
}
|
|
|
|
_migrateFirefoxSuggestPrefsTo_1(shouldEnableSuggest) {
|
|
// Copy `suggest.quicksuggest` to `suggest.quicksuggest.nonsponsored` and
|
|
// clear the first.
|
|
let suggestQuicksuggest = "browser.urlbar.suggest.quicksuggest";
|
|
if (Services.prefs.prefHasUserValue(suggestQuicksuggest)) {
|
|
lazy.UrlbarPrefs.set(
|
|
"suggest.quicksuggest.nonsponsored",
|
|
Services.prefs.getBoolPref(suggestQuicksuggest)
|
|
);
|
|
Services.prefs.clearUserPref(suggestQuicksuggest);
|
|
}
|
|
|
|
// In the unversioned prefs, sponsored suggestions were shown only if the
|
|
// main suggestions pref `suggest.quicksuggest` was true, but now there are
|
|
// two independent prefs, so disable sponsored if the main pref was false.
|
|
if (
|
|
shouldEnableSuggest &&
|
|
!lazy.UrlbarPrefs.get("suggest.quicksuggest.nonsponsored")
|
|
) {
|
|
// Set the pref on the user branch. Suggestions are enabled by default
|
|
// for offline; we want to preserve the user's choice of opting out,
|
|
// and we want to preserve the default-branch true value.
|
|
lazy.UrlbarPrefs.set("suggest.quicksuggest.sponsored", false);
|
|
}
|
|
}
|
|
|
|
_migrateFirefoxSuggestPrefsTo_2() {
|
|
// In previous versions of the prefs for online, suggestions were disabled
|
|
// by default; in version 2, they're enabled by default. For users who were
|
|
// already in online and did not enable suggestions (because they did not
|
|
// opt in, they did opt in but later disabled suggestions, or they were not
|
|
// shown the modal) we don't want to suddenly enable them, so if the prefs
|
|
// do not have user-branch values, set them to false.
|
|
let scenario = Services.prefs.getCharPref(
|
|
"browser.urlbar.quicksuggest.scenario",
|
|
""
|
|
);
|
|
if (scenario == "online") {
|
|
if (
|
|
!Services.prefs.prefHasUserValue(
|
|
"browser.urlbar.suggest.quicksuggest.nonsponsored"
|
|
)
|
|
) {
|
|
lazy.UrlbarPrefs.set("suggest.quicksuggest.nonsponsored", false);
|
|
}
|
|
if (
|
|
!Services.prefs.prefHasUserValue(
|
|
"browser.urlbar.suggest.quicksuggest.sponsored"
|
|
)
|
|
) {
|
|
lazy.UrlbarPrefs.set("suggest.quicksuggest.sponsored", false);
|
|
}
|
|
}
|
|
}
|
|
|
|
async _test_reinit(testOverrides = null) {
|
|
if (this.#initStarted) {
|
|
await this.initPromise;
|
|
this.#initStarted = false;
|
|
this.#initResolvers = Promise.withResolvers();
|
|
}
|
|
await this.init(testOverrides);
|
|
}
|
|
|
|
#initStarted = false;
|
|
#initResolvers = Promise.withResolvers();
|
|
|
|
// Maps from Suggest feature class names to feature instances.
|
|
#featuresByName = new Map();
|
|
|
|
// Maps from Merino provider names to Suggest feature instances.
|
|
#featuresByMerinoProvider = new Map();
|
|
|
|
// Maps from Rust suggestion types to Suggest feature instances.
|
|
#featuresByRustSuggestionType = new Map();
|
|
|
|
// Maps from ML intent strings to Suggest feature instances.
|
|
#featuresByMlIntent = new Map();
|
|
|
|
// Maps from preference names to the `Set` of feature instances they enable.
|
|
#featuresByEnablingPrefs = new Map();
|
|
|
|
// A plain JS object that maps pref names relative to `browser.urlbar.` to
|
|
// their intended defaults depending on whether Suggest should be enabled.
|
|
#intendedDefaultPrefs;
|
|
|
|
// A plain JS object that maps pref names relative to `browser.urlbar.` to
|
|
// their original unmodified values as defined in `firefox.js`.
|
|
#unmodifiedDefaultPrefs;
|
|
}
|
|
|
|
export const QuickSuggest = new _QuickSuggest();
|