This fixes about 130 clippy lints. Let me know if i should split up the commit. I wasn't sure about some of the changes, especially map_or instead of map(...).unwrap_or(...) and if let instead of single arm match were not always a strict improvement in my opinion, but i'll leave that decision to the reviewer :) There are about 150 lints left which i thought were clippy bugs or i didn't know how to fix. cc @Manishearth Source-Repo: https://github.com/servo/servo Source-Revision: 9da739acefc7d1776bf727c8bf782eb79f241028
31 lines
1.0 KiB
Rust
31 lines
1.0 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use cssparser::{Parser, SourcePosition};
|
|
use log;
|
|
use msg::ParseErrorReporter;
|
|
use msg::constellation_msg::PipelineId;
|
|
|
|
#[derive(JSTraceable, HeapSizeOf)]
|
|
pub struct CSSErrorReporter {
|
|
pub pipelineid: PipelineId,
|
|
}
|
|
|
|
impl ParseErrorReporter for CSSErrorReporter {
|
|
fn report_error(&self, input: &mut Parser, position: SourcePosition, message: &str) {
|
|
if log_enabled!(log::LogLevel::Info) {
|
|
let location = input.source_location(position);
|
|
// TODO eventually this will got into a "web console" or something.
|
|
info!("{}:{} {}", location.line, location.column, message)
|
|
}
|
|
}
|
|
|
|
fn clone(&self) -> Box<ParseErrorReporter + Send + Sync> {
|
|
box CSSErrorReporter { pipelineid: self.pipelineid, }
|
|
}
|
|
fn pipeline(&self) -> PipelineId {
|
|
self.pipelineid
|
|
}
|
|
}
|