b5810a1eb4
This change avoids lots of false positives for Coverity's CHECKED_RETURN warning, caused by NS_WARN_IF's current use in both statement-style and expression-style. In the case where the code within the NS_WARN_IF has side-effects, I made the following change. > NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); > --> > Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); In the case where the code within the NS_WARN_IF lacks side-effects, I made the following change. > NS_WARN_IF(!condWithoutSideEffects); > --> > NS_WARNING_ASSERTION(condWithoutSideEffects, "msg"); This has two improvements. - The condition is not evaluated in non-debug builds. - The sense of the condition is inverted to the familiar "this condition should be true" sense used in assertions. A common variation on the side-effect-free case is the following. > nsresult rv = Fn(); > NS_WARN_IF_(NS_FAILED(rv)); > --> > DebugOnly<nsresult rv> = Fn(); > NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
112 lines
3.1 KiB
C++
112 lines
3.1 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "FileSystemFileEntry.h"
|
|
#include "CallbackRunnables.h"
|
|
#include "mozilla/dom/File.h"
|
|
#include "mozilla/dom/FileSystemFileEntryBinding.h"
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
namespace {
|
|
|
|
class BlobCallbackRunnable final : public Runnable
|
|
{
|
|
public:
|
|
BlobCallbackRunnable(BlobCallback* aCallback, File* aFile)
|
|
: mCallback(aCallback)
|
|
, mFile(aFile)
|
|
{
|
|
MOZ_ASSERT(aCallback);
|
|
MOZ_ASSERT(aFile);
|
|
}
|
|
|
|
NS_IMETHOD
|
|
Run() override
|
|
{
|
|
mCallback->HandleEvent(mFile);
|
|
return NS_OK;
|
|
}
|
|
|
|
private:
|
|
RefPtr<BlobCallback> mCallback;
|
|
RefPtr<File> mFile;
|
|
};
|
|
|
|
} // anonymous namespace
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_INHERITED(FileSystemFileEntry, FileSystemEntry, mFile)
|
|
|
|
NS_IMPL_ADDREF_INHERITED(FileSystemFileEntry, FileSystemEntry)
|
|
NS_IMPL_RELEASE_INHERITED(FileSystemFileEntry, FileSystemEntry)
|
|
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(FileSystemFileEntry)
|
|
NS_INTERFACE_MAP_END_INHERITING(FileSystemEntry)
|
|
|
|
FileSystemFileEntry::FileSystemFileEntry(nsIGlobalObject* aGlobal,
|
|
File* aFile,
|
|
FileSystem* aFileSystem)
|
|
: FileSystemEntry(aGlobal, aFileSystem)
|
|
, mFile(aFile)
|
|
{
|
|
MOZ_ASSERT(aGlobal);
|
|
MOZ_ASSERT(mFile);
|
|
}
|
|
|
|
FileSystemFileEntry::~FileSystemFileEntry()
|
|
{}
|
|
|
|
JSObject*
|
|
FileSystemFileEntry::WrapObject(JSContext* aCx,
|
|
JS::Handle<JSObject*> aGivenProto)
|
|
{
|
|
return FileSystemFileEntryBinding::Wrap(aCx, this, aGivenProto);
|
|
}
|
|
|
|
void
|
|
FileSystemFileEntry::GetName(nsAString& aName, ErrorResult& aRv) const
|
|
{
|
|
mFile->GetName(aName);
|
|
}
|
|
|
|
void
|
|
FileSystemFileEntry::GetFullPath(nsAString& aPath, ErrorResult& aRv) const
|
|
{
|
|
mFile->GetPath(aPath);
|
|
if (aPath.IsEmpty()) {
|
|
// We're under the root directory. webkitRelativePath
|
|
// (implemented as GetPath) is for cases when file is selected because its
|
|
// ancestor directory is selected. But that is not the case here, so need to
|
|
// manually prepend '/'.
|
|
nsAutoString name;
|
|
mFile->GetName(name);
|
|
aPath.AssignLiteral(FILESYSTEM_DOM_PATH_SEPARATOR_LITERAL);
|
|
aPath.Append(name);
|
|
}
|
|
}
|
|
|
|
void
|
|
FileSystemFileEntry::CreateWriter(VoidCallback& aSuccessCallback,
|
|
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const
|
|
{
|
|
ErrorCallbackHelper::Call(GetParentObject(), aErrorCallback,
|
|
NS_ERROR_DOM_SECURITY_ERR);
|
|
}
|
|
|
|
void
|
|
FileSystemFileEntry::GetFile(BlobCallback& aSuccessCallback,
|
|
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const
|
|
{
|
|
RefPtr<BlobCallbackRunnable> runnable =
|
|
new BlobCallbackRunnable(&aSuccessCallback, mFile);
|
|
DebugOnly<nsresult> rv = NS_DispatchToMainThread(runnable);
|
|
NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "NS_DispatchToMainThread failed");
|
|
}
|
|
|
|
} // dom namespace
|
|
} // mozilla namespace
|