Tom Schuster b5796e10bf Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer ...

I ended up having to change some of the fundamentals of the popupnotification element because the code relied on being able to inherit inline event handler attributes such as buttoncommand as oncommand on the button element and so on.

The primary user of the popupnotification element seems to be `PopupNotifications`. Following a pre-existing coupling with `PopupNotifications._onCheckboxCommand`, by default all commands/actions will simply call the corresponding `PopupNotifications` handler. However, I found at least one instance in `panelUI.js` that tries to override the command handlers. I solved this by dispatching a custom cancelable event on the popupnotification element.

Differential Revision: https://phabricator.services.mozilla.com/D231927

2024-12-18 17:38:57 +00:00

..

about

Bug 1886003 - Create about:newprofile page. r=jhirsch,mossop,fluent-reviewers,bolsson

2024-10-24 20:37:14 +00:00

aboutlogins

Bug 1936462 - show default avatar if host not in about:logins CSP r=credential-management-reviewers,mtigley,joschmidt

2024-12-15 01:46:08 +00:00

aboutwelcome

Bug 1921570 - Part 2: Render AboutWelcome in the new sidebar. r=shopping-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,kpatenio,pdahiya

2024-12-17 20:51:47 +00:00

asrouter

Bug 1934661 - Top off FxMS placeholder buffer for 135 r=omc-reviewers,hanna_a,aminomancer

2024-12-18 16:48:47 +00:00

attribution

…

backup

Bug 1837658 - enable Stylelint length-zero-no-unit r=frontend-codestyle-reviewers,desktop-theme-reviewers,mtigley,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,translations-reviewers,android-reviewers,backup-reviewers,nchevobbe,dao,mconley,tthibaud

2024-12-10 00:28:49 +00:00

build

…

contentanalysis

Bug 1926362 - make cancelling a DLP request actually cancel with the DLP agent r=dlp-reviewers,handyman

2024-12-06 14:41:37 +00:00

contextualidentity

…

controlcenter/content

Bug 1936573 - Remove inline event handlers from permission-popup. r=Gijs

2024-12-13 09:39:12 +00:00

customizableui

Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer

2024-12-18 17:38:57 +00:00

doh

…

downloads

Bug 1935974. Remove inline event handlers from downloadsPanel.inc.xhtml r=mossop

2024-12-09 13:42:59 +00:00

enterprisepolicies

Bug 1767888 - Rename BackstagePass to SystemGlobal. r=mccr8,credential-management-reviewers,peterv,dimi

2024-12-10 16:08:58 +00:00

extensions

Bug 1936523 - Remove inline event handlers from PopupNotifications. r=Gijs,extension-reviewers,reusable-components-reviewers,mstriemer

2024-12-18 17:38:57 +00:00

firefoxview

Bug 1936459 - Skip browser_dragDrop_after_opening_fxViewTab.js in non-headless mode for freq failures r=intermittent-reviewers,fxview-reviewers,jmaher,nsharpley

2024-12-17 20:36:42 +00:00

genai

Bug 1937650 - Strengthen embedded <browser> element flags in AI sidebar r=ngrato,firefox-ai-ml-reviewers

2024-12-17 21:25:51 +00:00

installerprefs

…

messagepreview

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

migration

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

newtab

Bug 1937864 - Fix spoc rendering issue when banners are enabled r=home-newtab-reviewers,maxx

2024-12-18 16:29:58 +00:00

originattributes

Backed out changeset eb47c19459dd (bug 1931058) as requested by Arai. CLOSED TREE

2024-11-28 20:22:23 +02:00

pagedata

…

places

Bug 1918615 - Remove inline event handler from editBMPanel_folderTree. r=mak,places-reviewers

2024-12-17 14:04:13 +00:00

pocket

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

preferences

Bug 1936163 - Unify Translations Language Display Names r=translations-reviewers,settings-reviewers,Gijs,gregtatum

2024-12-17 18:55:17 +00:00

privatebrowsing

No bug - Update pbz@mozilla.com -> emz@mozilla.com. r=anti-tracking-reviewers,timhuang

2024-12-17 14:01:49 +00:00

profiles

Bug 1927552 - Async fetch profiles menubar contents. r=niklas

2024-12-11 00:28:51 +00:00

prompts

…

protections

No bug - Update pbz@mozilla.com -> emz@mozilla.com. r=anti-tracking-reviewers,timhuang

2024-12-17 14:01:49 +00:00

protocolhandler

Bug 1933939 - Integrate changed API of Glean v63.0.0 r=android-reviewers,chutten,pollymce,afranchuk

2024-12-13 16:07:35 +00:00

reportbrokensite

Bug 1932148 - Include flag if BTP recently purged site in ReportBrokenSite reporter. r=webcompat-reviewers,anti-tracking-reviewers,twisniewski,timhuang

2024-11-28 11:17:24 +00:00

resistfingerprinting

Bug 1930466 - Part 1: Use zone.tab to guide time zone canonicalisation. r=dminor

2024-11-29 12:23:35 +00:00

safebrowsing/content/test

…

screenshots

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

search

Bug 1937081 - Resolve intermittent issues in browser_searchbar_addEngine.js. r=search-reviewers,scunnane

2024-12-17 10:22:55 +00:00

sessionstore

Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers

2024-12-18 15:54:21 +00:00

shell

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

shopping

Backed out changeset e78abc802629 (bug 1920832) for causing bc failures on browser_integrated_sidebar.js CLOSED TREE

2024-12-18 06:03:23 +02:00

sidebar

Bug 1933592 - Hide the sidebar launcher if the sidebar toolbar button is removed r=sidebar-reviewers,jsudiaman

2024-12-18 16:07:19 +00:00

storybook

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

syncedtabs

…

tabbrowser

Bug 1938054 - Add a zero width space to tab group labels so we always create a text node and get consistent layout even if the group is unnamed. r=jswinarton,tabbrowser-reviewers

2024-12-18 13:58:29 +00:00

tabunloader

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

tests

Bug 1897411 - Add keyboard shortcut for expanding/collapsing the new sidebar r=sidebar-reviewers,fluent-reviewers,bolsson,sclements

2024-12-12 21:34:38 +00:00

textrecognition

Bug 1936743. Re-enable some tests on macos 14.07. r=jmaher

2024-12-12 13:22:36 +00:00

topsites

…

touchbar

…

translations

Bug 1936163 - Support Script Tags for Translations r=translations-reviewers,gregtatum

2024-12-17 18:55:18 +00:00

uitour

Bug 1903658 - enable identity.fxaccounts.oauth.enabled pref by default. r=jonalmeida,fxview-reviewers,omc-reviewers,aminomancer,nsharpley,joschmidt,credential-management-reviewers

2024-11-22 04:19:56 +00:00

urlbar

Bug 1934362 - Disable persisted search telemetry test on Linux - r=urlbar-reviewers,mak

2024-12-18 15:05:11 +00:00

.eslintrc.js

…

BrowserComponents.manifest

…

BrowserContentHandler.sys.mjs

Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh

2024-11-29 15:18:25 +00:00

BrowserGlue.sys.mjs

Bug 1913421: Submit ping with at least 24 hour delay since last submission or on pref changes. r=mossop,geckoview-reviewers,tjr,tthibaud

2024-12-18 16:17:05 +00:00

components.conf

…

distribution.sys.mjs

…

metrics.yaml

No bug - Update pbz@mozilla.com -> emz@mozilla.com. r=anti-tracking-reviewers,timhuang

2024-12-17 14:01:49 +00:00

moz.build

…

nsIBrowserHandler.idl

…

StartupRecorder.sys.mjs

Bug 1934927 - on Linux listen to document-shown instead of xul-window-visible as the first paint notification in StartupRecorder.sys.mjs, r=mconley.

2024-12-16 10:12:39 +00:00