Files
tubestation/dom/webgpu/RenderBundleEncoder.cpp
Brad Werth 9fd4c45a90 Bug 1905383: Make WebGPU encoders not cycle check their subresources. r=webgpu-reviewers,teoxoy
The encoder classes already have strong references to the resources they
rely upon. That is enough to prevent those resources from being
released before the encoder. That's all we need! Including the resources
in cycle checking is just making it possible for the resource and the
encoder to be unlinked in the same cycle, in arbitrary order. That's
dangerous because it's the same outcome as if the encoder didn't have a
strong reference to the resource at all.

Differential Revision: https://phabricator.services.mozilla.com/D225914
2024-10-17 13:43:49 +00:00

226 lines
7.0 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/WebGPUBinding.h"
#include "RenderBundleEncoder.h"
#include "BindGroup.h"
#include "Buffer.h"
#include "RenderBundle.h"
#include "RenderPipeline.h"
#include "Utility.h"
#include "ipc/WebGPUChild.h"
#include "mozilla/webgpu/ffi/wgpu.h"
namespace mozilla::webgpu {
GPU_IMPL_CYCLE_COLLECTION(RenderBundleEncoder, mParent)
GPU_IMPL_JS_WRAP(RenderBundleEncoder)
void ffiWGPURenderBundleEncoderDeleter::operator()(
ffi::WGPURenderBundleEncoder* raw) {
if (raw) {
ffi::wgpu_render_bundle_encoder_destroy(raw);
}
}
ffi::WGPURenderBundleEncoder* CreateRenderBundleEncoder(
RawId aDeviceId, const dom::GPURenderBundleEncoderDescriptor& aDesc,
WebGPUChild* const aBridge) {
if (!aBridge->CanSend()) {
return nullptr;
}
ffi::WGPURenderBundleEncoderDescriptor desc = {};
desc.sample_count = aDesc.mSampleCount;
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
ffi::WGPUTextureFormat depthStencilFormat = {ffi::WGPUTextureFormat_Sentinel};
if (aDesc.mDepthStencilFormat.WasPassed()) {
depthStencilFormat =
ConvertTextureFormat(aDesc.mDepthStencilFormat.Value());
desc.depth_stencil_format = &depthStencilFormat;
}
std::vector<ffi::WGPUTextureFormat> colorFormats = {};
for (const auto i : IntegerRange(aDesc.mColorFormats.Length())) {
ffi::WGPUTextureFormat format = {ffi::WGPUTextureFormat_Sentinel};
format = ConvertTextureFormat(aDesc.mColorFormats[i]);
colorFormats.push_back(format);
}
desc.color_formats = colorFormats.data();
desc.color_formats_length = colorFormats.size();
ipc::ByteBuf failureAction;
auto* bundle = ffi::wgpu_device_create_render_bundle_encoder(
aDeviceId, &desc, ToFFI(&failureAction));
// Report an error only if the operation failed.
if (!bundle) {
aBridge->SendDeviceAction(aDeviceId, std::move(failureAction));
}
return bundle;
}
RenderBundleEncoder::RenderBundleEncoder(
Device* const aParent, WebGPUChild* const aBridge,
const dom::GPURenderBundleEncoderDescriptor& aDesc)
: ChildOf(aParent),
mEncoder(CreateRenderBundleEncoder(aParent->mId, aDesc, aBridge)) {
mValid = !!mEncoder;
}
RenderBundleEncoder::~RenderBundleEncoder() { Cleanup(); }
void RenderBundleEncoder::Cleanup() {
if (mValid) {
mValid = false;
mEncoder.release();
}
}
void RenderBundleEncoder::SetBindGroup(
uint32_t aSlot, BindGroup* const aBindGroup,
const dom::Sequence<uint32_t>& aDynamicOffsets) {
if (!mValid) {
return;
}
RawId bindGroup = 0;
if (aBindGroup) {
mUsedBindGroups.AppendElement(aBindGroup);
bindGroup = aBindGroup->mId;
}
ffi::wgpu_render_bundle_set_bind_group(mEncoder.get(), aSlot, bindGroup,
aDynamicOffsets.Elements(),
aDynamicOffsets.Length());
}
void RenderBundleEncoder::SetPipeline(const RenderPipeline& aPipeline) {
if (!mValid) {
return;
}
mUsedPipelines.AppendElement(&aPipeline);
ffi::wgpu_render_bundle_set_pipeline(mEncoder.get(), aPipeline.mId);
}
void RenderBundleEncoder::SetIndexBuffer(
const Buffer& aBuffer, const dom::GPUIndexFormat& aIndexFormat,
uint64_t aOffset, uint64_t aSize) {
if (!mValid) {
return;
}
mUsedBuffers.AppendElement(&aBuffer);
const auto iformat = aIndexFormat == dom::GPUIndexFormat::Uint32
? ffi::WGPUIndexFormat_Uint32
: ffi::WGPUIndexFormat_Uint16;
ffi::wgpu_render_bundle_set_index_buffer(mEncoder.get(), aBuffer.mId, iformat,
aOffset, aSize);
}
void RenderBundleEncoder::SetVertexBuffer(uint32_t aSlot, const Buffer& aBuffer,
uint64_t aOffset, uint64_t aSize) {
if (!mValid) {
return;
}
mUsedBuffers.AppendElement(&aBuffer);
ffi::wgpu_render_bundle_set_vertex_buffer(mEncoder.get(), aSlot, aBuffer.mId,
aOffset, aSize);
}
void RenderBundleEncoder::Draw(uint32_t aVertexCount, uint32_t aInstanceCount,
uint32_t aFirstVertex, uint32_t aFirstInstance) {
if (!mValid) {
return;
}
ffi::wgpu_render_bundle_draw(mEncoder.get(), aVertexCount, aInstanceCount,
aFirstVertex, aFirstInstance);
}
void RenderBundleEncoder::DrawIndexed(uint32_t aIndexCount,
uint32_t aInstanceCount,
uint32_t aFirstIndex, int32_t aBaseVertex,
uint32_t aFirstInstance) {
if (!mValid) {
return;
}
ffi::wgpu_render_bundle_draw_indexed(mEncoder.get(), aIndexCount,
aInstanceCount, aFirstIndex, aBaseVertex,
aFirstInstance);
}
void RenderBundleEncoder::DrawIndirect(const Buffer& aIndirectBuffer,
uint64_t aIndirectOffset) {
if (!mValid) {
return;
}
ffi::wgpu_render_bundle_draw_indirect(mEncoder.get(), aIndirectBuffer.mId,
aIndirectOffset);
}
void RenderBundleEncoder::DrawIndexedIndirect(const Buffer& aIndirectBuffer,
uint64_t aIndirectOffset) {
if (!mValid) {
return;
}
ffi::wgpu_render_bundle_draw_indexed_indirect(
mEncoder.get(), aIndirectBuffer.mId, aIndirectOffset);
}
void RenderBundleEncoder::PushDebugGroup(const nsAString& aString) {
if (!mValid) {
return;
}
const NS_ConvertUTF16toUTF8 utf8(aString);
ffi::wgpu_render_bundle_push_debug_group(mEncoder.get(), utf8.get());
}
void RenderBundleEncoder::PopDebugGroup() {
if (!mValid) {
return;
}
ffi::wgpu_render_bundle_pop_debug_group(mEncoder.get());
}
void RenderBundleEncoder::InsertDebugMarker(const nsAString& aString) {
if (!mValid) {
return;
}
const NS_ConvertUTF16toUTF8 utf8(aString);
ffi::wgpu_render_bundle_insert_debug_marker(mEncoder.get(), utf8.get());
}
already_AddRefed<RenderBundle> RenderBundleEncoder::Finish(
const dom::GPURenderBundleDescriptor& aDesc) {
RawId deviceId = mParent->mId;
auto bridge = mParent->GetBridge();
MOZ_RELEASE_ASSERT(bridge);
ffi::WGPURenderBundleDescriptor desc = {};
webgpu::StringHelper label(aDesc.mLabel);
desc.label = label.Get();
ipc::ByteBuf bb;
RawId id;
if (mValid) {
id = ffi::wgpu_client_create_render_bundle(
bridge->GetClient(), mEncoder.get(), &desc, ToFFI(&bb));
} else {
id = ffi::wgpu_client_create_render_bundle_error(bridge->GetClient(),
label.Get(), ToFFI(&bb));
}
if (bridge->CanSend()) {
bridge->SendDeviceAction(deviceId, std::move(bb));
}
Cleanup();
RefPtr<RenderBundle> bundle = new RenderBundle(mParent, id);
return bundle.forget();
}
} // namespace mozilla::webgpu