f031088fb4
extensions.json can miss the data_collection field when it was generated by a Firefox version that did not support it. The implementation did not account for this, and prevented extensions from updating due to a runtime error. This patch fixes the issue by adding a null check, and unit tests for background updates. The unit test does not exercise the code path of the "manual update" scenario from the bug, because of complexity and the fact that its implementation is going to be replaced with the same logic of the background update check (bug 1974732). This patch also includes smaller fixups related to this bug and patch: - https://phabricator.services.mozilla.com/D263925 - https://phabricator.services.mozilla.com/D264372 Original Revision: https://phabricator.services.mozilla.com/D264155 Differential Revision: https://phabricator.services.mozilla.com/D264618