5e3a0a2a5c
Unfortunately, upload streams used by necko have various odd behaviours and requirements which happened to be usually preserved by the previous IPC serialization logic, but were not consistently preserved. This includes requiring the stream to be synchronous (as some consumers such as WebExtensions and DevTools appear to read it assuming Available() is the stream length), seekable (as it needs to be rewound in various places), and cloneable (as the stream information is often handed out to other components). In addition, the WebExtension WebRequest code makes assumptions about the specific topology of the input stream for optimization purposes, meaning that nsMultiplexInputStreams need to be preserved. The way this was previously handled was by copying the entire payload into a nsStorageStream as an async operation. This happened very infrequently in out test suite, however, and had some issues. It could lead to data loss if the stream was a nsMIMEInputStream (as the metadata would be lost), and would destroy the topology required by WebRequest. This patch changes the code to instead manually walk and replace streams in the input stream's data structure, to efficiently copy only the required data, preserve the invariants, and make the type seekable before AsyncOpen continues. This helps keep the complexity of the invariants HTTPChannel depends on out of generic input stream handling code. In addition, due to how early this happens, it replaces the need for PartiallySeekableInputStream which will be removed a later part. Differential Revision: https://phabricator.services.mozilla.com/D141044
36 lines
1.2 KiB
Plaintext
36 lines
1.2 KiB
Plaintext
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "nsIInputStream.idl"
|
|
|
|
/**
|
|
* The multiplex stream concatenates a list of input streams into a single
|
|
* stream.
|
|
*/
|
|
|
|
[scriptable, builtinclass, uuid(a076fd12-1dd1-11b2-b19a-d53b5dffaade)]
|
|
interface nsIMultiplexInputStream : nsISupports
|
|
{
|
|
/**
|
|
* Number of streams in this multiplex-stream
|
|
*/
|
|
[infallible] readonly attribute unsigned long count;
|
|
|
|
/**
|
|
* Appends a stream to the end of the streams. The cursor of the stream
|
|
* should be located at the beginning of the stream if the implementation
|
|
* of this nsIMultiplexInputStream also is used as an nsISeekableStream.
|
|
* @param stream stream to append
|
|
*/
|
|
void appendStream(in nsIInputStream stream);
|
|
|
|
/**
|
|
* Get stream at specified index.
|
|
* @param index return stream at this index, must be < count
|
|
* @return stream at specified index
|
|
*/
|
|
nsIInputStream getStream(in unsigned long index);
|
|
};
|