Files
tubestation/dom/performance/PerformanceWorker.h
Eden Chuang 41a3e7f280 Bug 1752856 - Null CheckedUnsafePtr<WorkerPrivate> for members of WorkerGlobalScope when releaseing WorkerPrivate. r=dom-worker-reviewers,asuth,smaug
In some unusual cases, WorkerGlobalScope could live longer than WorkerPrivate since some other objects hold a reference on WorkerGlobalScope. We try to use CC/GC to release WorkerGlobalScope and force disconnect them from the WorkerPrivate before releasing WorkerPrivate. https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/dom/workers/RuntimeService.cpp#2068-2109

The previous implementation focused on nulling the WorkerGlobalScopeBase::mWorkerPrivate. However, it is not enough since WorkerGlobalScope's member could possibly hold a CheckedUnsafePtr<WorkerPrivate>, i.e. WorkerGlobalScope::mPerformance.

In this patch, we focus on breaking these connections.

Differential Revision: https://phabricator.services.mozilla.com/D162575
2022-11-30 14:27:51 +00:00

103 lines
2.8 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_PerformanceWorker_h
#define mozilla_dom_PerformanceWorker_h
#include "Performance.h"
#include "mozilla/dom/WorkerPrivate.h"
namespace mozilla::dom {
class PerformanceWorker final : public Performance {
public:
explicit PerformanceWorker(WorkerPrivate* aWorkerPrivate);
PerformanceStorage* AsPerformanceStorage() override {
MOZ_CRASH("This should not be called on workers.");
return nullptr;
}
virtual PerformanceTiming* Timing() override {
MOZ_CRASH("This should not be called on workers.");
return nullptr;
}
virtual PerformanceNavigation* Navigation() override {
MOZ_CRASH("This should not be called on workers.");
return nullptr;
}
virtual void SetFCPTimingEntry(PerformancePaintTiming* aEntry) override {
MOZ_CRASH("This should not be called on workers.");
}
TimeStamp CreationTimeStamp() const override;
DOMHighResTimeStamp CreationTime() const override;
virtual void GetMozMemory(JSContext* aCx,
JS::MutableHandle<JSObject*> aObj) override {
MOZ_CRASH("This should not be called on workers.");
}
virtual nsDOMNavigationTiming* GetDOMTiming() const override {
MOZ_CRASH("This should not be called on workers.");
return nullptr;
}
virtual uint64_t GetRandomTimelineSeed() override;
virtual nsITimedChannel* GetChannel() const override {
MOZ_CRASH("This should not be called on workers.");
return nullptr;
}
void QueueNavigationTimingEntry() override {
MOZ_CRASH("This should not be called on workers.");
}
void UpdateNavigationTimingEntry() override {
MOZ_CRASH("This should not be called on workers.");
}
void InsertEventTimingEntry(PerformanceEventTiming*) override {
MOZ_CRASH("This should not be called on workers.");
}
void BufferEventTimingEntryIfNeeded(PerformanceEventTiming*) override {
MOZ_CRASH("This should not be called on workers.");
}
void DispatchPendingEventTimingEntries() override {
MOZ_CRASH("This should not be called on workders.");
}
class EventCounts* EventCounts() override {
MOZ_CRASH("This should not be called on workers");
}
bool CrossOriginIsolated() const override;
void NoteShuttingDown();
protected:
~PerformanceWorker();
void InsertUserEntry(PerformanceEntry* aEntry) override;
void DispatchBufferFullEvent() override {
// Nothing to do here. See bug 1432758.
}
private:
CheckedUnsafePtr<WorkerPrivate> mWorkerPrivate;
};
} // namespace mozilla::dom
#endif // mozilla_dom_PerformanceWorker_h