Files
tubestation/dom/performance/PerformanceWorker.cpp
Eden Chuang 41a3e7f280 Bug 1752856 - Null CheckedUnsafePtr<WorkerPrivate> for members of WorkerGlobalScope when releaseing WorkerPrivate. r=dom-worker-reviewers,asuth,smaug
In some unusual cases, WorkerGlobalScope could live longer than WorkerPrivate since some other objects hold a reference on WorkerGlobalScope. We try to use CC/GC to release WorkerGlobalScope and force disconnect them from the WorkerPrivate before releasing WorkerPrivate. https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/dom/workers/RuntimeService.cpp#2068-2109

The previous implementation focused on nulling the WorkerGlobalScopeBase::mWorkerPrivate. However, it is not enough since WorkerGlobalScope's member could possibly hold a CheckedUnsafePtr<WorkerPrivate>, i.e. WorkerGlobalScope::mPerformance.

In this patch, we focus on breaking these connections.

Differential Revision: https://phabricator.services.mozilla.com/D162575
2022-11-30 14:27:51 +00:00

74 lines
2.2 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "PerformanceWorker.h"
#include "mozilla/dom/WorkerScope.h"
#include "mozilla/StaticPrefs_dom.h"
namespace mozilla::dom {
PerformanceWorker::PerformanceWorker(WorkerPrivate* aWorkerPrivate)
: Performance(aWorkerPrivate->GlobalScope()),
mWorkerPrivate(aWorkerPrivate) {
mWorkerPrivate->AssertIsOnWorkerThread();
mRTPCallerType = aWorkerPrivate->GlobalScope()->GetRTPCallerType();
}
PerformanceWorker::~PerformanceWorker() {
if (mWorkerPrivate) {
mWorkerPrivate->AssertIsOnWorkerThread();
}
}
void PerformanceWorker::InsertUserEntry(PerformanceEntry* aEntry) {
if (StaticPrefs::dom_performance_enable_user_timing_logging()) {
nsAutoCString uri;
nsCOMPtr<nsIURI> scriptURI = mWorkerPrivate->GetResolvedScriptURI();
if (!scriptURI || NS_FAILED(scriptURI->GetHost(uri))) {
// If we have no URI, just put in "none".
uri.AssignLiteral("none");
}
Performance::LogEntry(aEntry, uri);
}
Performance::InsertUserEntry(aEntry);
}
TimeStamp PerformanceWorker::CreationTimeStamp() const {
MOZ_DIAGNOSTIC_ASSERT(mWorkerPrivate);
if (mWorkerPrivate) {
return mWorkerPrivate->CreationTimeStamp();
}
return TimeStamp();
}
DOMHighResTimeStamp PerformanceWorker::CreationTime() const {
MOZ_DIAGNOSTIC_ASSERT(mWorkerPrivate);
if (mWorkerPrivate) {
return mWorkerPrivate->CreationTime();
}
return DOMHighResTimeStamp();
}
uint64_t PerformanceWorker::GetRandomTimelineSeed() {
MOZ_DIAGNOSTIC_ASSERT(mWorkerPrivate);
if (mWorkerPrivate) {
return mWorkerPrivate->GetRandomTimelineSeed();
}
return 0;
}
bool PerformanceWorker::CrossOriginIsolated() const {
MOZ_DIAGNOSTIC_ASSERT(mWorkerPrivate);
if (mWorkerPrivate) {
return mWorkerPrivate->CrossOriginIsolated();
}
return false;
}
void PerformanceWorker::NoteShuttingDown() { mWorkerPrivate = nullptr; }
} // namespace mozilla::dom