4026d176c2
As mentioned in https://en.cppreference.com/w/cpp/string/byte/memcpy, memcpy requires trivially copyable types. Same property holds for memset. GCC checks this, and clang will do in next release. In both cases it can be silenced locally by casting the destination parameter to void*. This patch introduces the following changes: - AssignRangeAlgorithm was dispatching on the trivially constructable trait, not trivially copyable. Note that it is basically a reimplementation of std::uninitialized_copy_n, but using the later would by-pass some specialization of nsTArrayElementTraits<T>::Construct. - ShBuiltInResources default constructor already performs a memset - mCachedAnonymousContentStyleIndexes used to contain std::pair<uint8_t, uint8_t> which is not trivially copyable (!) at least under older libstdc++. Use a more explicit POD type instead. - PodOperations.h was not checking type requirements, it now does and issue a compilation error in case of misuse. - NetAddr copy and default constructors are already defined, so use them instead of plain memset/memcpy. - NetAddr has a copy constructor from PSNetAddr*, use it instead of a plain memcpy. - Do not create a temporary mozilla::phc::AddrInfo through a memcpy when what we actually want is a reintepret_cast. Still perform a memcpy on the bytes to enforce alignment. Differential Revision: https://phabricator.services.mozilla.com/D231203
139 lines
3.1 KiB
C++
139 lines
3.1 KiB
C++
/* vim: et ts=2 sw=2 tw=80
|
|
*/
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "nsNetAddr.h"
|
|
#include "nsString.h"
|
|
#include "mozilla/net/DNS.h"
|
|
|
|
using namespace mozilla::net;
|
|
|
|
NS_IMPL_ISUPPORTS(nsNetAddr, nsINetAddr)
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetFamily(uint16_t* aFamily) {
|
|
switch (mAddr.raw.family) {
|
|
case AF_INET:
|
|
*aFamily = nsINetAddr::FAMILY_INET;
|
|
break;
|
|
case AF_INET6:
|
|
*aFamily = nsINetAddr::FAMILY_INET6;
|
|
break;
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
*aFamily = nsINetAddr::FAMILY_LOCAL;
|
|
break;
|
|
#endif
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetAddress(nsACString& aAddress) {
|
|
switch (mAddr.raw.family) {
|
|
/* PR_NetAddrToString can handle INET and INET6, but not LOCAL. */
|
|
case AF_INET:
|
|
aAddress.SetLength(kIPv4CStrBufSize);
|
|
mAddr.ToStringBuffer(aAddress.BeginWriting(), kIPv4CStrBufSize);
|
|
aAddress.SetLength(strlen(aAddress.BeginReading()));
|
|
break;
|
|
case AF_INET6:
|
|
aAddress.SetLength(kIPv6CStrBufSize);
|
|
mAddr.ToStringBuffer(aAddress.BeginWriting(), kIPv6CStrBufSize);
|
|
aAddress.SetLength(strlen(aAddress.BeginReading()));
|
|
break;
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
aAddress.Assign(mAddr.local.path);
|
|
break;
|
|
#endif
|
|
// PR_AF_LOCAL falls through to default when not XP_UNIX
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetPort(uint16_t* aPort) {
|
|
switch (mAddr.raw.family) {
|
|
case AF_INET:
|
|
*aPort = ntohs(mAddr.inet.port);
|
|
break;
|
|
case AF_INET6:
|
|
*aPort = ntohs(mAddr.inet6.port);
|
|
break;
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
// There is no port number for local / connections.
|
|
return NS_ERROR_NOT_AVAILABLE;
|
|
#endif
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetFlow(uint32_t* aFlow) {
|
|
switch (mAddr.raw.family) {
|
|
case AF_INET6:
|
|
*aFlow = ntohl(mAddr.inet6.flowinfo);
|
|
break;
|
|
case AF_INET:
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
#endif
|
|
// only for IPv6
|
|
return NS_ERROR_NOT_AVAILABLE;
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetScope(uint32_t* aScope) {
|
|
switch (mAddr.raw.family) {
|
|
case AF_INET6:
|
|
*aScope = ntohl(mAddr.inet6.scope_id);
|
|
break;
|
|
case AF_INET:
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
#endif
|
|
// only for IPv6
|
|
return NS_ERROR_NOT_AVAILABLE;
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetIsV4Mapped(bool* aIsV4Mapped) {
|
|
switch (mAddr.raw.family) {
|
|
case AF_INET6:
|
|
*aIsV4Mapped = IPv6ADDR_IS_V4MAPPED(&mAddr.inet6.ip);
|
|
break;
|
|
case AF_INET:
|
|
#if defined(XP_UNIX)
|
|
case AF_LOCAL:
|
|
#endif
|
|
// only for IPv6
|
|
return NS_ERROR_NOT_AVAILABLE;
|
|
default:
|
|
return NS_ERROR_UNEXPECTED;
|
|
}
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP nsNetAddr::GetNetAddr(NetAddr* aResult) {
|
|
*aResult = mAddr;
|
|
return NS_OK;
|
|
}
|