Files
tubestation/browser/components/urlbar
Drew Willcoxon 5f4b628014 Bug 1941989 - Split AdmWikipedia into two modules and send the quick-suggest ping only for AMP suggestions. r=daisuke
This makes two major changes:

Split `AdmWikipedia` into `AmpSuggestions` and `OfflineWikipediaSuggestions`. I
included "offline" in the name because Merino also serves Wikipedia suggestions,
but they're the so-called "dynamic Wikipedia" suggestions served from
Elasticsearch, and they have never been managed by a
`BaseFeature`/`SuggestFeature` in Firefox.

Send the `quick-suggest` ping only for AMP suggestions, in `AmpSuggestions`.
Stop sending it for offline Wikipedia suggestions. @bholley and I discussed this
on the data-review@mozilla.com list after I emailed it for the senstive data
review in D233752 [1]. We only use the ping for AMP suggestions, and Wikipedia
telemetry should follow the usual data opt-out. @nanj agreed the ping isn't
necessary for Wikipedia.

[1] https://groups.google.com/a/mozilla.com/g/data-review/c/BC2JKaXA7nA

Depends on D234440

Differential Revision: https://phabricator.services.mozilla.com/D234449
2025-01-17 02:34:38 +00:00
..