http://www.robohornet.org gives a score of 101.36 on master, and 102.68 with this PR. The latter is slightly better, but probably within noise level. So it looks like this PR does not affect DOM performance. This is expected since `Box::new` is defined as: ```rust impl<T> Box<T> { #[inline(always)] pub fn new(x: T) -> Box<T> { box x } } ``` With inlining, it should compile to the same as box syntax. Source-Repo: https://github.com/servo/servo Source-Revision: a9022be0c3e30249845ca5947ac0c0a6743c7991
107 lines
3.8 KiB
Rust
107 lines
3.8 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use cssparser::RGBA;
|
|
use dom::bindings::codegen::Bindings::HTMLTableSectionElementBinding::{self, HTMLTableSectionElementMethods};
|
|
use dom::bindings::codegen::Bindings::NodeBinding::NodeMethods;
|
|
use dom::bindings::error::{ErrorResult, Fallible};
|
|
use dom::bindings::inheritance::Castable;
|
|
use dom::bindings::root::{DomRoot, LayoutDom, RootedReference};
|
|
use dom::bindings::str::DOMString;
|
|
use dom::document::Document;
|
|
use dom::element::{Element, RawLayoutElementHelpers};
|
|
use dom::htmlcollection::{CollectionFilter, HTMLCollection};
|
|
use dom::htmlelement::HTMLElement;
|
|
use dom::htmltablerowelement::HTMLTableRowElement;
|
|
use dom::node::{Node, window_from_node};
|
|
use dom::virtualmethods::VirtualMethods;
|
|
use dom_struct::dom_struct;
|
|
use html5ever::{LocalName, Prefix};
|
|
use style::attr::AttrValue;
|
|
|
|
#[dom_struct]
|
|
pub struct HTMLTableSectionElement {
|
|
htmlelement: HTMLElement,
|
|
}
|
|
|
|
impl HTMLTableSectionElement {
|
|
fn new_inherited(local_name: LocalName, prefix: Option<Prefix>, document: &Document)
|
|
-> HTMLTableSectionElement {
|
|
HTMLTableSectionElement {
|
|
htmlelement: HTMLElement::new_inherited(local_name, prefix, document),
|
|
}
|
|
}
|
|
|
|
#[allow(unrooted_must_root)]
|
|
pub fn new(local_name: LocalName, prefix: Option<Prefix>, document: &Document)
|
|
-> DomRoot<HTMLTableSectionElement> {
|
|
Node::reflect_node(Box::new(HTMLTableSectionElement::new_inherited(local_name, prefix, document)),
|
|
document,
|
|
HTMLTableSectionElementBinding::Wrap)
|
|
}
|
|
}
|
|
|
|
#[derive(JSTraceable)]
|
|
struct RowsFilter;
|
|
impl CollectionFilter for RowsFilter {
|
|
fn filter(&self, elem: &Element, root: &Node) -> bool {
|
|
elem.is::<HTMLTableRowElement>() &&
|
|
elem.upcast::<Node>().GetParentNode().r() == Some(root)
|
|
}
|
|
}
|
|
|
|
impl HTMLTableSectionElementMethods for HTMLTableSectionElement {
|
|
// https://html.spec.whatwg.org/multipage/#dom-tbody-rows
|
|
fn Rows(&self) -> DomRoot<HTMLCollection> {
|
|
HTMLCollection::create(&window_from_node(self), self.upcast(), Box::new(RowsFilter))
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-tbody-insertrow
|
|
fn InsertRow(&self, index: i32) -> Fallible<DomRoot<HTMLElement>> {
|
|
let node = self.upcast::<Node>();
|
|
node.insert_cell_or_row(
|
|
index,
|
|
|| self.Rows(),
|
|
|| HTMLTableRowElement::new(local_name!("tr"), None, &node.owner_doc()))
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-tbody-deleterow
|
|
fn DeleteRow(&self, index: i32) -> ErrorResult {
|
|
let node = self.upcast::<Node>();
|
|
node.delete_cell_or_row(
|
|
index,
|
|
|| self.Rows(),
|
|
|n| n.is::<HTMLTableRowElement>())
|
|
}
|
|
}
|
|
|
|
pub trait HTMLTableSectionElementLayoutHelpers {
|
|
fn get_background_color(&self) -> Option<RGBA>;
|
|
}
|
|
|
|
#[allow(unsafe_code)]
|
|
impl HTMLTableSectionElementLayoutHelpers for LayoutDom<HTMLTableSectionElement> {
|
|
fn get_background_color(&self) -> Option<RGBA> {
|
|
unsafe {
|
|
(&*self.upcast::<Element>().unsafe_get())
|
|
.get_attr_for_layout(&ns!(), &local_name!("bgcolor"))
|
|
.and_then(AttrValue::as_color)
|
|
.cloned()
|
|
}
|
|
}
|
|
}
|
|
|
|
impl VirtualMethods for HTMLTableSectionElement {
|
|
fn super_type(&self) -> Option<&VirtualMethods> {
|
|
Some(self.upcast::<HTMLElement>() as &VirtualMethods)
|
|
}
|
|
|
|
fn parse_plain_attribute(&self, local_name: &LocalName, value: DOMString) -> AttrValue {
|
|
match *local_name {
|
|
local_name!("bgcolor") => AttrValue::from_legacy_color(value.into()),
|
|
_ => self.super_type().unwrap().parse_plain_attribute(local_name, value),
|
|
}
|
|
}
|
|
}
|