Ensure source links for selectors in the Rules view and warning links in Web Console for minified CSS go to the right location in the Style Editor after applying automatic prettification. This only works for linked stylesheets. [Bug 1169770](https://bugzilla.mozilla.org/show_bug.cgi?id=1169770) needs to be fixed first before this can work correctly on inline minified stylesheets. This patch augments the `prettifyCSS()` method to generate the mappings necessary to generate a sourcemap from the original to the prettified source. It uses these mappings to translate the cursor position when invoking the Style Editor to be opened at a specific location. The mappings from the minified to the prettified source are used only until the stylesheet is changed in the Style Editor. Upon editing the source in the Style Editor, the associated mappings are cleared because it's likely they have been rendered invalid. The updated stylesheet will already be prettified so it bypasses the `prettifyCSS()` method, thus avoiding the need to re-generate mappings. New CSS warnings will be listed in the Web Console which point to the right location in the edited stylesheet (the old warnings no longer point to the right place, but that's an acceptable side-effect). The Rules view in the Inspector also lists selectors with the new positions within the edited stylesheet. Differential Revision: https://phabricator.services.mozilla.com/D36585
527 lines
16 KiB
JavaScript
527 lines
16 KiB
JavaScript
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
|
/* vim: set ts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
const InspectorUtils = require("InspectorUtils");
|
|
|
|
const MAX_DATA_URL_LENGTH = 40;
|
|
/**
|
|
* Provide access to the style information in a page.
|
|
* CssLogic uses the standard DOM API, and the Gecko InspectorUtils API to
|
|
* access styling information in the page, and present this to the user in a way
|
|
* that helps them understand:
|
|
* - why their expectations may not have been fulfilled
|
|
* - how browsers process CSS
|
|
* @constructor
|
|
*/
|
|
|
|
const Services = require("Services");
|
|
|
|
loader.lazyImporter(this, "findCssSelector", "resource://gre/modules/css-selector.js");
|
|
loader.lazyImporter(this, "getCssPath", "resource://gre/modules/css-selector.js");
|
|
loader.lazyImporter(this, "getXPath", "resource://gre/modules/css-selector.js");
|
|
loader.lazyRequireGetter(this, "getCSSLexer", "devtools/shared/css/lexer", true);
|
|
loader.lazyRequireGetter(this, "getTabPrefs", "devtools/shared/indentation", true);
|
|
|
|
const {LocalizationHelper} = require("devtools/shared/l10n");
|
|
const styleInspectorL10N =
|
|
new LocalizationHelper("devtools/shared/locales/styleinspector.properties");
|
|
|
|
/**
|
|
* Special values for filter, in addition to an href these values can be used
|
|
*/
|
|
exports.FILTER = {
|
|
// show properties for all user style sheets.
|
|
USER: "user",
|
|
// USER, plus user-agent (i.e. browser) style sheets
|
|
UA: "ua",
|
|
};
|
|
|
|
/**
|
|
* Each rule has a status, the bigger the number, the better placed it is to
|
|
* provide styling information.
|
|
*
|
|
* These statuses are localized inside the styleinspector.properties
|
|
* string bundle.
|
|
* @see csshtmltree.js RuleView._cacheStatusNames()
|
|
*/
|
|
exports.STATUS = {
|
|
BEST: 3,
|
|
MATCHED: 2,
|
|
PARENT_MATCH: 1,
|
|
UNMATCHED: 0,
|
|
UNKNOWN: -1,
|
|
};
|
|
|
|
/**
|
|
* Mapping of CSSRule type value to CSSRule type name.
|
|
* @see https://developer.mozilla.org/en-US/docs/Web/API/CSSRule
|
|
*/
|
|
exports.CSSRuleTypeName = {
|
|
1: "", // Regular CSS style rule has no name
|
|
3: "@import",
|
|
4: "@media",
|
|
5: "@font-face",
|
|
6: "@page",
|
|
7: "@keyframes",
|
|
8: "@keyframe",
|
|
10: "@namespace",
|
|
11: "@counter-style",
|
|
12: "@supports",
|
|
13: "@document",
|
|
14: "@font-feature-values",
|
|
15: "@viewport",
|
|
};
|
|
|
|
/**
|
|
* Lookup a l10n string in the shared styleinspector string bundle.
|
|
*
|
|
* @param {String} name
|
|
* The key to lookup.
|
|
* @returns {String} A localized version of the given key.
|
|
*/
|
|
exports.l10n = name => styleInspectorL10N.getStr(name);
|
|
|
|
/**
|
|
* Is the given property sheet an author stylesheet?
|
|
*
|
|
* @param {CSSStyleSheet} sheet a stylesheet
|
|
* @return {boolean} true if the given stylesheet is an author stylesheet,
|
|
* false otherwise.
|
|
*/
|
|
exports.isAuthorStylesheet = function(sheet) {
|
|
return sheet.parsingMode === "author";
|
|
};
|
|
|
|
/**
|
|
* Is the given property sheet a user stylesheet?
|
|
*
|
|
* @param {CSSStyleSheet} sheet a stylesheet
|
|
* @return {boolean} true if the given stylesheet is a user stylesheet,
|
|
* false otherwise.
|
|
*/
|
|
exports.isUserStylesheet = function(sheet) {
|
|
return sheet.parsingMode === "user";
|
|
};
|
|
|
|
/**
|
|
* Is the given property sheet a agent stylesheet?
|
|
*
|
|
* @param {CSSStyleSheet} sheet a stylesheet
|
|
* @return {boolean} true if the given stylesheet is a agent stylesheet,
|
|
* false otherwise.
|
|
*/
|
|
exports.isAgentStylesheet = function(sheet) {
|
|
return sheet.parsingMode === "agent";
|
|
};
|
|
|
|
/**
|
|
* Return a shortened version of a style sheet's source.
|
|
*
|
|
* @param {CSSStyleSheet} sheet the DOM object for the style sheet.
|
|
*/
|
|
exports.shortSource = function(sheet) {
|
|
// Use a string like "inline" if there is no source href
|
|
if (!sheet || !sheet.href) {
|
|
return exports.l10n("rule.sourceInline");
|
|
}
|
|
|
|
// If the sheet is a data URL, return a trimmed version of it.
|
|
const dataUrl = sheet.href.trim().match(/^data:.*?,((?:.|\r|\n)*)$/);
|
|
if (dataUrl) {
|
|
return dataUrl[1].length > MAX_DATA_URL_LENGTH ?
|
|
`${dataUrl[1].substr(0, MAX_DATA_URL_LENGTH - 1)}…` : dataUrl[1];
|
|
}
|
|
|
|
// We try, in turn, the filename, filePath, query string, whole thing
|
|
let url = {};
|
|
try {
|
|
url = new URL(sheet.href);
|
|
} catch (ex) {
|
|
// Some UA-provided stylesheets are not valid URLs.
|
|
}
|
|
|
|
if (url.pathname) {
|
|
const index = url.pathname.lastIndexOf("/");
|
|
if (index !== -1 && index < url.pathname.length) {
|
|
return url.pathname.slice(index + 1);
|
|
}
|
|
return url.pathname;
|
|
}
|
|
|
|
if (url.query) {
|
|
return url.query;
|
|
}
|
|
|
|
return sheet.href;
|
|
};
|
|
|
|
const TAB_CHARS = "\t";
|
|
const SPACE_CHARS = " ";
|
|
|
|
function getLineCountInComments(text) {
|
|
let count = 0;
|
|
|
|
for (const comment of text.match(/\/\*(?:.|\n)*?\*\//mg) || []) {
|
|
count += comment.split("\n").length + 1;
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
/**
|
|
* Prettify minified CSS text.
|
|
* This prettifies CSS code where there is no indentation in usual places while
|
|
* keeping original indentation as-is elsewhere.
|
|
*
|
|
* Returns an object with the resulting prettified source and a list of mappings of
|
|
* token positions between the original and the prettified source. Each single mapping
|
|
* is an object that looks like this:
|
|
*
|
|
* {
|
|
* original: {line: {Number}, column: {Number}},
|
|
* generated: {line: {Number}, column: {Number}},
|
|
* }
|
|
*
|
|
* @param {String} text
|
|
* The CSS source to prettify.
|
|
* @param {Number} ruleCount
|
|
* The number of CSS rules expected in the CSS source.
|
|
*
|
|
* @return {Object}
|
|
* Object with the prettified source and source mappings.
|
|
* {
|
|
* result: {String} // Prettified source
|
|
* mappings: {Array} // List of objects with mappings for lines and columns
|
|
* // between the original source and prettified source
|
|
* }
|
|
*/
|
|
/* eslint-disable complexity */
|
|
function prettifyCSS(text, ruleCount) {
|
|
if (prettifyCSS.LINE_SEPARATOR == null) {
|
|
const os = Services.appinfo.OS;
|
|
prettifyCSS.LINE_SEPARATOR = (os === "WINNT" ? "\r\n" : "\n");
|
|
}
|
|
|
|
// Stylesheets may start and end with HTML comment tags (possibly with whitespaces
|
|
// before and after). Remove those first. Don't do anything there aren't any.
|
|
const trimmed = text.trim();
|
|
if (trimmed.startsWith("<!--")) {
|
|
text = trimmed.replace(/^<!--/, "").replace(/-->$/, "").trim();
|
|
}
|
|
|
|
const originalText = text;
|
|
text = text.trim();
|
|
|
|
// don't attempt to prettify if there's more than one line per rule, excluding comments.
|
|
const lineCount = text.split("\n").length - 1 - getLineCountInComments(text);
|
|
if (ruleCount !== null && lineCount >= ruleCount) {
|
|
return { result: originalText, mappings: [] };
|
|
}
|
|
|
|
// We reformat the text using a simple state machine. The
|
|
// reformatting preserves most of the input text, changing only
|
|
// whitespace. The rules are:
|
|
//
|
|
// * After a "{" or ";" symbol, ensure there is a newline and
|
|
// indentation before the next non-comment, non-whitespace token.
|
|
// * Additionally after a "{" symbol, increase the indentation.
|
|
// * A "}" symbol ensures there is a preceding newline, and
|
|
// decreases the indentation level.
|
|
// * Ensure there is whitespace before a "{".
|
|
//
|
|
// This approach can be confused sometimes, but should do ok on a
|
|
// minified file.
|
|
let indent = "";
|
|
let indentLevel = 0;
|
|
const tokens = getCSSLexer(text);
|
|
// List of mappings of token positions from original source to prettified source.
|
|
const mappings = [];
|
|
// Line and column offsets used to shift the token positions after prettyfication.
|
|
let lineOffset = 0;
|
|
let columnOffset = 0;
|
|
let indentOffset = 0;
|
|
let result = "";
|
|
let pushbackToken = undefined;
|
|
|
|
// A helper function that reads tokens, looking for the next
|
|
// non-comment, non-whitespace token. Comment and whitespace tokens
|
|
// are appended to |result|. If this encounters EOF, it returns
|
|
// null. Otherwise it returns the last whitespace token that was
|
|
// seen. This function also updates |pushbackToken|.
|
|
const readUntilSignificantToken = () => {
|
|
while (true) {
|
|
const token = tokens.nextToken();
|
|
if (!token || token.tokenType !== "whitespace") {
|
|
pushbackToken = token;
|
|
return token;
|
|
}
|
|
// Saw whitespace. Before committing to it, check the next
|
|
// token.
|
|
const nextToken = tokens.nextToken();
|
|
if (!nextToken || nextToken.tokenType !== "comment") {
|
|
pushbackToken = nextToken;
|
|
return token;
|
|
}
|
|
// Saw whitespace + comment. Update the result and continue.
|
|
result = result + text.substring(token.startOffset, nextToken.endOffset);
|
|
}
|
|
};
|
|
|
|
// State variables for readUntilNewlineNeeded.
|
|
//
|
|
// Starting index of the accumulated tokens.
|
|
let startIndex;
|
|
// Ending index of the accumulated tokens.
|
|
let endIndex;
|
|
// True if any non-whitespace token was seen.
|
|
let anyNonWS;
|
|
// True if the terminating token is "}".
|
|
let isCloseBrace;
|
|
// True if the token just before the terminating token was
|
|
// whitespace.
|
|
let lastWasWS;
|
|
// True if the current token is inside a CSS selector.
|
|
let isInSelector = true;
|
|
// True if the current token is inside an at-rule definition.
|
|
let isInAtRuleDefinition = false;
|
|
|
|
// A helper function that reads tokens until there is a reason to
|
|
// insert a newline. This updates the state variables as needed.
|
|
// If this encounters EOF, it returns null. Otherwise it returns
|
|
// the final token read. Note that if the returned token is "{",
|
|
// then it will not be included in the computed start/end token
|
|
// range. This is used to handle whitespace insertion before a "{".
|
|
const readUntilNewlineNeeded = () => {
|
|
let token;
|
|
while (true) {
|
|
if (pushbackToken) {
|
|
token = pushbackToken;
|
|
pushbackToken = undefined;
|
|
} else {
|
|
token = tokens.nextToken();
|
|
}
|
|
if (!token) {
|
|
endIndex = text.length;
|
|
break;
|
|
}
|
|
|
|
const line = tokens.lineNumber;
|
|
const column = tokens.columnNumber;
|
|
mappings.push({
|
|
original: {
|
|
line,
|
|
column,
|
|
},
|
|
generated: {
|
|
line: lineOffset + line,
|
|
column: columnOffset,
|
|
},
|
|
});
|
|
// Shift the column offset for the next token by the current token's length.
|
|
columnOffset += token.endOffset - token.startOffset;
|
|
|
|
if (token.tokenType === "at") {
|
|
isInAtRuleDefinition = true;
|
|
}
|
|
|
|
// A "}" symbol must be inserted later, to deal with indentation
|
|
// and newline.
|
|
if (token.tokenType === "symbol" && token.text === "}") {
|
|
isInSelector = true;
|
|
isCloseBrace = true;
|
|
break;
|
|
} else if (token.tokenType === "symbol" && token.text === "{") {
|
|
if (isInAtRuleDefinition) {
|
|
isInAtRuleDefinition = false;
|
|
} else {
|
|
isInSelector = false;
|
|
}
|
|
break;
|
|
}
|
|
|
|
if (token.tokenType !== "whitespace") {
|
|
anyNonWS = true;
|
|
}
|
|
|
|
if (startIndex === undefined) {
|
|
startIndex = token.startOffset;
|
|
}
|
|
endIndex = token.endOffset;
|
|
|
|
if (token.tokenType === "symbol" && token.text === ";") {
|
|
break;
|
|
}
|
|
|
|
if (token.tokenType === "symbol" && token.text === "," &&
|
|
isInSelector && !isInAtRuleDefinition) {
|
|
break;
|
|
}
|
|
|
|
lastWasWS = token.tokenType === "whitespace";
|
|
}
|
|
return token;
|
|
};
|
|
|
|
while (true) {
|
|
// Set the initial state.
|
|
startIndex = undefined;
|
|
endIndex = undefined;
|
|
anyNonWS = false;
|
|
isCloseBrace = false;
|
|
lastWasWS = false;
|
|
|
|
// Read tokens until we see a reason to insert a newline.
|
|
let token = readUntilNewlineNeeded();
|
|
|
|
// Append any saved up text to the result, applying indentation.
|
|
if (startIndex !== undefined) {
|
|
if (isCloseBrace && !anyNonWS) {
|
|
// If we saw only whitespace followed by a "}", then we don't
|
|
// need anything here.
|
|
} else {
|
|
result = result + indent + text.substring(startIndex, endIndex);
|
|
if (isCloseBrace) {
|
|
result += prettifyCSS.LINE_SEPARATOR;
|
|
lineOffset = lineOffset + 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
// Get preference of the user regarding what to use for indentation,
|
|
// spaces or tabs.
|
|
const tabPrefs = getTabPrefs();
|
|
|
|
if (isCloseBrace) {
|
|
// Even if the stylesheet contains extra closing braces, the indent level should
|
|
// remain > 0.
|
|
indentLevel = Math.max(0, indentLevel - 1);
|
|
|
|
if (tabPrefs.indentWithTabs) {
|
|
indent = TAB_CHARS.repeat(indentLevel);
|
|
indentOffset = 4 * indentLevel;
|
|
} else {
|
|
indent = SPACE_CHARS.repeat(indentLevel);
|
|
indentOffset = 1 * indentLevel;
|
|
}
|
|
result = result + indent + "}";
|
|
}
|
|
|
|
if (!token) {
|
|
break;
|
|
}
|
|
|
|
if (token.tokenType === "symbol" && token.text === "{") {
|
|
if (!lastWasWS) {
|
|
result += " ";
|
|
columnOffset++;
|
|
}
|
|
result += "{";
|
|
if (tabPrefs.indentWithTabs) {
|
|
indent = TAB_CHARS.repeat(++indentLevel);
|
|
indentOffset = 4 * indentLevel;
|
|
} else {
|
|
indent = SPACE_CHARS.repeat(++indentLevel);
|
|
indentOffset = 1 * indentLevel;
|
|
}
|
|
}
|
|
|
|
// Now it is time to insert a newline. However first we want to
|
|
// deal with any trailing comments.
|
|
token = readUntilSignificantToken();
|
|
|
|
// "Early" bail-out if the text does not appear to be minified.
|
|
// Here we ignore the case where whitespace appears at the end of
|
|
// the text.
|
|
if (pushbackToken && token && token.tokenType === "whitespace" &&
|
|
/\n/g.test(text.substring(token.startOffset, token.endOffset))) {
|
|
return { result: originalText, mappings: [] };
|
|
}
|
|
|
|
// Finally time for that newline.
|
|
result = result + prettifyCSS.LINE_SEPARATOR;
|
|
|
|
// Update line and column offsets for the new line.
|
|
lineOffset = lineOffset + 1;
|
|
columnOffset = 0 + indentOffset;
|
|
|
|
// Maybe we hit EOF.
|
|
if (!pushbackToken) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
return { result, mappings };
|
|
}
|
|
/* eslint-enable complexity */
|
|
|
|
exports.prettifyCSS = prettifyCSS;
|
|
|
|
/**
|
|
* Find a unique CSS selector for a given element
|
|
* @returns a string such that ele.ownerDocument.querySelector(reply) === ele
|
|
* and ele.ownerDocument.querySelectorAll(reply).length === 1
|
|
*/
|
|
exports.findCssSelector = findCssSelector;
|
|
|
|
/**
|
|
* Get the full CSS path for a given element.
|
|
* @returns a string that can be used as a CSS selector for the element. It might not
|
|
* match the element uniquely. It does however, represent the full path from the root
|
|
* node to the element.
|
|
*/
|
|
exports.getCssPath = getCssPath;
|
|
|
|
/**
|
|
* Get the xpath for a given element.
|
|
* @param {DomNode} ele
|
|
* @returns a string that can be used as an XPath to find the element uniquely.
|
|
*/
|
|
exports.getXPath = getXPath;
|
|
|
|
/**
|
|
* Given a node, check to see if it is a ::marker, ::before, or ::after element.
|
|
* If so, return the node that is accessible from within the document
|
|
* (the parent of the anonymous node), along with which pseudo element
|
|
* it was. Otherwise, return the node itself.
|
|
*
|
|
* @returns {Object}
|
|
* - {DOMNode} node The non-anonymous node
|
|
* - {string} pseudo One of ':marker', ':before', ':after', or null.
|
|
*/
|
|
function getBindingElementAndPseudo(node) {
|
|
let bindingElement = node;
|
|
let pseudo = null;
|
|
if (node.nodeName == "_moz_generated_content_marker") {
|
|
bindingElement = node.parentNode;
|
|
pseudo = ":marker";
|
|
} else if (node.nodeName == "_moz_generated_content_before") {
|
|
bindingElement = node.parentNode;
|
|
pseudo = ":before";
|
|
} else if (node.nodeName == "_moz_generated_content_after") {
|
|
bindingElement = node.parentNode;
|
|
pseudo = ":after";
|
|
}
|
|
return {
|
|
bindingElement: bindingElement,
|
|
pseudo: pseudo,
|
|
};
|
|
}
|
|
exports.getBindingElementAndPseudo = getBindingElementAndPseudo;
|
|
|
|
/**
|
|
* Returns css style rules for a given a node.
|
|
* This function can handle ::before or ::after pseudo element as well as
|
|
* normal element.
|
|
*/
|
|
function getCSSStyleRules(node) {
|
|
const { bindingElement, pseudo } = getBindingElementAndPseudo(node);
|
|
const rules = InspectorUtils.getCSSStyleRules(bindingElement, pseudo);
|
|
return rules;
|
|
}
|
|
exports.getCSSStyleRules = getCSSStyleRules;
|