1f705facf2
This patch replaces the handwritten MallocSizeOf implementation for PropertyDeclaration with a derived one, which gives much more thorough measurement. This requires (a) deriving MallocSizeOf for a *lot* of additional types (most of which already have `derive(HeapSizeOf)` in Servo builds), and (b) implementing MallocSizeOf for a few more types in the `malloc_size_of` crate. These changes would significantly improve the reporting coverage for gmail if it weren't for the fact that SpecifiedUrl isn't measured due to a lack of clarity about its fields; that can be fixed as a follow-up once bug 1397971 has landed. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because testing is on the Gecko side. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 097cea240fe9b1d96fa4ef5ffa984f09e0bd04f3
35 lines
1.0 KiB
Rust
35 lines
1.0 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Generic types for legacy Gecko-only properties that should probably be
|
|
//! unshipped at some point in the future.
|
|
|
|
/// A generic value for scroll snap points.
|
|
#[cfg_attr(feature = "gecko", derive(MallocSizeOf))]
|
|
#[derive(Clone, Copy, Debug, PartialEq, ToComputedValue, ToCss)]
|
|
pub enum ScrollSnapPoint<LengthOrPercentage> {
|
|
/// `none`
|
|
None,
|
|
/// `repeat(<length-or-percentage>)`
|
|
#[css(function)]
|
|
Repeat(LengthOrPercentage)
|
|
}
|
|
|
|
impl<L> ScrollSnapPoint<L> {
|
|
/// Returns `none`.
|
|
#[inline]
|
|
pub fn none() -> Self {
|
|
ScrollSnapPoint::None
|
|
}
|
|
|
|
/// Returns the repeat argument, if any.
|
|
#[inline]
|
|
pub fn repeated(&self) -> Option<&L> {
|
|
match *self {
|
|
ScrollSnapPoint::None => None,
|
|
ScrollSnapPoint::Repeat(ref length) => Some(length),
|
|
}
|
|
}
|
|
}
|