Files
tubestation/layout/style/CSSKeyframeRule.cpp
Olli Pettay 2e64f41c9f Bug 1428246 - The attributeChangedCallback is fired twice for the *first* style attribute change, r=peterv
The idea with this patch is that style code will first call
InlineStyleDeclarationWillChange before style declaration has changed, and SetInlineStyleDeclaration once it has changed.

In order to be able to report old attribute value, InlineStyleDeclarationWillChange reads the value and also calls AttributeWillChange (so that DOMMutationObserser can grab the old value). Later SetInlineStyleDeclaration passes the old value to
SetAttrAndNotify so that mutation events and attributeChanged callbacks are handled correctly.

Because of performance, declaration can't be cloned for reading the old value. And that is why the recently-added callback is used to detect when declaration is about to change (bug 1466963 and followup bug 1468665).

To keep the expected existing behavior, even if declaration isn't changed, but just a new declaration was created (since there wasn't any), we need to still run all these
willchange/set calls. That is when the code has 'if (created)' checks.

Since there are several declaration implementation and only nsDOMCSSAttributeDeclaration needs the about-to-change callback, GetPropertyChangeClosure is the one to initialize the callback closure, and the struct which is then passes as data to the closure.

Apparently we lost mutation event testing on style attribute when the pref was added, so test_style_attr_listener.html is modified to test both pref values.
2018-06-26 12:54:00 +03:00

215 lines
5.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "mozilla/dom/CSSKeyframeRule.h"
#include "mozilla/DeclarationBlock.h"
#include "mozilla/dom/CSSKeyframeRuleBinding.h"
#include "nsDOMCSSDeclaration.h"
namespace mozilla {
namespace dom {
// -------------------------------------------
// CSSKeyframeDeclaration
//
class CSSKeyframeDeclaration : public nsDOMCSSDeclaration
{
public:
explicit CSSKeyframeDeclaration(CSSKeyframeRule* aRule)
: mRule(aRule)
{
mDecls = new DeclarationBlock(
Servo_Keyframe_GetStyle(aRule->Raw()).Consume());
}
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_AMBIGUOUS(
CSSKeyframeDeclaration, nsICSSDeclaration)
css::Rule* GetParentRule() final { return mRule; }
void DropReference() {
mRule = nullptr;
mDecls->SetOwningRule(nullptr);
}
DeclarationBlock* GetOrCreateCSSDeclaration(
Operation aOperation, DeclarationBlock** aCreated) final
{
return mDecls;
}
nsresult SetCSSDeclaration(DeclarationBlock* aDecls,
MutationClosureData* aClosureData) final
{
if (!mRule) {
return NS_OK;
}
mRule->UpdateRule([this, aDecls]() {
if (mDecls != aDecls) {
mDecls->SetOwningRule(nullptr);
mDecls = aDecls;
mDecls->SetOwningRule(mRule);
Servo_Keyframe_SetStyle(mRule->Raw(), mDecls->Raw());
}
});
return NS_OK;
}
ParsingEnvironment GetParsingEnvironment(
nsIPrincipal* aSubjectPrincipal) const final
{
return GetParsingEnvironmentForRule(mRule);
}
nsIDocument* DocToUpdate() final { return nullptr; }
nsINode* GetParentObject() final
{
return mRule ? mRule->GetParentObject() : nullptr;
}
size_t SizeOfIncludingThis(MallocSizeOf aMallocSizeOf) const
{
size_t n = aMallocSizeOf(this);
// TODO we may want to add size of mDecls as well
return n;
}
private:
virtual ~CSSKeyframeDeclaration() {
MOZ_ASSERT(!mRule, "Backpointer should have been cleared");
}
CSSKeyframeRule* mRule;
RefPtr<DeclarationBlock> mDecls;
};
NS_IMPL_CYCLE_COLLECTING_ADDREF(CSSKeyframeDeclaration)
NS_IMPL_CYCLE_COLLECTING_RELEASE(CSSKeyframeDeclaration)
NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_0(CSSKeyframeDeclaration)
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(CSSKeyframeDeclaration)
NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
NS_INTERFACE_MAP_END_INHERITING(nsDOMCSSDeclaration)
// -------------------------------------------
// CSSKeyframeRule
//
CSSKeyframeRule::CSSKeyframeRule(already_AddRefed<RawServoKeyframe> aRaw,
uint32_t aLine, uint32_t aColumn)
: css::Rule(aLine, aColumn)
, mRaw(aRaw) {}
CSSKeyframeRule::~CSSKeyframeRule()
{
if (mDeclaration) {
mDeclaration->DropReference();
}
}
NS_IMPL_ADDREF_INHERITED(CSSKeyframeRule, css::Rule)
NS_IMPL_RELEASE_INHERITED(CSSKeyframeRule, css::Rule)
// QueryInterface implementation for nsCSSKeyframeRule
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(CSSKeyframeRule)
NS_INTERFACE_MAP_END_INHERITING(css::Rule)
NS_IMPL_CYCLE_COLLECTION_CLASS(CSSKeyframeRule)
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(CSSKeyframeRule,
css::Rule)
if (tmp->mDeclaration) {
tmp->mDeclaration->DropReference();
tmp->mDeclaration = nullptr;
}
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(CSSKeyframeRule,
css::Rule)
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mDeclaration)
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
bool
CSSKeyframeRule::IsCCLeaf() const
{
return Rule::IsCCLeaf() && !mDeclaration;
}
#ifdef DEBUG
/* virtual */ void
CSSKeyframeRule::List(FILE* out, int32_t aIndent) const
{
nsAutoCString str;
for (int32_t i = 0; i < aIndent; i++) {
str.AppendLiteral(" ");
}
Servo_Keyframe_Debug(mRaw, &str);
fprintf_stderr(out, "%s\n", str.get());
}
#endif
template<typename Func>
void
CSSKeyframeRule::UpdateRule(Func aCallback)
{
aCallback();
if (StyleSheet* sheet = GetStyleSheet()) {
sheet->RuleChanged(this);
}
}
void
CSSKeyframeRule::GetKeyText(nsAString& aKeyText)
{
Servo_Keyframe_GetKeyText(mRaw, &aKeyText);
}
void
CSSKeyframeRule::SetKeyText(const nsAString& aKeyText)
{
NS_ConvertUTF16toUTF8 keyText(aKeyText);
UpdateRule([this, &keyText]() {
Servo_Keyframe_SetKeyText(mRaw, &keyText);
});
}
void
CSSKeyframeRule::GetCssText(nsAString& aCssText) const
{
Servo_Keyframe_GetCssText(mRaw, &aCssText);
}
nsICSSDeclaration*
CSSKeyframeRule::Style()
{
if (!mDeclaration) {
mDeclaration = new CSSKeyframeDeclaration(this);
}
return mDeclaration;
}
size_t
CSSKeyframeRule::SizeOfIncludingThis(MallocSizeOf aMallocSizeOf) const
{
size_t n = aMallocSizeOf(this);
if (mDeclaration) {
n += mDeclaration->SizeOfIncludingThis(aMallocSizeOf);
}
return n;
}
/* virtual */ JSObject*
CSSKeyframeRule::WrapObject(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto)
{
return CSSKeyframeRuleBinding::Wrap(aCx, this, aGivenProto);
}
} // namespace dom
} // namespace mozilla