There's no sufficiently robust way to identify POD types in C++, such that we could rely on this kind of thing for serialization. As one example, `bool` must be carefully handled on deserialize, in case an attacker wants to exploit the UB of bool with value 2. Additionally, generally it's not viable to tell whether all the members of a struct are PODs as well, and we need that level of assurance recursively! So we instead lean on e.g. ParamTraits_TiedFields/_IsEnumCase for our extreme robustness requirements. Differential Revision: https://phabricator.services.mozilla.com/D217518
208 lines
7.4 KiB
C++
208 lines
7.4 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef __IPC_GLUE_IPCMESSAGEUTILS_H__
|
|
#define __IPC_GLUE_IPCMESSAGEUTILS_H__
|
|
|
|
#include <cstdint>
|
|
#include <string>
|
|
#include <type_traits>
|
|
#include "chrome/common/ipc_message.h"
|
|
#include "chrome/common/ipc_message_utils.h"
|
|
#include "mozilla/ipc/IPCCore.h"
|
|
#include "mozilla/MacroForEach.h"
|
|
|
|
class PickleIterator;
|
|
|
|
// XXX Things that are not necessary if moving implementations to the cpp file
|
|
#include "base/string_util.h"
|
|
|
|
#ifdef _MSC_VER
|
|
# pragma warning(disable : 4800)
|
|
#endif
|
|
|
|
#if !defined(XP_UNIX)
|
|
// This condition must be kept in sync with the one in
|
|
// ipc_message_utils.h, but this dummy definition of
|
|
// base::FileDescriptor acts as a static assert that we only get one
|
|
// def or the other (or neither, in which case code using
|
|
// FileDescriptor fails to build)
|
|
namespace base {
|
|
struct FileDescriptor {};
|
|
} // namespace base
|
|
#endif
|
|
|
|
namespace mozilla {
|
|
template <typename...>
|
|
class Variant;
|
|
|
|
namespace detail {
|
|
template <typename...>
|
|
struct VariantTag;
|
|
}
|
|
} // namespace mozilla
|
|
|
|
namespace IPC {
|
|
|
|
/**
|
|
* A helper class for serializing empty structs. Since the struct is empty there
|
|
* is nothing to write, and a priori we know the result of the read.
|
|
*/
|
|
template <typename T>
|
|
struct EmptyStructSerializer {
|
|
typedef T paramType;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
*aResult = {};
|
|
return true;
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<int8_t> {
|
|
typedef int8_t paramType;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
aWriter->WriteBytes(&aParam, sizeof(aParam));
|
|
}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
return aReader->ReadBytesInto(aResult, sizeof(*aResult));
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<uint8_t> {
|
|
typedef uint8_t paramType;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
aWriter->WriteBytes(&aParam, sizeof(aParam));
|
|
}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
return aReader->ReadBytesInto(aResult, sizeof(*aResult));
|
|
}
|
|
};
|
|
|
|
#if !defined(XP_UNIX)
|
|
// See above re: keeping definitions in sync
|
|
template <>
|
|
struct ParamTraits<base::FileDescriptor> {
|
|
typedef base::FileDescriptor paramType;
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
MOZ_CRASH("FileDescriptor isn't meaningful on this platform");
|
|
}
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
MOZ_CRASH("FileDescriptor isn't meaningful on this platform");
|
|
return false;
|
|
}
|
|
};
|
|
#endif // !defined(XP_UNIX)
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::void_t> {
|
|
typedef mozilla::void_t paramType;
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {}
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
*aResult = paramType();
|
|
return true;
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::null_t> {
|
|
typedef mozilla::null_t paramType;
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {}
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
*aResult = paramType();
|
|
return true;
|
|
}
|
|
};
|
|
|
|
// Helper class for reading bitfields.
|
|
// If T has bitfields members, derive ParamTraits<T> from BitfieldHelper<T>.
|
|
template <typename ParamType>
|
|
struct BitfieldHelper {
|
|
// We need this helper because we can't get the address of a bitfield to
|
|
// pass directly to ReadParam. So instead we read it into a temporary bool
|
|
// and set the bitfield using a setter function
|
|
static bool ReadBoolForBitfield(MessageReader* aReader, ParamType* aResult,
|
|
void (ParamType::*aSetter)(bool)) {
|
|
bool value;
|
|
if (ReadParam(aReader, &value)) {
|
|
(aResult->*aSetter)(value);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
};
|
|
|
|
// A couple of recursive helper functions, allows syntax like:
|
|
// WriteParams(aMsg, aParam.foo, aParam.bar, aParam.baz)
|
|
// ReadParams(aMsg, aIter, aParam.foo, aParam.bar, aParam.baz)
|
|
|
|
template <typename... Ts>
|
|
static void WriteParams(MessageWriter* aWriter, const Ts&... aArgs) {
|
|
(WriteParam(aWriter, aArgs), ...);
|
|
}
|
|
|
|
template <typename... Ts>
|
|
static bool ReadParams(MessageReader* aReader, Ts&... aArgs) {
|
|
return (ReadParam(aReader, &aArgs) && ...);
|
|
}
|
|
|
|
// Macros that allow syntax like:
|
|
// DEFINE_IPC_SERIALIZER_WITH_FIELDS(SomeType, member1, member2, member3)
|
|
// Makes sure that serialize/deserialize code do the same members in the same
|
|
// order.
|
|
#define ACCESS_PARAM_FIELD(Field) aParam.Field
|
|
|
|
#define DEFINE_IPC_SERIALIZER_WITH_FIELDS(Type, ...) \
|
|
template <> \
|
|
struct ParamTraits<Type> { \
|
|
typedef Type paramType; \
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) { \
|
|
WriteParams(aWriter, MOZ_FOR_EACH_SEPARATED(ACCESS_PARAM_FIELD, (, ), \
|
|
(), (__VA_ARGS__))); \
|
|
} \
|
|
\
|
|
static bool Read(MessageReader* aReader, paramType* aResult) { \
|
|
paramType& aParam = *aResult; \
|
|
return ReadParams(aReader, \
|
|
MOZ_FOR_EACH_SEPARATED(ACCESS_PARAM_FIELD, (, ), (), \
|
|
(__VA_ARGS__))); \
|
|
} \
|
|
};
|
|
|
|
#define DEFINE_IPC_SERIALIZER_WITHOUT_FIELDS(Type) \
|
|
template <> \
|
|
struct ParamTraits<Type> : public EmptyStructSerializer<Type> {};
|
|
|
|
} /* namespace IPC */
|
|
|
|
#define DEFINE_IPC_SERIALIZER_WITH_SUPER_CLASS_AND_FIELDS(Type, Super, ...) \
|
|
template <> \
|
|
struct ParamTraits<Type> { \
|
|
typedef Type paramType; \
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) { \
|
|
WriteParam(aWriter, static_cast<const Super&>(aParam)); \
|
|
WriteParams(aWriter, MOZ_FOR_EACH_SEPARATED(ACCESS_PARAM_FIELD, (, ), \
|
|
(), (__VA_ARGS__))); \
|
|
} \
|
|
\
|
|
static bool Read(MessageReader* aReader, paramType* aResult) { \
|
|
paramType& aParam = *aResult; \
|
|
return ReadParam(aReader, static_cast<Super*>(aResult)) && \
|
|
ReadParams(aReader, \
|
|
MOZ_FOR_EACH_SEPARATED(ACCESS_PARAM_FIELD, (, ), (), \
|
|
(__VA_ARGS__))); \
|
|
} \
|
|
};
|
|
|
|
#endif /* __IPC_GLUE_IPCMESSAGEUTILS_H__ */
|