> Here it is. > > ~~There's two major things that are unfinished here:~~ > - ~~Dealing with the unroot_must_root lint. I'm not sure about the value of this lint with the new rooting API.~~ Done. > - ~~Updating the Cargo.locks to point to the new SM and SM binding.~~ Done. > > I also included my fixes for the rust update, but these will disappear in a rebase. A rust update is necessary to support calling `Drop` on `Heap<T>` correctly when `Heap<T>` is inside a `Rc<T>`. Otherwise `&self` points to the wrong location. > > Incremental GC is disabled here. I'm not sure how to deal with the incremental barriers so that's left for later. > > Generational GC works. SM doesn't work without it. > > The biggest change here is to the rooting API. `Root` was made movable, and `Temporary` and `JSRef` was removed. Movable `Root`s means there's no need for `Temporary`, and `JSRef`s aren't needed generally since it can be assumed that being able to obtain a reference to a dom object means it's already rooted. References have their lifetime bound to the Roots that provided them. DOM objects that haven't passed through `reflect_dom_object` don't need to be rooted, and DOM objects that have passed through `reflect_dom_object` can't be obtained without being rooted through `native_from_reflector_jsmanaged` or `JS::<T>::root()`. > > Support for `Heap<T>` ended up messier than I expected. It's split into two commits, but only because it's a bit difficult to fold them together. Supporting `Heap<T>` properly requires that that `Heap::<T>::set()` be called on something that won't move. I removed the Copy and Clone trait from `Heap<T>` so `Cell` can't hold `Heap<T>` - only `UnsafeCell` can hold it. > > `CallbackObject` is a bit tricky - I moved all callbacks into `Rc<T>` in order to make sure that the pointer inside to a `*mut JSObject` doesn't move. This is necessary for supporting `Heap<T>`. > > `RootedCollectionSet` is very general purpose now. Anything with `JSTraceable` can be rooted by `RootedCollectionSet`/`RootedTraceable`. Right now, `RootedTraceable` is only used to hold down dom objects before they're fully attached to their reflector. I had to make a custom mechanism to dispatch the trace call - couldn't figure out how to get trait objects working for this case. > > This has been tested with the following zeal settings: > > GC after every allocation > JS_GC_ZEAL=2,1 > > GC after every 100 allocations (important for catching use-after-free bugs) > JS_GC_ZEAL=2,100 > > Verify pre barriers > JS_GC_ZEAL=4,1 > > Verify post barriers > JS_GC_ZEAL=11,1 Source-Repo: https://github.com/servo/servo Source-Revision: e7808c526c348fea5e3b48af70b7f1a066652097
136 lines
4.4 KiB
Rust
136 lines
4.4 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use dom::bindings::callback::ExceptionHandling::Report;
|
|
use dom::bindings::codegen::Bindings::EventBinding::EventMethods;
|
|
use dom::bindings::codegen::InheritTypes::{EventTargetCast, NodeCast};
|
|
use dom::bindings::js::JS;
|
|
use dom::bindings::trace::RootedVec;
|
|
use dom::eventtarget::{EventTarget, ListenerPhase};
|
|
use dom::event::{Event, EventPhase};
|
|
use dom::node::{Node, NodeHelpers};
|
|
use dom::virtualmethods::vtable_for;
|
|
|
|
// See https://dom.spec.whatwg.org/#concept-event-dispatch for the full dispatch algorithm
|
|
pub fn dispatch_event<'a, 'b>(target: &'a EventTarget,
|
|
pseudo_target: Option<&'b EventTarget>,
|
|
event: &Event) -> bool {
|
|
assert!(!event.dispatching());
|
|
assert!(event.initialized());
|
|
|
|
event.set_target(match pseudo_target {
|
|
Some(pseudo_target) => pseudo_target,
|
|
None => target.clone(),
|
|
});
|
|
event.set_dispatching(true);
|
|
|
|
let type_ = event.Type();
|
|
|
|
//TODO: no chain if not participating in a tree
|
|
let mut chain: RootedVec<JS<EventTarget>> = RootedVec::new();
|
|
if let Some(target_node) = NodeCast::to_ref(target) {
|
|
for ancestor in target_node.ancestors() {
|
|
let ancestor_target = EventTargetCast::from_ref(ancestor.r());
|
|
chain.push(JS::from_ref(ancestor_target))
|
|
}
|
|
}
|
|
|
|
event.set_phase(EventPhase::Capturing);
|
|
|
|
//FIXME: The "callback this value" should be currentTarget
|
|
|
|
/* capturing */
|
|
for cur_target in chain.iter().rev() {
|
|
let cur_target = cur_target.root();
|
|
let stopped = match cur_target.r().get_listeners_for(&type_, ListenerPhase::Capturing) {
|
|
Some(listeners) => {
|
|
event.set_current_target(cur_target.r());
|
|
for listener in listeners.iter() {
|
|
// Explicitly drop any exception on the floor.
|
|
let _ = listener.HandleEvent_(cur_target.r(), event, Report);
|
|
|
|
if event.stop_immediate() {
|
|
break;
|
|
}
|
|
}
|
|
|
|
event.stop_propagation()
|
|
}
|
|
None => false
|
|
};
|
|
|
|
if stopped {
|
|
break;
|
|
}
|
|
}
|
|
|
|
/* at target */
|
|
if !event.stop_propagation() {
|
|
event.set_phase(EventPhase::AtTarget);
|
|
event.set_current_target(target.clone());
|
|
|
|
let opt_listeners = target.get_listeners(&type_);
|
|
for listeners in opt_listeners.iter() {
|
|
for listener in listeners.iter() {
|
|
// Explicitly drop any exception on the floor.
|
|
let _ = listener.HandleEvent_(target, event, Report);
|
|
|
|
if event.stop_immediate() {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/* bubbling */
|
|
if event.bubbles() && !event.stop_propagation() {
|
|
event.set_phase(EventPhase::Bubbling);
|
|
|
|
for cur_target in chain.iter() {
|
|
let cur_target = cur_target.root();
|
|
let stopped = match cur_target.r().get_listeners_for(&type_, ListenerPhase::Bubbling) {
|
|
Some(listeners) => {
|
|
event.set_current_target(cur_target.r());
|
|
for listener in listeners.iter() {
|
|
// Explicitly drop any exception on the floor.
|
|
let _ = listener.HandleEvent_(cur_target.r(), event, Report);
|
|
|
|
if event.stop_immediate() {
|
|
break;
|
|
}
|
|
}
|
|
|
|
event.stop_propagation()
|
|
}
|
|
None => false
|
|
};
|
|
if stopped {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* default action */
|
|
let target = event.GetTarget();
|
|
match target {
|
|
Some(ref target) => {
|
|
let node: Option<&Node> = NodeCast::to_ref(target.r());
|
|
match node {
|
|
Some(node) => {
|
|
let vtable = vtable_for(&node);
|
|
vtable.handle_event(event);
|
|
}
|
|
None => {}
|
|
}
|
|
}
|
|
None => {}
|
|
}
|
|
|
|
event.set_dispatching(false);
|
|
event.set_phase(EventPhase::None);
|
|
event.clear_current_target();
|
|
|
|
!event.DefaultPrevented()
|
|
}
|