- removes duplication of logic to create each panel. - removes needless exposing of panel instances as properties on `inspector`: - `inspector.layoutview` - `inspector.fontinspector` - `inspector.animationinspector` - `inspector.changesview` - updates tests to not rely on those exposed properties and instead call `inspector.getPanel(toolId)` (previously created panels are stored and a reference is returned). - consolidates panel `destroy()` so we don't have to remember to destroy them individually. MozReview-Commit-ID: GVkP6z7FxKt Differential Revision: https://phabricator.services.mozilla.com/D10053
91 lines
2.7 KiB
JavaScript
91 lines
2.7 KiB
JavaScript
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
|
/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
const { createFactory, createElement } = require("devtools/client/shared/vendor/react");
|
|
const { Provider } = require("devtools/client/shared/vendor/react-redux");
|
|
|
|
const ChangesApp = createFactory(require("./components/ChangesApp"));
|
|
|
|
const {
|
|
resetChanges,
|
|
trackChange,
|
|
} = require("./actions/changes");
|
|
|
|
class ChangesView {
|
|
constructor(inspector, window) {
|
|
this.document = window.document;
|
|
this.inspector = inspector;
|
|
this.store = this.inspector.store;
|
|
this.toolbox = this.inspector.toolbox;
|
|
|
|
this.onAddChange = this.onAddChange.bind(this);
|
|
this.onClearChanges = this.onClearChanges.bind(this);
|
|
this.destroy = this.destroy.bind(this);
|
|
|
|
// Get the Changes front, and listen to it.
|
|
this.changesFront = this.toolbox.target.getFront("changes");
|
|
this.changesFront.on("add-change", this.onAddChange);
|
|
this.changesFront.on("clear-changes", this.onClearChanges);
|
|
|
|
this.init();
|
|
}
|
|
|
|
init() {
|
|
const changesApp = ChangesApp({});
|
|
|
|
// Expose the provider to let inspector.js use it in setupSidebar.
|
|
this.provider = createElement(Provider, {
|
|
id: "changesview",
|
|
key: "changesview",
|
|
store: this.store,
|
|
}, changesApp);
|
|
|
|
this.inspector.target.on("will-navigate", this.onClearChanges);
|
|
|
|
// Get all changes collected up to this point by the ChangesActor on the server,
|
|
// then push them to the Redux store here on the client.
|
|
this.changesFront.allChanges()
|
|
.then(changes => {
|
|
changes.forEach(change => {
|
|
this.onAddChange(change);
|
|
});
|
|
})
|
|
.catch(err => {
|
|
// The connection to the server may have been cut, for example during test
|
|
// teardown. Here we just catch the error and silently ignore it.
|
|
});
|
|
}
|
|
|
|
onAddChange(change) {
|
|
// Turn data into a suitable change to send to the store.
|
|
this.store.dispatch(trackChange(change));
|
|
}
|
|
|
|
onClearChanges() {
|
|
this.store.dispatch(resetChanges());
|
|
}
|
|
|
|
/**
|
|
* Destruction function called when the inspector is destroyed.
|
|
*/
|
|
destroy() {
|
|
this.store.dispatch(resetChanges());
|
|
|
|
this.changesFront.off("add-change", this.onAddChange);
|
|
this.changesFront.off("clear-changes", this.onClearChanges);
|
|
this.changesFront = null;
|
|
|
|
this.document = null;
|
|
this.inspector = null;
|
|
this.store = null;
|
|
this.toolbox = null;
|
|
}
|
|
}
|
|
|
|
module.exports = ChangesView;
|