Currently, there are a few linting functions that only run on certain filetypes (determined by the file extension). Prior to this commit, the special cases were handled in a parent function with a conditional. This commit changes the system so each linting function gets passed a filename so the function can determine whether it should run or not based on the file extension. I also refactored flake8 linting slightly. From what I've read so far of the code, flake8 itself will only print the results directly to stdout (though the linter would report the quantity of errors detected). Prior to this commit, we would let flake8 print directly to stdout and just determine if there were >0 errors reported. This commit (sort of hackily) temporarily captures stdout when we call flake8 so we can do what we want with the output, allowing us to `yield` the line number and message like we do with the other linting functions. In my opinion, both of these changes isolate specific behaviors/checks into their respective linting functions instead of having them handled at a more global level. In addition to the changes above: * The whitespace linter now runs on WebIDL and TOML files * The license header linter now runs on WebIDL files Source-Repo: https://github.com/servo/servo Source-Revision: 7c8922c0c39616559b580b4a363ebe2a8c6b3ba8
52 lines
1.9 KiB
Plaintext
52 lines
1.9 KiB
Plaintext
/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
/*
|
|
* The origin of this IDL file is
|
|
* https://www.whatwg.org/specs/web-apps/current-work/#eventhandler
|
|
*
|
|
* © Copyright 2004-2011 Apple Computer, Inc., Mozilla Foundation, and
|
|
* Opera Software ASA. You are granted a license to use, reproduce
|
|
* and create derivative works of this document.
|
|
*/
|
|
|
|
[TreatNonObjectAsNull]
|
|
callback EventHandlerNonNull = any (Event event);
|
|
typedef EventHandlerNonNull? EventHandler;
|
|
|
|
[TreatNonObjectAsNull]
|
|
callback OnErrorEventHandlerNonNull = boolean ((Event or DOMString) event, optional DOMString source,
|
|
optional unsigned long lineno, optional unsigned long column,
|
|
optional any error);
|
|
typedef OnErrorEventHandlerNonNull? OnErrorEventHandler;
|
|
|
|
[NoInterfaceObject]
|
|
interface GlobalEventHandlers {
|
|
attribute EventHandler onclick;
|
|
attribute EventHandler onload;
|
|
attribute EventHandler oninput;
|
|
attribute EventHandler onchange;
|
|
attribute EventHandler onsubmit;
|
|
};
|
|
|
|
[NoInterfaceObject]
|
|
interface WindowEventHandlers {
|
|
attribute EventHandler onunload;
|
|
};
|
|
|
|
// The spec has |attribute OnErrorEventHandler onerror;| on
|
|
// GlobalEventHandlers, and calls the handler differently depending on
|
|
// whether an ErrorEvent was fired. We don't do that, and until we do we'll
|
|
// need to distinguish between onerror on Window or on nodes.
|
|
|
|
/*[NoInterfaceObject]
|
|
interface OnErrorEventHandlerForNodes {
|
|
attribute EventHandler onerror;
|
|
};*/
|
|
|
|
[NoInterfaceObject]
|
|
interface OnErrorEventHandlerForWindow {
|
|
attribute OnErrorEventHandler onerror;
|
|
};
|