06e90addc7
We already cherry-picked this when we vendored f30c044cf9. Upstream commit: https://webrtc.googlesource.com/src/+/995688c8e85b520d50961486abbe0cc03eae9558 Revert "more p2p cleanups" This reverts commit f30c044cf9bd06f91017c171d98690094ce6d88b. Reason for revert: breaks roll to chromium: https://ci.chromium.org/ui/p/chromium/builders/try/mac_chromium_compile_dbg_ng/2290104/overview Original change's description: > more p2p cleanups > > Move test code from p2p/base and rtc_base/ into p2p/test/ > This p2p/base much less crowded and > clarifies that the rtc_base/nat* is in fact only test code. > > BUG=webrtc:0 > > Change-Id: I4d14fae24cb0eff6783962f4b4483b560367ca5d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/378900 > Commit-Queue: Jonas Oreland <jonaso@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Auto-Submit: Jonas Oreland <jonaso@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#43995} Bug: webrtc:0 Change-Id: I6c79fa85f53fdb9a1dacbe38911771f9a4289c76 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/379040 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43999} Differential Revision: https://phabricator.services.mozilla.com/D244009
29 lines
1.5 KiB
Diff
29 lines
1.5 KiB
Diff
From: Andreas Pehrson <apehrson@mozilla.com>
|
|
Date: Wed, 28 Aug 2024 07:50:00 +0000
|
|
Subject: Bug 1915082 - From ScreenCapturerSck request frames in sRGB
|
|
colorspace. r=webrtc-reviewers,ng
|
|
|
|
The desktop capture path has no colorspace handling for RGB, and libyuv assumes
|
|
sRGB by default. ScreenCaptureKit returns frames in the display's colorspace
|
|
unless told otherwise. On modern macs this is 'Display P3' and will render
|
|
inaccurately when interpreted as sRGB.
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D220219
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/6f6acc479b373662d4ed3ef3be84c3581622297f
|
|
---
|
|
modules/desktop_capture/mac/screen_capturer_sck.mm | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/modules/desktop_capture/mac/screen_capturer_sck.mm b/modules/desktop_capture/mac/screen_capturer_sck.mm
|
|
index 707199cd9e..14c7ea24ec 100644
|
|
--- a/modules/desktop_capture/mac/screen_capturer_sck.mm
|
|
+++ b/modules/desktop_capture/mac/screen_capturer_sck.mm
|
|
@@ -258,6 +258,7 @@ void ScreenCapturerSck::OnShareableContentCreated(SCShareableContent* content) {
|
|
excludingWindows:@[]];
|
|
SCStreamConfiguration* config = [[SCStreamConfiguration alloc] init];
|
|
config.pixelFormat = kCVPixelFormatType_32BGRA;
|
|
+ config.colorSpaceName = kCGColorSpaceSRGB;
|
|
config.showsCursor = capture_options_.prefer_cursor_embedded();
|
|
config.width = filter.contentRect.size.width * filter.pointPixelScale;
|
|
config.height = filter.contentRect.size.height * filter.pointPixelScale;
|