Commit Graph

532 Commits

Author SHA1 Message Date
Nika Layzell
ffba327709 Bug 1640019 - Part 2: Use new process switch logic in tabbrowser, r=mattwoodrow,Gijs
Add a series of extra hooks and methods to allow tabbrowser to use the new
process switching codepath. This duplicates some of the logic from
`updateBrowserRemoteness` into event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D78970
2020-06-15 23:23:46 +00:00
Neil Deakin
b408f179b5 Bug 1644155, remove some message listeners that are no longer used, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D78692
2020-06-12 23:28:47 +00:00
Narcis Beleuzu
a4b06a5d82 Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
Nika Layzell
ec5cc2b3df Bug 1640019 - Part 6: Get rid of the rebuild_frameloaders pref, r=Gijs
This pref was enabled on all platforms, and the codepath which has it disabled
has been untested for some time. Remove the pref to simplify the code handling
the old case.

Differential Revision: https://phabricator.services.mozilla.com/D78974
2020-06-12 16:52:07 +00:00
Nika Layzell
89527c6384 Bug 1640019 - Part 5: Remove a number of now-unused 'updateBrowserRemoteness' parameters, r=Gijs
These were only used by process switches triggered via DocumentChannel, which
now take the PROCESS_BEHAVIOR_STANDARD codepath.

Differential Revision: https://phabricator.services.mozilla.com/D78973
2020-06-12 16:52:04 +00:00
Nika Layzell
f660add49c Bug 1640019 - Part 4: Get rid of PROCESS_BEHAVIOR_CUSTOM, r=mattwoodrow,Gijs,necko-reviewers,valentin
As tabbrowser now uses `PROCESS_BEHAVIOR_STANDARD`, `PROCESS_BEHAVIOR_CUSTOM` is
now unused. This patch removes that now-unused code.

Differential Revision: https://phabricator.services.mozilla.com/D78972
2020-06-12 16:52:02 +00:00
Nika Layzell
76084be5e4 Bug 1640019 - Part 2: Use new process switch logic in tabbrowser, r=mattwoodrow,Gijs
Add a series of extra hooks and methods to allow tabbrowser to use the new
process switching codepath. This duplicates some of the logic from
`updateBrowserRemoteness` into event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D78970
2020-06-12 16:52:01 +00:00
Matt Woodrow
64471be383 Bug 1613589 - Persist TabProgressListener::mRequestCount across process switches. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D78838
2020-06-09 09:46:45 +00:00
Johann Hofmann
fb76d2ce00 Bug 1515073 - Part 3 - Add support for skipping session entries without user interaction on desktop. r=JanH,Gijs
Depends on D27586

Differential Revision: https://phabricator.services.mozilla.com/D27587
2020-06-09 14:50:18 +00:00
Jared Wein
6c6166160c Bug 1642084 - Check that tabs are connected when determining the amount of closed tabs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D78076
2020-06-03 16:02:37 +00:00
Emma Malysz
94857cc341 Bug 1634046: lazy load invalid form, date/time picker, and autoscroll panels and popups by placing in templates. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75971
2020-06-03 15:44:03 +00:00
Jared Wein
0b066cc8dd Bug 887515 - Restore multiple tab closings using Undo Close Tab(s) after a multiple-tab operation. r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76087
2020-05-30 06:48:18 +00:00
Mihai Alexandru Michis
25e550ae16 Backed out changeset 3d607fcf4dee (bug 887515) for causing failures in toolbar-context-menu-undo-close-tab
CLOSED TREE
2020-05-30 09:25:30 +03:00
Jared Wein
5d8094781f Bug 887515 - Restore multiple tab closings using Undo Close Tab(s) after a multiple-tab operation. r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76087
2020-05-30 05:38:56 +00:00
Agi Sferro
2fe5bfb13c Bug 1629113 - Move caret browsing handler to tabbrowser.js. r=NeilDeakin
We don't use it on GeckoView.

Differential Revision: https://phabricator.services.mozilla.com/D72724
2020-05-27 23:49:55 +00:00
Razvan Maries
f03defea0f Backed out changeset 9abcbf533b08 (bug 1629113) as per Agi's request. CLOSED TREE 2020-05-28 02:06:05 +03:00
Agi Sferro
d58f611927 Bug 1629113 - Move caret browsing handler to tabbrowser.js. r=NeilDeakin
We don't use it on GeckoView.

Differential Revision: https://phabricator.services.mozilla.com/D72724
2020-05-27 22:26:17 +00:00
Anny Gakhokidze
e08215360f Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp
In Bug 1622749 a user preference for where to open new documents (from a
service worker notification) was temporarily overriden in order to quickly fix
a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was
ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new
documents are opened in a new window, instead of a new tab. The reason the
browser crashed is because the path for opening a new document is different
depending on the current user setting, and in NEWWINDOW case we did not get a
browsing context returned when calling mozilla::dom::OpenWindow which resulted
in a failed assertion.

The solution is to pass in a callback to mozilla::dom::OpenWindow as part of
nsOpenWindowInfo object, and invoke that callback with a corresponding
BrowsingContext in nsFrameLoader when that browsing context is ready.

After we call mozilla::dom::OpenWindow, we wait on a promise, that will be
resolved when the callback is invoked, before executing the rest of the code
that depends on the browsing context for a newly opened document being
available.

Differential Revision: https://phabricator.services.mozilla.com/D72745
2020-05-27 18:15:36 +00:00
Razvan Maries
7df978dcab Backed out changeset 5b97f74fb6fd (bug 1629113) for perma failures on test_keycodes.xhtml. CLOSED TREE 2020-05-27 21:16:13 +03:00
Agi Sferro
40fac7931a Bug 1629113 - Move caret browsing handler to tabbrowser.js. r=NeilDeakin
We don't use it on GeckoView.

Differential Revision: https://phabricator.services.mozilla.com/D72724
2020-05-27 01:33:50 +00:00
Gijs Kruitbosch
6dddb5a255 Bug 1626842 - migrate the browser window title to fluent, r=zbraniecki,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75854
2020-05-25 10:01:42 +00:00
Neil Deakin
75fc6180d4 Bug 1594752, use WindowGlobalParent's documentTitle to update tab titles rather than sending messages and events between processes, r=Gijs
Fix up the browser_tab_label_during_restore.js test to wait for the right number of tab title changes, since the timing of the tab title updating has now changed.

Differential Revision: https://phabricator.services.mozilla.com/D72562
2020-05-19 13:42:41 +00:00
Mike Conley
afea9cf0bb Bug 1634796 - Add a panel that warns users before switching tabs when sharing the window over WebRTC. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D73734
2020-05-18 22:41:43 +00:00
Andreea Pavel
21811d567a Backed out 2 changesets (bug 1594752) for causing bug 1638148 on a CLOSED TREE
Backed out changeset 66cc44b67170 (bug 1594752)
Backed out changeset e781cf38f088 (bug 1594752)
2020-05-15 13:47:49 +03:00
Neil Deakin
ab455944fa Bug 1594752, use WindowGlobalParent's documentTitle to update tab titles rather than sending messages and events between processes, r=Gijs
Fix up the browser_tab_label_during_restore.js test to wait for the right number of tab title changes, since the timing of the tab title updating has now changed.

Differential Revision: https://phabricator.services.mozilla.com/D72562
2020-05-13 19:26:10 +00:00
Mihai Alexandru Michis
20781963e7 Backed out 2 changesets (bug 1594752) for causing failures in browser_e10s_switchbrowser.js
CLOSED TREE

Backed out changeset b54107a687e4 (bug 1594752)
Backed out changeset 801d1e226947 (bug 1594752)
2020-05-11 18:11:24 +03:00
Neil Deakin
d170441114 Bug 1594752, use WindowGlobalParent's documentTitle to update tab titles rather than sending messages and events between processes, r=Gijs
Fix up the browser_tab_label_during_restore.js test to wait for the right number of tab title changes, since the timing of the tab title updating has now changed.

Differential Revision: https://phabricator.services.mozilla.com/D72562
2020-05-11 09:03:03 +00:00
Ian Moody
0a0d8bf126 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Gijs Kruitbosch
d5e68b3a52 Bug 1634431 - actually update tab colours when container data changes, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D73684
2020-05-04 14:21:22 +00:00
Mélanie Chauvel (ariasuni)
98bed9ba3c Bug 1560218 - browser.tabs.duplicate() can now specify index and active property r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D67782
2020-05-04 01:11:32 +00:00
Dão Gottwald
aded9368bb Bug 1633635 - Make tab animations obey prefers-reduced-motion. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D72791
2020-04-30 18:43:37 +00:00
jayati
74e393775a Bug 1634012 - Remove the browser.tabs.showAudioPlayingIcon pref.r=dao
Differential Revision: https://phabricator.services.mozilla.com/D73084
2020-04-29 17:22:48 +00:00
Dão Gottwald
a396d00388 Bug 1633781 - Remove activemedia-blocked icon from tab when discarding browser. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73009
2020-04-29 09:23:55 +00:00
Dão Gottwald
d38b8b76e3 Bug 1632319 - Remove soundplaying icon from tab when discarding browser. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D72656
2020-04-27 23:49:35 +00:00
Nika Layzell
005f7d6520 Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-21 22:33:00 +00:00
Cosmin Sabou
f2de27edf5 Backed out 5 changesets (bug 1625513) for bc failures on browser_identity_UI.js. CLOSED TREE
Backed out changeset 88ac5d853e38 (bug 1625513)
Backed out changeset 8ac6db819435 (bug 1625513)
Backed out changeset cc19c74910d1 (bug 1625513)
Backed out changeset 8c235f0f967c (bug 1625513)
Backed out changeset 24a646225c68 (bug 1625513)
2020-04-22 00:17:08 +03:00
Nika Layzell
10fa812c79 Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-21 18:33:39 +00:00
Noemi Erli
a7719605fd Backed out 4 changesets (bug 1625513) for causing assertion in WindowGlobalChild.cpp
Backed out changeset 0366bbc9e0f7 (bug 1625513)
Backed out changeset 3554e0be2e66 (bug 1625513)
Backed out changeset ad09a911bc43 (bug 1625513)
Backed out changeset f2dbff5d584f (bug 1625513)
2020-04-20 22:28:20 +03:00
Nika Layzell
e5267e854c Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-20 16:57:01 +00:00
aarushivij
4c16085c87 Bug 1631416 - Remove unused gBrowser._XUL_NS r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71563
2020-04-20 14:57:54 +00:00
Dão Gottwald
b7903cea7a Bug 1630167 - Remove busy, progress, pendingicon attributes when discarding browser. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D71302
2020-04-17 20:13:36 +00:00
Oana Pop Rus
0842848548 Backed out 2 changesets (bug 1625513) for bc failures in browser/base/content/test/siteIdentity/browser_identity_UI.js on a CLOSED TREE
Backed out changeset 876b33334577 (bug 1625513)
Backed out changeset 69f75d37ae8e (bug 1625513)
2020-04-09 00:57:32 +03:00
Dão Gottwald
6c448c34cd Bug 1627969 - Remove the megabar pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70023
2020-04-08 19:04:24 +00:00
Nika Layzell
5e936cb7d5 Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-08 16:56:37 +00:00
Nika Layzell
4e2290e8e6 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053
2020-04-07 21:39:37 +00:00
Cosmin Sabou
6cffd2c78f Backed out 2 changesets (bug 1625513) for causing several reftest failures. CLOSED TREE
Backed out changeset 64dfd2e32a7b (bug 1625513)
Backed out changeset a78ae89b25b6 (bug 1625513)
2020-04-06 20:11:51 +03:00
Cosmin Sabou
357a0887a1 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell
2ad3a8351d Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-06 15:17:40 +00:00
Nika Layzell
1c99918951 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053
2020-04-06 14:30:07 +00:00
Zibi Braniecki
19ebcdc58b Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661
2020-04-01 18:44:03 +00:00