Commit Graph

178 Commits

Author SHA1 Message Date
Jonathan Sudiaman
ff8389ea29 Bug 1946868 - Remove "Turn on/off Vertical Tabs" in the tab context menu r=sidebar-reviewers,tabbrowser-reviewers,nsharpley,dao
Backout of Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs.

Differential Revision: https://phabricator.services.mozilla.com/D238106
2025-02-14 00:55:12 +00:00
DJ
a0b1928d27 Bug 1945169 - prevent a closing window from saving a group that is being adopted. r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237988
2025-02-13 19:39:28 +00:00
Jeremy Swinarton
eea0d1bd7f Bug 1933112: Tab groups only appear in TOM menus for windows with same privateness r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237604
2025-02-13 14:25:36 +00:00
Dão Gottwald
dd7219da44 Bug 1943814 - Reset related tabs map in _handleTabMove. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237729
2025-02-12 17:56:15 +00:00
Dão Gottwald
eb3174b1b2 Bug 1947598 - When moving a group to current window, select that group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237874
2025-02-12 17:43:48 +00:00
Dão Gottwald
0bbc0c683c Bug 1946050 - Consolidate tab context menu code dealing with multiple context tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236843
2025-02-05 18:16:04 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 14:05:08 +00:00
Dão Gottwald
fda9eb5278 Bug 1945264 - Let related new tabs inherit the current tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236731
2025-02-04 23:32:36 +00:00
Dão Gottwald
de0ae0ca64 Bug 1943589 - Allow adoptTab to adopt tabs into a tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236722
2025-02-04 19:32:43 +00:00
Emma Zuehlcke
c4bd8080a9 Bug 1866661, r=hjones,reusable-components-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D235457
2025-02-04 14:26:29 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236318
2025-02-03 10:15:25 +00:00
Dão Gottwald
69404071c4 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236160
2025-01-31 06:49:38 +00:00
Goloman Adrian
1527be7ffd Backed out changeset bb54bd88c1ec (bug 1936282) for causing bc failures @browser_tab_groups.js. CLOSED TREE 2025-01-30 23:30:56 +02:00
Dão Gottwald
4d47d13ad1 Bug 1943885 - Pinning first tab should ungroup it. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236212
2025-01-30 17:01:11 +00:00
Dão Gottwald
106b2aad45 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236160
2025-01-30 14:49:12 +00:00
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D236035
2025-01-29 23:29:40 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234804
2025-01-29 18:37:29 +00:00
Emilio Cobos Álvarez
77261b9adc Bug 1943301 - Simplify tab throbber animation syncing. r=dao,tabbrowser-reviewers
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.

Differential Revision: https://phabricator.services.mozilla.com/D235300
2025-01-23 15:02:01 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234680
2025-01-21 23:07:02 +00:00
Dão Gottwald
44026bd308 Bug 1921034 - Remove bug reference. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D234949
2025-01-21 12:45:36 +00:00
Greg Stoll
96e0daa1a5 Bug 1926396 - when unloading current tab, don't switch to an unloaded tab r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D234569
2025-01-16 19:53:09 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-15 23:07:45 +00:00
Dão Gottwald
027c8b5a85 Bug 1927927 - Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234173
2025-01-14 15:55:47 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-13 17:55:32 +00:00
Stephen Thompson
86ccb78df7 Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-09 20:07:00 +00:00
Butkovits Atila
d7afe8c2aa Backed out changeset 0edde29b2e70 (bug 1939503) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-08 05:43:29 +02:00
Stephen Thompson
607c9a5cec Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-08 02:47:03 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232430
2024-12-19 08:54:25 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-12 12:57:41 +00:00
Dão Gottwald
8a2e7099f7 Bug 1934007 - Prevent empty group when attempting to group pinned tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231788
2024-12-11 16:21:34 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-11 14:37:38 +00:00
Emilio Cobos Álvarez
910845c8c5 Bug 1933769 - Remove no-op focus() calls. r=tabbrowser-reviewers,dao
Since bug 1823984, this focus() call has been a no-op on remote frames.

The previous patch also fixes the non-remote frame focus switch.

Differential Revision: https://phabricator.services.mozilla.com/D230098
2024-12-09 21:42:42 +00:00
Stephen Thompson
b437b0d758 Bug 1927994 - do not allow pinned tabs to move inside tab groups r=dao,tabbrowser-reviewers
There are a number of oddities that cropped up from pinned tabs moving into tab groups, e.g. when the first item in the tab strip is a tab group or when pinning a tab that's already in a tab group. This patch repairs those cases to ensure that pinned tabs stick to the beginning of the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D230344
2024-12-06 05:26:16 +00:00
Dão Gottwald
1a974c5351 Bug 1935029 - Add Nimbus recipe for tab groups. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231030
2024-12-05 15:13:07 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-05 01:20:07 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-04 04:17:36 +00:00
Dão Gottwald
db518f5774 Bug 1934296 - Adding a tab to a collapsed group should expand the group. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D230982
2024-12-03 18:15:28 +00:00