Commit Graph

265 Commits

Author SHA1 Message Date
Mark Banner
e20bef570f Bug 1957754 - Add urlbar.searchmode.searchbutton probe to the address bar documentation. r=urlbar-reviewers,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D244077
2025-04-07 07:41:02 +00:00
Mark Banner
97091a5334 Bug 1919068 - Update the address bar scalars telemetry documentation on Firefox source docs. r=urlbar-reviewers,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D244045
2025-04-07 07:41:01 +00:00
Stephanie Cunnane
9ef2c19ec4 Bug 1932712 - Remove legacy urlbar.impression.* scalars, as well as their mirrors to Glean events. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D241309
2025-03-18 17:08:41 +00:00
Florian Quèze
4213649791 Bug 1938938 - migrate to Glean the PLACES_AUTOCOMPLETE_* histograms, r=Standard8,urlbar-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D241243
2025-03-17 16:14:05 +00:00
Florian Quèze
5e08a22d9f Bug 1938938 - remove the FX_URLBAR_ZERO_PREFIX_DWELL_TIME_MS histogram, r=adw,urlbar-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D241242
2025-03-17 16:14:04 +00:00
Stephanie Cunnane
4a917e543e Bug 1932707 - Remove legacy FX_URLBAR_SELECTED_RESULT_METHOD histogram. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D239003
2025-02-21 21:47:34 +00:00
Daisuke Akatsuka
95533899a1 Bug 1936455: Remove the Suggest online opt-in onboarding dialog r=firefox-desktop-core-reviewers ,urlbar-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D238893
2025-02-21 05:01:33 +00:00
Alexandru Marc
a822e8842c Backed out changeset 2c10082390b2 (bug 1936455) for causing xpcshell failures @ test_quicksuggest_migrate_v1.js CLOSED TREE 2025-02-21 03:51:58 +02:00
Daisuke Akatsuka
9c1c8fcf29 Bug 1936455: Remove the Suggest online opt-in onboarding dialog r=firefox-desktop-core-reviewers ,urlbar-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D238893
2025-02-21 01:05:42 +00:00
Drew Willcoxon
8243560a80 Bug 1946922 - Remove Merino-related legacy telemetry histograms. r=daisuke,urlbar-reviewers
Removing these histograms makes it possible to simplify `MerinoClient` further,
but I'll leave that to a follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D238979
2025-02-21 00:23:40 +00:00
Stephanie Cunnane
f87d4b5743 Bug 1932715 - Remove legacy urlbar.tabtosearch.* scalars and Glean urlbar.tabtosearch.* labeled counters. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D238292
2025-02-19 16:21:10 +00:00
Stephanie Cunnane
002c094a5c Bug 1932713 - Remove legacy urlbar.picked.* scalars and Glean urlbar.picked.* labeled counters. r=adw,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D237974
2025-02-18 21:18:58 +00:00
Stephanie Cunnane
dff74b6859 Bug 1932711 - Remove legacy urlbar.engagement and urlbar.abandonment scalars, as well as their mirrors to Glean counters. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D237255
2025-02-13 16:57:41 +00:00
Stephanie Cunnane
c9ddaf4b3d Bug 1932716 - Remove legacy urlbar.tips scalar and Glean urlbar.tips labeled counter. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D236590
2025-02-07 14:53:12 +00:00
Sylvestre Ledru
b588c53a93 Bug 1943936 - codespell 2.4.0: typo fixes r=linter-reviewers,profiler-reviewers,canaltinova,ahal
Differential Revision: https://phabricator.services.mozilla.com/D235601
2025-01-27 15:28:31 +00:00
Daisuke Akatsuka
630450ad17 Bug 1936673: Add telemetry for Unified Search Button r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D231904
2024-12-18 13:01:21 +00:00
Drew Willcoxon
31a8192d0b Bug 1932502 - Remove the Suggest JS backend: Part 4: Remove other Nimbus variables and legacy telemetry. r=daisuke
This is part 4 of 4. There are some Nimbus variables that are now unused plus
one legacy histogram.

Depends on D231467

Differential Revision: https://phabricator.services.mozilla.com/D231468
2024-12-11 20:50:46 +00:00
Tooru Fujisawa
e31cf22b91 Bug 1934055 - Update browser/components/urlbar/docs/testing.rst to use ESM-based API. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230570
2024-11-29 05:25:54 +00:00
Florian Quèze
656d023a54 Bug 1927093 - Migrate scalars to use Glean APIs for quickaction.*, r=chutten,daleharvey.
Differential Revision: https://phabricator.services.mozilla.com/D227814
2024-11-14 23:09:12 +00:00
Florian Quèze
6ac3c84fb1 Bug 1925355 - Remove contextual.services.quicksuggest legacy telemetry scalars, r=adw,urlbar-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D226039
2024-10-18 08:57:18 +00:00
Collin Richards
7b80019694 Bug 1086524 - Focus window on Esc in address bar r=dao,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218893
2024-10-17 11:56:34 +00:00
Cosmin Sabou
73e2568ce9 Backed out changeset c3560df7c73f (bug 1086524) for causing bc failures on browser_searchModeSwitcher_basic. 2024-10-17 00:49:27 +03:00
Collin Richards
4c5cad9017 Bug 1086524 - Focus window on Esc in address bar r=dao,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218893
2024-10-16 15:55:01 +00:00
Adi
7d671034f6 Backed out changeset c03123359b41 (bug 1086524) for causing browser_persist_searchMode.js failures. CLOSED TREE 2024-10-16 16:54:55 +03:00
Collin Richards
9f857b20cb Bug 1086524 - Focus window on Esc in address bar r=dao,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218893
2024-10-16 11:47:11 +00:00
mcheang
6a815ad8e0 Bug 1919180 - Update scalar keys for urlbar.searchmode.typed and urlbar.searchmode.keywordoffer. r=mak,urlbar-reviewers
- `urlbar.searchmode.typed`: suffixed with "keyword" for restrict keyword entries and "symbol" for symbol entries.
- `urlbar.searchmode.keywordoffer`: suffixed with "keyword" for restrict keyword entries via keywordoffer.
- Example: History search mode scalar key is `history_keyword` for restrict keyword and `history_symbol` for symbol.

Differential Revision: https://phabricator.services.mozilla.com/D223210
2024-10-08 14:10:01 +00:00
Tamas Szentpeteri
217012b8ec Backed out changeset 737f799b6c6c (bug 1919180) for causing mochitest fails on browser_secondaryActions.js. CLOSED TREE 2024-10-04 04:40:15 +03:00
mcheang
8bf9314776 Bug 1919180 - Update scalar keys for urlbar.searchmode.typed and urlbar.searchmode.keywordoffer. r=mak,urlbar-reviewers
- `urlbar.searchmode.typed`: suffixed with "keyword" for restrict keyword entries and "symbol" for symbol entries.
- `urlbar.searchmode.keywordoffer`: suffixed with "keyword" for restrict keyword entries via keywordoffer.
- Example: History search mode scalar key is `history_keyword` for restrict keyword and `history_symbol` for symbol.

Differential Revision: https://phabricator.services.mozilla.com/D223210
2024-10-03 23:18:05 +00:00
Sandor Molnar
232317ebfc Backed out changeset 2fa695c28d67 (bug 1919180) for causing bc failures @ browser_searchMode_switchTabs.js CLOSED TREE 2024-10-03 01:47:33 +03:00
mcheang
d66595dcf8 Bug 1919180 - Update scalar keys for urlbar.searchmode.typed and urlbar.searchmode.keywordoffer. r=mak,urlbar-reviewers
- `urlbar.searchmode.typed`: suffixed with "keyword" for restrict keyword entries and "symbol" for symbol entries.
- `urlbar.searchmode.keywordoffer`: suffixed with "keyword" for restrict keyword entries via keywordoffer.
- Example: History search mode scalar key is `history_keyword` for restrict keyword and `history_symbol` for symbol.

Differential Revision: https://phabricator.services.mozilla.com/D223210
2024-10-02 19:01:01 +00:00
Florian Quèze
9028981ddf Bug 1921748 - Remove contextservices.quicksuggest legacy telemetry events, r=chutten,urlbar-reviewers,adw.
Differential Revision: https://phabricator.services.mozilla.com/D222808
2024-10-02 14:34:02 +00:00
mcheang
38e8fa20a9 Bug 1917992 - Add scalar telemetry for picked restrict keyword result and glean telemetry for abandonment and engagement. r=mak,urlbar-reviewers
This patch adds telemetry for when the user sees or interacts with restrict keyword results.
Following is an overview of the interactions that will trigger the telemetry to be recorded:

When the user types `@` and selects one of the restrict results, the scalar telemetry will be recorded:

  - `urlbar.picked.restrict_keyword_tabs`
  - `urlbar.picked.restrict_keyword_bookmarks`
  - `urlbar.picked.restrict_keyword_history`
  - `urlbar.picked.restrict_keyword_actions`

For example, we can select the tabs result in multiple ways for the telemetry to be recorded:
  - type`@` and click on tabs result
  - type`@` and arrow down to tabs result and press enter
  - type partial keyword `@t` and press enter to autofill
  - type partial keyword `@t` and press tab and then enter


When the user types `@` and **does not** select one of the restrict results, the glean abandonment will be recorded:
```
    groups:
      "general,general,general,general,general,general,restrict_keyword,restrict_keyword,restrict_keyword,restrict_keyword",
    results:
      "search_engine,search_engine,search_engine,search_engine,search_engine,search_engine,restrict_keyword_bookmarks,restrict_keyword_tabs,restrict_keyword_history,restrict_keyword_actions",
```

When the user types `@` and **does** select one of the restrict results, the glean engagement will be recorded:
```
    groups:
      "general,general,general,general,general,general,restrict_keyword,restrict_keyword,restrict_keyword,restrict_keyword",
    results:
       "search_engine,search_engine,search_engine,search_engine,search_engine,search_engine,restrict_keyword_bookmarks,restrict_keyword_tabs,restrict_keyword_history,restrict_keyword_actions",
    selected_result: `restrict_keyword_${category}`,
```

For the `selected_result` in engagement telemetry, the `category` variable will be `tabs, bookmarks, history, or actions`.

Differential Revision: https://phabricator.services.mozilla.com/D222355
2024-09-23 18:21:41 +00:00
Drew Willcoxon
8c6acb1e3d Bug 1916873 - Allow Suggest to be safely enabled in non-Suggest locales. r=daisuke,settings-reviewers,mossop
In addition to addressing the bug, this also adds some exposure tests to make
sure that they can be triggered in non-Suggest locales and that non-exposure
suggestions are not triggered.

Depends on D220501

Differential Revision: https://phabricator.services.mozilla.com/D221097
2024-09-11 19:39:59 +00:00
Francesco Lodolo (:flod)
426d95862d Bug 1917163 - Update rstcheck to 6.2.4, fix resulting errors in documents, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D221287
2024-09-06 15:04:10 +00:00
Cristina Horotan
fcdbf602e5 Backed out changeset 4e2df2c48e4b (bug 1917163) for causing mozlint failure. CLOSED TREE 2024-09-06 16:57:11 +03:00
Francesco Lodolo (:flod)
d62c1a8e25 Bug 1917163 - Update rstcheck to 6.2.4, fix resulting errors in documents, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D221287
2024-09-06 12:17:06 +00:00
Mark Banner
6f297d4ef8 Bug 1915550 - Fix document errors in urlbar dynamic-result-types. r=urlbar-reviewers,jteow
The error was:
ERROR: Unknown target name: "appendix b: using the webextensions api directly".

This is out of date documentation as we no longer support webextensions for dynamic result types.

Differential Revision: https://phabricator.services.mozilla.com/D220532
2024-09-02 14:38:07 +00:00
Karandeep
d1dbab6e8d Bug 1912040 - Remove all instances of onLegacyEngagement(). r=adw,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219068
2024-08-14 12:38:26 +00:00
Iulian Moraru
4371796885 Backed out changeset c052f2639595 (bug 1086524) for causing multiple browser failures related to urlbar. CLOSED TREE 2024-08-13 12:44:56 +03:00
Collin Richards
ba7657463c Bug 1086524 - Focus window on Esc in address bar r=dao,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218893
2024-08-13 08:36:51 +00:00
Drew Willcoxon
067c9bc5b1 Bug 1911683 - Remove shouldNavigate for dynamic result types and make UrlbarUtils.getUrlFromResult() fall back to payload.url for all results. r=daisuke
Please see the bug for info.

Differential Revision: https://phabricator.services.mozilla.com/D218607
2024-08-06 01:41:04 +00:00
James Teow
fa3b3d1fea Bug 1905100 - Remove Persisted Search Tip - r=adw,urlbar-reviewers
The onboarding will be handled by OMC who will help with the
messaging for all the scotch bonnet features.

Differential Revision: https://phabricator.services.mozilla.com/D215234
2024-07-01 23:45:47 +00:00
Dale Harvey
35e363801a Bug 1893067 - Add actions key to glean urlbar metrics. r=mak,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D214763
2024-06-29 21:50:46 +00:00
Dale Harvey
8f27c5fa6e Bug 1903146 - Remove experiment.searchButton pref. r=urlbar-reviewers,dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D214671
2024-06-27 10:26:09 +00:00
Yazan Al Macki
88ee6a2c27 Bug 1885897 - Remove browser.urlbar.update2.emptySearchBehavior pref, and test cases where it is set to non-default value. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D210081
2024-05-17 14:36:43 +00:00
Daisuke Akatsuka
da00b8a3de Bug 1891602: Remove telemetries that are no longer in use r=adw
Differential Revision: https://phabricator.services.mozilla.com/D207514
2024-04-17 08:54:56 +00:00
Karandeep
d8690f18b5 Bug 1888908 - Rename current onEngagement to onLegacyEngagement r=mak
Differential Revision: https://phabricator.services.mozilla.com/D206251
2024-04-09 13:07:23 +00:00
Mark Banner
57d07fefcd Bug 1884623 - Fix documentation warning in browser/components/urlbar/docs/overview.rst.
Differential Revision: https://phabricator.services.mozilla.com/D204264
2024-03-11 16:26:43 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Karandeep
8ba14c9af9 Bug 1878983 - Remove the urlbar.impression event. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D201614
2024-02-21 14:24:58 +00:00