corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
904,500 Commits 1 Branch 0 Tags
ff54df4c81c7ec43e166a0683670a8498f6f9be3
Commit Graph

3814 Commits

Author SHA1 Message Date
Dão Gottwald
ff54df4c81 Bug 1957448 - Disabled context menu within UrlbarView rather than the #urlbar div. r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D245055
 2025-04-11 16:14:06 +00:00
Stephen Thompson
f2e07044ae Bug 1938424 - metrics event when tabs added to tab group r=dao,jswinarton,tabbrowser-reviewers,extension-reviewers,robwu 
When using the tab context menu or drag-dropping tabs to put them into a group, record a metric for the number of tabs added to the group.

Data Science asked us to launch with this metric disabled so that they could control it using server knobs. They expect a high volume of events, so they expect to only enable this metric for some proportion of users.

I converted the existing `TabMove` event derived from `UIEvent` being fired when tabs change their tab index in the tab strip. `UIEvent` doesn't allow for attaching additional context/detail to the event. `TabMove` is now a `CustomEvent` that provides more context about the moved tab and it fires in more cases -- it's possible for the tab index not to change despite the tab having "moved" into/out of a tab group.

This approach would not capture tab movements that occur across multiple frames/event loop iterations.

Differential Revision: https://phabricator.services.mozilla.com/D244616
 2025-04-11 13:52:22 +00:00
Eric Chen
38b476436b Bug 1958142 - Disable event handling and remove background colours for URL bars in taskbar tab windows r=dao,desktop-theme-reviewers,urlbar-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D244279
 2025-04-10 20:22:52 +00:00
Goloman Adrian
ba26c8e947 Backed out changeset 7114f85e40e4 (bug 1958142) for causing bc failures @browser_ext_themes_autocomplete_popup.js. CLOSED TREE 2025-04-10 22:17:37 +03:00
Eric Chen
36a31a5531 Bug 1958142 - Disable event handling and remove background colours for URL bars in taskbar tab windows r=dao,desktop-theme-reviewers,urlbar-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D244279
 2025-04-10 17:47:46 +00:00
DJ
91384c4388 Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-10 17:35:20 +00:00
Butkovits Atila
b9dc6231d7 Backed out changeset 4711e76ce475 (bug 1938425) for causing failures at browser_tab_groups_telemetry.js. CLOSED TREE 2025-04-10 09:35:44 +03:00
DJ
cdc29e0d0d Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-10 03:02:30 +00:00
Drew Willcoxon
843fe01a85 Bug 1959330 - Formalize restoring of dismissed Suggest suggestions. r=daisuke,settings-reviewers 
Please see the bug for the motivation.

This adds a new `SuggestFeature.primaryUserControlledPreference` getter that
returns the feature-specific pref that lets the user toggle on/off the feature.

That way we can add `QuickSuggest.clearDismissedSuggestions()`, which goes
through each feature and clears that pref, and `canClearDismissedSuggestions()`,
which goes through and checks whether there are any prefs that can be cleared.

I also added a couple of notification topics for dismissals that the settings UI
uses to update the disabled state of its Restore button.

All of this will let us more easily move to the Suggest Rust component's
dismissal API too, which we should sooner or later.

Depends on D244865

Differential Revision: https://phabricator.services.mozilla.com/D244866
 2025-04-10 02:24:19 +00:00
Daisuke Akatsuka
18acc09b5f Bug 1957630: Restore Unified Search Button availability even after switching tab r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D244709
 2025-04-10 02:19:34 +00:00
Drew Willcoxon
5ab014582a Bug 1959331 - Factor out Suggest unit test dismissal helpers. r=daisuke 
This factors out `doDismissOneTest` and `doDismissAllTest`, similar to the
existing `doShowLessFrequentlyTests`.

Depends on D244806

Differential Revision: https://phabricator.services.mozilla.com/D244865
 2025-04-09 19:25:03 +00:00
Cristina Horotan
2d08511dac Backed out changeset 7fed35bbd242 (bug 1938425) for causing bc failures at browser_tab_groups_telemetry.js. CLOSED TREE 2025-04-09 13:06:03 +03:00
DJ
e9f93720b5 Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-09 03:07:19 +00:00
Drew Willcoxon
cf604f88fb Bug 1958988 - Tweak weather suggestions result menu and prepare UI strings for l10n. r=daisuke,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D244806
 2025-04-09 00:14:44 +00:00
Stanca Serban
e291128c4c Backed out changeset 11dc373cc55d (bug 1924764) as requested by @bdk because it requires another commit. CLOSED TREE 2025-04-08 22:54:12 +03:00
Bastian Gruber
dac78cf147 Bug 1924764 - Adjust UniFFI JS enum bindings to match Rust discriminants. r=bdk,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D242586
 2025-04-08 16:29:48 +00:00
Moritz Beier
15f2f8b13d Bug 1958878 - Make sure quick actions work when switching between tabs. r=urlbar-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D244611
 2025-04-08 16:25:43 +00:00
smolnar
8c01d285cf Backed out changeset 1c700c5b8a89 (bug 1938425) for causing bc failures @ browser_tab_groups_telemetry.js CLOSED TREE 2025-04-07 19:45:55 +03:00
Stephanie Cunnane
93cf8c0d1f Bug 1958147 - Extend urlbar.quick_suggest_contextual_opt_in Glean event expiration until Fx 147. r=urlbar-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D244414
 2025-04-07 16:26:19 +00:00
DJ
b8f461ce7f Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-07 14:51:17 +00:00
Iulian Moraru
ff3b90d82d Backed out changeset 030feec729dd (bug 1788088) for causing bc failures on browser_new_tab_insert_position.js. CLOSED TREE 2025-04-07 18:00:10 +03:00
Moritz Beier
274063e54e Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D243793
 2025-04-07 13:37:02 +00:00
Mark Banner
e20bef570f Bug 1957754 - Add urlbar.searchmode.searchbutton probe to the address bar documentation. r=urlbar-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D244077
 2025-04-07 07:41:02 +00:00
Mark Banner
97091a5334 Bug 1919068 - Update the address bar scalars telemetry documentation on Firefox source docs. r=urlbar-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D244045
 2025-04-07 07:41:01 +00:00
mcheang
798ce255cb Bug 1956384 - Set rustSelector.featureGate flag to true on Nightly and early Beta. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D243040
 2025-03-31 18:30:39 +00:00
Stephanie Cunnane
f5c0b3c735 Bug 1953239 - Stop calling BrowserSearchTelemetry.recordSearchSuggestionSelectionMethod from address bar code. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D243196
 2025-03-31 16:13:37 +00:00
Dale Harvey
bdb014affa Bug 1953488 - Add keyword for inspector quickaction. r=daisuke,fluent-reviewers,urlbar-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D243027
 2025-03-29 16:34:46 +00:00
Dale Harvey
9dc206b348 Bug 1953494 - Add keyword for screenshot quickaction. r=daisuke,fluent-reviewers,urlbar-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D243026
 2025-03-29 16:34:45 +00:00
Dale Harvey
e6830d9d09 Bug 1953498 - Add keyword for view source quickaction. r=daisuke,fluent-reviewers,urlbar-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D243025
 2025-03-29 16:34:45 +00:00
Dale Harvey
efe3e752fa Bug 1953485 - Remove plugins quickaction. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D243024
 2025-03-29 16:34:45 +00:00
Drew Willcoxon
9d0a8e81e7 Bug 1957158 - In Suggest custom targeting attributes, change form_factor to formFactor. r=bdk 
Differential Revision: https://phabricator.services.mozilla.com/D243555
 2025-03-28 21:19:25 +00:00
Chidam Gopal
71748b8d1a Bug 1956656 - fix NER suggest to handle engine cache with featureId r=tarek,adw,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D243222
 2025-03-27 13:11:19 +00:00
Moritz Beier
b3f32df67e Bug 1955066 - Enter search mode after adding an HTML form as a search engine. r=urlbar-reviewers,search-reviewers,scunnane,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D242187
 2025-03-26 09:58:54 +00:00
Moritz Beier
a53fc7dc78 Bug 1949719 - Part 2: Allow editing custom search engines using the dialog. r=Standard8,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,urlbar-reviewers,bolsson,mossop,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D240846
 2025-03-26 08:50:42 +00:00
Mark Banner
59952e7d62 Bug 1953479 - Add a SearchUITestUtils helper with a function for checking search SAP counts. r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D242774
 2025-03-25 21:40:14 +00:00
Dale Harvey
71dccf0265 Bug 1953482 - Add new help quickaction. r=daisuke,fluent-reviewers,urlbar-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D241984
 2025-03-24 21:53:18 +00:00
Dale Harvey
dafd40bbfe Bug 1953478 - Update history quickaction strings. r=daisuke,fluent-reviewers,omc-reviewers,urlbar-reviewers,flod,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D241983
 2025-03-24 21:53:18 +00:00
Dale Harvey
fd5694e666 Bug 1953489 - Add Firefox View quickaction. r=daisuke,fluent-reviewers,urlbar-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D241982
 2025-03-24 21:53:17 +00:00
Dão Gottwald
369d408717 Bug 1955818 - Read browser.tabs.groups.enabled pref directly. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D242651
 2025-03-23 13:11:51 +00:00
Moritz Beier
5a24af2433 Bug 1949719 - Part 1: Allow editing the names of custom search engines via the table in preferences. r=Standard8,settings-reviewers,mossop,fluent-reviewers,urlbar-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D240845
 2025-03-21 11:42:31 +00:00
Marco Bonardo
231564e327 Bug 1952213. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D242155
 2025-03-20 09:47:06 +00:00
Francesco Lodolo (:flod)
0f4b702c89 Bug 1955004 - Avoid generating Fluent IDs at run-time in address bar, r=urlbar-reviewers,adw 
Also removed unused string in browser.ftl

Differential Revision: https://phabricator.services.mozilla.com/D242192
 2025-03-19 18:21:15 +00:00
Yazan Al Macki
4c0f626736 Bug 1955018 - Make calculator formatting consistent for negative numbers. r=jteow,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242157
 2025-03-19 16:41:01 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt 
Differential Revision: https://phabricator.services.mozilla.com/D239937
 2025-03-19 15:07:53 +00:00
Jason Prickett
d51e46b708 Bug 1953129 - Cap totalSearches pref at 100 r=omc-reviewers,urlbar-reviewers,mviar,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D241671
 2025-03-18 23:08:15 +00:00
Yazan Al Macki
b8ce80559b Bug 1953073 - Modify calc result formatting to fix issues with signficant digits and unnecessary grouping. r=fluent-reviewers,urlbar-reviewers,bolsson,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D241869
 2025-03-18 20:28:52 +00:00
Stephanie Cunnane
9ef2c19ec4 Bug 1932712 - Remove legacy urlbar.impression.* scalars, as well as their mirrors to Glean events. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D241309
 2025-03-18 17:08:41 +00:00
Daisuke Akatsuka
1cc96a27ab Bug 1953920: Avoid capturing event on Unified Search Button when hiding the popup by mouse r=daleharvey 
Depends on D241542

Differential Revision: https://phabricator.services.mozilla.com/D241700
 2025-03-18 05:13:24 +00:00
Daisuke Akatsuka
f760504e7c Bug 1953927: Close urlbar view explicitly when opening Unified Search Engine popup r=desktop-theme-reviewers,daleharvey,dao 
Differential Revision: https://phabricator.services.mozilla.com/D241542
 2025-03-18 05:13:24 +00:00
Norisz Fay
17d578c8b5 Backed out 2 changesets (bug 1953920, bug 1953927) for causing searchModeSwitcher related failures CLOSED TREE 
Backed out changeset 8b74e1a3e693 (bug 1953920)
Backed out changeset 4dfd7b14198d (bug 1953927)
 2025-03-18 01:38:16 +02:00