Andi-Bogdan Postelnicu
569bc9b63e
Bug 1453795 - Layout - Initialize member fields in classes/ structures. r=dbaron
2018-07-12 09:42:14 +03:00
Chris Peterson
f7ceeaf5cf
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
2018-06-17 22:43:11 -07:00
Matt Woodrow
b64969f18b
Bug 1460491 - Part 1: Split nsDisplayItem::mVisibleRect into two members, one for each stated purpose. Gets rid of the save/restore since we no longer modify the building rect. r=jnicol
...
MozReview-Commit-ID: 5wcsSoZRN44
2018-05-16 15:56:32 +12:00
Chris Peterson
5d6b16ea3b
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Boris Zbarsky
d31be385d3
Bug 1455674 part 14. Remove use of nsIDOMElement in layout. r=qdot
2018-04-26 23:37:33 -04:00
Alexis Beingessner
c232d69445
Bug 1430869 - use mVisibleRect instead of GetRect. r=mstange
...
An ancient comment from 1998 assures us that GetRect is wrong if there are captions.
The painting code instead uses mVisibleRect which appears to be correct.
MozReview-Commit-ID: 6Lax4sjInJu
2018-04-23 15:08:04 -04:00
Sebastian Hengst
d91e9954eb
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Mats Palmgren
f3a0c9e1e8
Bug 1434478 part 6 - Propagate a percentage basis to nsIFrame::IntrinsicISizeOffsets for resolving padding/margin. r=dholbert
...
This is needed only for CSS Grid since in other cases we're
only using IntrinsicISizeOffsets in the inline-axis and
the percentage basis is always indefinite for *intrinsic
sizing*. When calculating the intrinsic size of grid items
in the grid container's block axis however, we do have
a definite size for the grid area in the inline-axis and it
should be used per:
https://drafts.csswg.org/css-grid/#algo-overview
"2. Next, the track sizing algorithm resolves the sizes of
the grid rows, using the grid column sizes calculated in
the previous step."
(Percentage padding/margin for grid items is always resolved
against the grid area's inline-size nowadays.)
2018-04-10 00:16:58 +02:00
Mats Palmgren
0eee70c35a
Bug 1434478 part 3 - Remove IntrinsicISizeOffsetData::hPctPadding/hPctMargin members since they are now unused. r=dholbert
2018-04-10 00:16:58 +02:00
Emilio Cobos Álvarez
3284a9dda8
Bug 1447827: Remove ServoRestyleManager. r=xidorn
...
MozReview-Commit-ID: CFafQsb4rQn
2018-04-07 15:50:06 +02:00
Matt Woodrow
4e885ca8c2
Bug 1370575 - Do less manual invalidation when tables changes, and rely on DLBI instead. r=mstange
2018-04-04 16:17:49 +12:00
Jeff Muizelaar
e93159c4c0
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats
...
This function doesn't use any StackingContextHelper state anymore.
We should make what it does clearer and move it to a better place.
2018-03-29 17:57:43 -04:00
Xidorn Quan
ea8b8b1e74
Bug 1449400 part 5 - Remove StyleSetHandle. r=emilio
...
This patch basically does:
* remove StyleSetHandle and its corresponding files
* revisit #includes of related header files and change correspondingly
* change nsIPresShell::mStyleSet to be UniquePtr<ServoStyleSet>
* change the creating path of ServoStyleSet to pass UniquePtr
* change other mentions of StyleSetHandle to ServoStyleSet*
* remove AsServo() calls on ServoStyleSet
Some unfortunate bits:
* some methods of (Servo)StyleSet only accepts ServoStyleSheet while
many places call into the methods with StyleSheet, so there are many
->AsServo() added to sheets
MozReview-Commit-ID: K4zYnuhOurA
2018-03-29 22:15:46 +11:00
Jonathan Watt
baf9ffb02b
Bug 1448714 - Fix up comments referring to 'style context' after the rename of nsStyleContext. r=emilio
2018-03-23 13:49:21 +00:00
Emilio Cobos Álvarez
fb9a0faf99
Bug 1448559: Cleanup CalcStyleDifference. r=xidorn
...
The aSamePointerStructs argument is unused now.
Also, aIgnoreVariables can be true everywhere now, since variable changes can't
generate change hints, and anonymous boxes and such don't care about whether
they really changed or not.
Only one caller cares about struct equality, and that already compares variables
manually as an optimization on the rust side.
We had this optimization inconsistently in some cases but not others.
MozReview-Commit-ID: F2EISKlxR3K
2018-03-26 09:47:33 +02:00
Emilio Cobos Álvarez
68ee99d4c8
Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn
...
MozReview-Commit-ID: ALiOngGqozN
2018-03-26 09:38:07 +02:00
Jonathan Watt
19a102f496
Bug 1448294 - Clean up naming of 'styleContext' variables after the big nsStyleContext rename. r=emilio
...
Reviewers: emilio
Bug #: 1448294
Differential Revision: https://phabricator.services.mozilla.com/D796
MozReview-Commit-ID: KJq2i9nrg7y
2018-03-25 20:49:58 +02:00
Narcis Beleuzu
2764b805dc
Backed out 2 changesets (bug 1448294, bug 1448337) for wpt and reftest failures on /mathml
...
Backed out changeset 180051cfe357 (bug 1448294)
Backed out changeset c188176f3289 (bug 1448337)
2018-03-25 21:31:08 +03:00
Emilio Cobos Álvarez
0b3a18a950
Bug 1448413: Do a bit of misc cleanup. r=jwatt
...
Summary: Mostly removing unneeded AsServo() and such.
Reviewers: jwatt
Bug #: 1448413
Differential Revision: https://phabricator.services.mozilla.com/D798
MozReview-Commit-ID: 8muHF7uMA53
2018-03-25 18:14:36 +02:00
Jonathan Watt
68804bb222
Summary: Bug 1448294 - Clean up naming of 'styleContext' variables after the big nsStyleContext rename. r=emilio
...
Reviewers: emilio
Bug #: 1448294
Differential Revision: https://phabricator.services.mozilla.com/D796
2018-03-22 13:49:21 +00:00
Emilio Cobos Álvarez
1d4859a89a
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
97286b35c8
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
1f5d8de5cc
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Ryan Hunt
b419c79ff5
Remove DisplayItemLayer and corresponding layers.advanced prefs. (bug 1439960, r=mstange)
...
MozReview-Commit-ID: FAWTC1Llu31
2018-02-21 09:29:49 -06:00
Cosmin Sabou
4e421f7abe
Backed out 3 changesets (bug 1439960) for build bustages on APZInputBridgeChild.cpp and FrameBuilder.cpp. CLOSED TREE
...
Backed out changeset b8057c06fc4c (bug 1439960)
Backed out changeset c8d6b0fa1447 (bug 1439960)
Backed out changeset e6bd6ebc8597 (bug 1439960)
2018-03-20 23:18:44 +02:00
Ryan Hunt
df90830506
Remove DisplayItemLayer and corresponding layers.advanced prefs. (bug 1439960, r=mstange)
...
MozReview-Commit-ID: FAWTC1Llu31
2018-02-21 09:29:49 -06:00
Matt Woodrow
6f1864699b
Bug 1436904 - Part 1: Add a static constructor function for display items. r=Bas
2018-02-13 13:43:28 +13:00
Dorel Luca
44cad57ea9
Merge mozilla-central to autoland
2018-02-22 17:35:26 +02:00
Dorel Luca
3276af0faa
Backed out 3 changesets (bug 1436904) for many crashes see bugs: 1440281, 1440302, 1440303, 1440313. a=backout
...
Backed out changeset 27f0762d4472 (bug 1436904)
Backed out changeset 27640f52e188 (bug 1436904)
Backed out changeset 2b4d117c27dc (bug 1436904)
2018-02-22 17:28:59 +02:00
Zhang Junzhi
87b58411bd
Bug 1259168 - Resolves the table cell misplacement problem when row group width exceeds table's computed width in vertical-rl writing mode r=jfkthame
...
A table's used width may be different with its computed width. In the past, this
situation wasn't taken into account in process of table reflow, this patch
corrects the positioning of children of a table in this situation.
MozReview-Commit-ID: 4siu2ba0pqG
2018-02-22 14:32:40 +08:00
Matt Woodrow
2bcbca93c9
Bug 1436904 - Part 1: Add a static constructor function for display items. r=Bas
2018-02-13 13:43:28 +13:00
Boris Zbarsky
41c46ec098
Bug 1418085 part 6. Remove nsIDOMHTMLElement. r=mystor
...
MozReview-Commit-ID: 5QUyFeAQYZQ
2018-01-30 00:25:36 -05:00
Morris Tseng
6ff1c5f27a
Bug 1393907 - Handle bevel borders. r=kats
...
Since bevel only appear outmost border of table. I collect all bevel border
and combined them as a single border with four sides.
MozReview-Commit-ID: Bvu8Zf56YDF
2018-01-24 08:46:10 -05:00
Andrea Marchesini
8d41475807
Bug 1430997 - Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb
2018-01-23 14:30:18 +01:00
Ya-Chieh Wu
c0f32f54d8
Bug 1429313 - Reuse nextColIndex to avoid extra BCMapCellInfo::GetCellEndRowIndex() calls. r=tylin
...
MozReview-Commit-ID: 9gbVQNSKl7l
2018-01-10 01:11:00 -05:00
Ya-Chieh Wu
73b4e27c3b
Bug 1421887 - fix the row index to get the right cell. r=dbaron
...
MozReview-Commit-ID: 4wIdFxeETiW
2018-01-04 21:28:00 +02:00
Miko Mynttinen
896b0f3d84
Bug 1425078 - Remove nsDisplayList::AppendNewToTop and nsDisplayList::AppendNewToBottom r=mattwoodrow
...
MozReview-Commit-ID: E3neKT2sV4Q
2017-12-13 11:23:04 -06:00
Ya-Chieh Wu
09a50d2b16
Bug 1405929 - Make sure that we join two BEnd borders when they are on the same rowIndex. r=dbaron
...
MozReview-Commit-ID: J9q8sUX2MPB
2017-11-30 19:18:00 +02:00
Mats Palmgren
917be0a687
Bug 1414666 part 2 - A few formatting improvements after mass conversion of PresContext()->PresShell() to PresShell(). r=emilio
...
MozReview-Commit-ID: FoEnINS0Jbk
2017-11-09 03:00:48 +01:00
Mats Palmgren
2544eb586c
Bug 1414666 part 1 - Add nsIFrame::PresShell() for convenient access to the shell. r=emilio
...
MozReview-Commit-ID: 8FPTPKWyVtY
2017-11-09 03:00:48 +01:00
Mats Palmgren
616f910f82
Bug 1400618 part 1 - Collect NAC / generated content and call DestroyAnonymousContent / UnbindFromTree on those after the frames are destroyed. r=bz
...
MozReview-Commit-ID: 2trDgeJPw25
2017-11-07 01:20:33 +01:00
Boris Zbarsky
b338a9349a
Bug 1409787. Guard against empty column groups when building a display list for a table. r=mats
...
MozReview-Commit-ID: E31B1wqNbSu
2017-10-19 18:06:43 -04:00
Sebastian Hengst
44e618ee22
merge mozilla-central to mozilla-inbound. r=merge a=merge
2017-10-18 00:05:25 +02:00
Boris Zbarsky
909ee9255d
Bug 1409152. Add an nsTArray::ContainsSorted method. r=froydnj
2017-10-17 15:39:59 -04:00
Boris Zbarsky
e660a61cfe
Bug 1409162. Make nsTableCellFrame::GetColIndex/GetRowIndex faster. r=mats
2017-10-17 15:39:36 -04:00
Boris Zbarsky
39a54045cb
Bug 1409154. Do less work in PaintRowGroupBackgroundByColIdx for cells that are not in our desired set of columns. r=mats
2017-10-17 15:39:28 -04:00
Ethan Lin
191574f9d8
Bug 1405957 - Part2. Remove the unnecessary GetLayerState in CreateWebRenderCommands and adjust the related pref type/value. r=kats
...
MozReview-Commit-ID: E8JvuOj6JtL
2017-10-05 14:42:28 +08:00
Cameron McCormack
b8dd60db88
Bug 1407246 - Split out Variables struct difference calculation. r=emilio
...
MozReview-Commit-ID: CtWtG3zkD1D
2017-10-12 09:12:30 +08:00
Kartikaya Gupta
7c1da03e1c
Bug 1403915 - Remove the WebRender*Layer classes and functions that refer to them. r=jrmuizel
...
MozReview-Commit-ID: 2syFwMc7j3r
2017-10-03 16:31:08 -04:00