Byron Campen [:bwc]
1bd837d560
Bug 1383019: Move more logic under the protection of nsTimerImpl::mMutex, and simplify. r=froydnj, a=abillings
...
MozReview-Commit-ID: JjYScKwyika
2017-09-14 12:19:24 -05:00
Stone Shih
f3f46de2fa
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
Stone Shih
c05570954b
Backed out changeset 37c9e9d07aac (bug 1351148)
2017-08-11 15:19:51 +08:00
Stone Shih
b616cb3cc9
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
Carsten "Tomcat" Book
01d32e38ae
Backed out changeset 420d9e53c959 (bug 1351148) for causing regressions / on request from stone
2017-07-28 09:20:54 +02:00
Stone Shih
b38e4d9094
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
Ben Kelly
870fde6695
Bug 1363829 P12 Expose nsITimer::InitHighResolutionWithCallback() method. r=froydnj
2017-05-31 17:13:19 -07:00
Andreas Farre
4cb28e7f9e
Bug 1311425 - Make idle callbacks aware of nsITimers, r=froydnj
2017-05-24 21:12:55 -04:00
Byron Campen [:bwc]
c3957680f9
Bug 1361100: Perform all timer init after removal from TimerThread. r=froydnj
2017-05-01 14:50:37 -05:00
Ben Kelly
49876dbfd4
Bug 1325254 P5 Make nsITimer::Cancel() O(c). r=froydnj
2017-04-20 17:56:07 -04:00
Byron Campen [:bwc]
634a408d10
Bug 1339588 - Part 3: Don't break the nsTimer/nsTimerImpl cycle during Fire. r=froydnj, a=dveditz
...
MozReview-Commit-ID: J6TNJqGsBv4
2017-04-06 12:29:57 -05:00
Jeff Walden
d51e1f4d84
Bug 1338374 - Use alignas/alignof to define Variant's internal raw storage. r=froydnj
2017-01-30 15:56:05 -08:00
Byron Campen [:bwc]
c6db5a598c
Bug 1328643: Add some locking to prevent races caused by Cancel/Init from threads other than the target. r=froydnj
...
MozReview-Commit-ID: FdAPTGDNKup
2017-01-11 13:59:19 -06:00
Bill McCloskey
9f4f527e1e
Bug 1320753 - Adding nsINamed naming to nsITimer (r=ehsan)
...
MozReview-Commit-ID: AbyLcMhRvbx
2016-11-30 18:01:59 -08:00
Byron Campen [:bwc]
afbcf4c202
Bug 1157323 - Part 6: Some comment improvements. r=froydnj
...
MozReview-Commit-ID: GDLuJS0Wlgh
2016-08-05 13:46:07 -05:00
Byron Campen [:bwc]
f5fdbe93cc
Bug 1157323 - Part 5: Remove some unnecessary members. r=froydnj
...
MozReview-Commit-ID: Fhkq0CZoqQP
2016-08-05 13:39:34 -05:00
Byron Campen [:bwc]
dc4ed15132
Bug 1157323 - Part 4: Stop modifying mTimeout/mDelay from the TimerThread, plus some simplification. r=froydnj
...
MozReview-Commit-ID: 1pMCKLi9DLZ
2016-08-05 12:50:00 -05:00
Byron Campen [:bwc]
624a10a269
Bug 1157323 - Part 2: Factor nsTimerImpl into two classes, so we don't need to do racy stuff in nsTimerImpl::Release. r=froydnj
...
MozReview-Commit-ID: DAe4TpMqBpA
2016-07-20 15:16:40 -05:00
Eric Rahm
ef2af5437e
Bug 1174785 - Part 2: Convert xpcom over to LogModule. r=froydnj
2015-10-19 12:50:14 -07:00
Nicholas Nethercote
3ddf3a726a
Bug 1203427 (part 5) - Add logging of timer firings. r=froydnj.
2015-09-10 00:50:51 -07:00
Nicholas Nethercote
55eb68280a
Bug 1203427 (part 3) - Change order of InitCommon() arguments. r=froydnj.
...
This makes the order of |aDelay| and |aType| match those of the InitWith*()
functions.
I've made this change because the inconsistency tripped me up during the
development of part 4.
2015-09-14 15:57:17 -07:00
Byron Campen [:bwc]
d451c034c5
Bug 1059572 - Part 1: Move PostTimerEvent to TimerThread to allow TimerThread's monitor to protect it. r=nfroyd
2015-07-22 12:39:34 -05:00
Nathan Froyd
73bc27cf89
Bug 1178363 - make nsTimerImpl::GetGeneration a private method; r=poiru
...
Since GetGeneration() is only called by nsTimerEvent, it doesn't need to
be public.
2015-06-29 13:09:11 -04:00
Nathan Froyd
bf2762e982
Bug 1178363 - make nsTimerImpl::PostTimerEvent a private method; r=poiru
...
PostTimerEvent is only called by the timer thread, which is already able
to access private members of nsTimerImpl; there's no reason for
PostTimerEvent to be public.
2015-06-29 10:33:30 -04:00
Nathan Froyd
86db960c48
Bug 1178363 - make MOZ_TASK_TRACER-dependent bits of nsTimerImpl private; r=poiru
...
GetTracedTask() is only called from nsTimerImpl itself, so it doesn't
need to be public. GetTLSTraceInfo() is called from the timer thread,
which has access to our private members already.
2015-06-18 12:02:23 -04:00
Nathan Froyd
1acb6da64b
Bug 1178363 - make nsTimerImpl::Fire a private method; r=poiru
...
This method is only called by nsTimerEvent, which is an implementation
detail of nsTimerImpl.
2015-06-18 12:00:56 -04:00
Nathan Froyd
21095ced70
Bug 1178363 - make nsTimerImpl::SetDelayInternal a private method; r=poiru
...
Nothing outside nsTimerImpl uses it, and with a name like
"SetDelayInternal", nothing should.
2015-06-17 21:40:18 -04:00
Shelly Lin
674494b7ef
Bug 1113562 - Expected delay time of tasks should not be the latency of those kind. r=sinker
2015-06-16 10:57:19 +08:00
Michael Layzell
d806d4a64b
Bug 1168170 - Mark reference counted members of nsTimerImpl::mCallback as MOZ_OWNING_REF. r=froydnj
2015-05-28 10:14:00 -04:00
Eric Rahm
ddc8ac650b
Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj
2015-05-19 11:15:34 -07:00
Eric Rahm
29bb46c307
Bug 1162242 - Part 2: Remove DEBUG_TIMERS. r=froydnj
...
Now that PR_LOGGING is always defined DEBUG_TIMERS will always be set. It can
now be removed.
2015-05-07 09:43:36 -07:00
Eric Rahm
f401b05aca
Bug 1162242 - Part 1: Remove instances of #ifdef PR_LOGGING. r=froydnj
...
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-07 09:43:35 -07:00
Nathan Froyd
09d1dd5f7e
Bug 1156407 - part 3 - get rid of NS_NewTimer; r=mccr8
...
It's never called. We could replace a few do_CreateInstance/InitWithFuncCallback
pairs with NS_NewTimer, but I don't think it's worth doing that ahead of a "stop
using do_CreateInstance for all timer instances" effort.
2015-04-20 14:21:01 -04:00
Nathan Froyd
d544b0c534
Bug 1156407 - part 2 - make CALLBACK_TYPE enum a private implementation detail of nsTimerImpl; r=mccr8
...
The CALLBACK_TYPE enum doesn't need to be exposed outside of
nsTimerImpl, so move it inside the class definition. While we're doing
this, let's C++-ify the enum definition and give the members
non-shouting names.
2015-04-20 14:08:57 -04:00
Nathan Froyd
955b71f629
Bug 1156407 - part 1 - use static_assert instead of PR_STATIC_ASSERT; r=mccr8
...
We have better, C++-ier ways of doing compile-time assertions now. Fold in the
nsTSubstring.cpp change in passing, since mccr8 suggested it in his review.
2015-04-20 13:56:46 -04:00
Ehsan Akhgari
ea41d8de48
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Ehsan Akhgari
ad34fcfc86
Bug 1117035 - Mark virtual overridden functions as MOZ_OVERRIDE in XPCOM; r=froydnj
2015-01-05 11:25:41 -05:00
Gina Yeh
628b98a12a
Bug 1089514, Patch 1: Some traced tasks/runnables have record of dispatch, but no records of execution, r=thinker.
...
---
tools/profiler/TracedTaskCommon.cpp | 19 +++++--------------
tools/profiler/TracedTaskCommon.h | 12 ++++++++----
xpcom/threads/TimerThread.cpp | 2 ++
xpcom/threads/nsTimerImpl.cpp | 3 +++
xpcom/threads/nsTimerImpl.h | 2 +-
5 files changed, 19 insertions(+), 19 deletions(-)
2014-11-04 17:42:03 +08:00
Eric Rahm
b8709b7dc6
Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan
2014-10-08 13:17:32 -07:00
Wes Kocher
e9f3c5a025
Backed out 5 changesets (bug 806819) for WinXP test failures on a CLOSED TREE
...
Backed out changeset 009ae35b0c67 (bug 806819)
Backed out changeset 5a57f87f5061 (bug 806819)
Backed out changeset f06cd735b5b3 (bug 806819)
Backed out changeset e25a2a8d4af4 (bug 806819)
Backed out changeset 70a167982c3f (bug 806819)
2014-10-06 16:32:50 -07:00
Eric Rahm
e037820a94
Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan
2014-10-06 13:08:20 -07:00
Birunthan Mohanathas
da27cbd66f
Bug 1046841 - Fix more style violations in previously touched .h files in xpcom/. r=froydnj
2014-08-25 12:17:24 -07:00
Birunthan Mohanathas
8a4a4c8465
Bug 1022456 - Fix modelines in xpcom/{base,glue,io,string,threads}/. r=froydnj
2014-06-30 08:39:45 -07:00
Byron Campen [:bwc]
e0f2e59133
Bug 1024765 - Part 2: Make refcounting logic around PostTimerEvent more explicit. r=bz
2014-06-16 14:13:04 -07:00
Jonathan Watt
fb3412c7d4
Bug 1016680, part 5 - Report the memory used by PresShell::mCaret. r=dbaron
2014-06-22 23:02:59 +01:00
Robert O'Callahan
2c1ab3f641
Bug 1015664. Part 1: Remove NS_HIDDEN_() usage. r=bsmedberg
2014-06-03 00:08:21 +12:00
Birunthan Mohanathas
a108f37fc2
Bug 995730 - Convert xpcom/threads/ to Gecko style. r=froydnj
2014-05-27 10:15:35 +03:00
Shelly Lin
630f445fd9
Bug 908995 - Part 2: Track runnables, tasks and timer events with TaskTracer. r=khuey.
2014-03-27 16:49:06 +08:00
Joshua Cranmer
1c073a2540
Bug 884061 - Part 3y: Use NS_DECL_THREADSAFE_ISUPPORTS in xpcom/, r=bsmedberg
2013-07-18 21:31:26 -05:00
Daniel Holbert
d3e7951817
Bug 849086: Remove unused *_CLASSNAME defines. r=bsmedberg
2013-03-15 10:52:10 -07:00