Nika Layzell
b4c313c43d
Bug 1437167 - Part 1: Stop using PRIntervalTime as the argument to CondVar::Wait and Monitor::Wait, r=mstange, r=froydnj
2018-04-10 17:49:47 -04:00
Nathan Froyd
247591cb6c
Bug 1447744 - don't implement nsINamed for mozilla::Runnable when it's unused; r=erahm
...
We only use nsINamed on runnables for certain kinds of telemetry, and
those kinds of telemetry aren't being gathered on RELEASE_OR_BETA
builds. We effectively make nsINamed::GetName a no-op when we're not
collecting said telemetry. But implementing nsINamed does have a cost:
the vtable of every runnable (and we have hundreds of subclasses of
mozilla::Runnable) will contain pointers for GetName (and extra pointers
for QueryInterface/AddRef/Release), and all those pointers times all
those subclasses adds up quickly. Let's not implement nsINamed when
nsINamed isn't going to be used.
This change saves ~100K of binary size on x86-64 Linux; the savings
should be similar on other 64-bit systems, and ~50K on 32-bit systems.
2018-03-23 14:53:55 -04:00
Miko Mynttinen
86800aa3f1
Bug 1445302 - Replace TArray.RemoveElementAt(TArray.Length() - 1) pattern with TArray.RemoveLastElement() or TArray.PopLastElement() r=froydnj
...
MozReview-Commit-ID: rGjabnP2iz
2018-03-13 14:51:33 +01:00
Byron Campen [:bwc]
1bd837d560
Bug 1383019: Move more logic under the protection of nsTimerImpl::mMutex, and simplify. r=froydnj, a=abillings
...
MozReview-Commit-ID: JjYScKwyika
2017-09-14 12:19:24 -05:00
Bill McCloskey
ce42826bdf
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
238bf154d5
Backed out changeset 4f6302a98ae4 (bug 1372405)
2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993
Backed out changeset 9846de3bd954 (bug 1372405)
2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Olli Pettay
873244fbc2
Bug 1371438, investigate why assertion fails on Windows, r=bkelly
2017-06-10 03:21:29 +03:00
Olli Pettay
ee9725c9ea
Bug 1368493, TimerThread::FindNextFireTimeForCurrentThread should look at timers in order, r=bkelly
2017-06-05 16:49:54 +03:00
Ben Kelly
7881166288
Bug 1363829 P15 Expose nsITimer::GetAllowedEarlyFiringMicroseconds(). r=froydnj
2017-05-31 17:13:20 -07:00
Olli Pettay
79f1db3813
Bug 1311425, review comment fix to ensure low priority timers aren't taken into account when calling NS_GetTimerDeadlineHintOnCurrentThread, r=smaug
2017-05-26 09:13:39 -04:00
Andreas Farre
4b87c2026c
Bug 1311425 - Add pref for how far into the timer queue, r=smaug,f=froydnj
2017-05-24 21:14:29 -04:00
Andreas Farre
4cb28e7f9e
Bug 1311425 - Make idle callbacks aware of nsITimers, r=froydnj
2017-05-24 21:12:55 -04:00
Byron Campen [:bwc]
04b0c62914
Bug 1361098: Simplify TimerThread::Init some. r=froydnj
2017-05-01 13:42:11 -05:00
Cervantes Yu
6bcb4f30a4
Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto
...
NS_SetCurrentThreadName() is added as an alternative to PR_SetCurrentThreadName()
inside libxul. The thread names are collected in the form of crash annotation to
be processed on socorro.
MozReview-Commit-ID: 4RpAWzTuvPs
2017-02-07 18:57:23 +08:00
Ben Kelly
49876dbfd4
Bug 1325254 P5 Make nsITimer::Cancel() O(c). r=froydnj
2017-04-20 17:56:07 -04:00
Ben Kelly
27eb26aba7
Bug 1325254 P4 Dynamically allocate Entry structs stored in TimerThread::mTimers. r=froydnj
2017-04-20 17:56:07 -04:00
Ben Kelly
71a579a325
Bug 1325254 P3 Sort TimerThread list as a binary heap. r=froydnj
2017-04-20 17:56:07 -04:00
Ben Kelly
e89f762f67
Bug 1325254 P2 Make TimerThread list store an entry struct and just drop nsTimerImpl ref on cancel. r=froydnj
2017-04-20 17:56:07 -04:00
Ben Kelly
b0925d56cf
Bug 1325254 P1 Make TimerThread::mTimers store RefPtr<nsTimerImpl> objects. r=froydnj
2017-04-20 17:56:06 -04:00
Sebastian Hengst
189424cb45
Backed out changeset 7fdcabdbb675 (bug 1024669) for failing mda, GTest and talos jobs. r=backout on a CLOSED TREE
2017-04-10 19:05:44 +02:00
Cervantes Yu
c2014c712d
Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto
...
MozReview-Commit-ID: 4RpAWzTuvPs
2017-02-07 18:57:23 +08:00
Carsten "Tomcat" Book
e6d6caf1f8
Backed out changeset 7a52d887bcea (bug 1024669) for bustage
2017-04-10 11:43:49 +02:00
Cervantes Yu
eb13868db5
Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto
...
MozReview-Commit-ID: 4RpAWzTuvPs
2017-02-07 18:57:23 +08:00
Eric Rahm
68b43577c0
Bug 1351732 - Part 2: Replace use of PLArena with ArenaAllocator in xpcom. r=froydnj
...
This swaps xpcom's plarena usage to ArenaAllocator. The new ArenaStrdup
extensions are used as well.
MozReview-Commit-ID: DHDfl6IkGJL
2017-03-30 16:46:58 -07:00
Byron Campen [:bwc]
fa83d433b9
Bug 1339588 - Part 1: Simplify nsTimerEvent::Cancel, since there's no need to release the nsTimerImpl itself. r=froydnj
...
MozReview-Commit-ID: 6br6DaDqxR0
2017-02-14 15:29:01 -06:00
Byron Campen [:bwc]
c6db5a598c
Bug 1328643: Add some locking to prevent races caused by Cancel/Init from threads other than the target. r=froydnj
...
MozReview-Commit-ID: FdAPTGDNKup
2017-01-11 13:59:19 -06:00
Markus Stange
a24593a89f
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
2016-12-21 11:43:50 +01:00
Bill McCloskey
9f4f527e1e
Bug 1320753 - Adding nsINamed naming to nsITimer (r=ehsan)
...
MozReview-Commit-ID: AbyLcMhRvbx
2016-11-30 18:01:59 -08:00
Byron Campen [:bwc]
b3bef05d45
Bug 1307350: Compensate for repeating timers that have not been appropriately cancelled. r=froydnj
...
MozReview-Commit-ID: 20VpLbgSjh4
2016-10-04 10:23:39 -05:00
Byron Campen [:bwc]
958b04132a
Bug 1310925: Acquire a reference before unlocking, just in case. r=froydnj
...
MozReview-Commit-ID: BLExeLU8AFs
2016-10-18 09:42:13 -05:00
Byron Campen [:bwc]
b4ae4438e1
Bug 1306733: Don't crash on release builds if mTimer isn't set here. r=froydnj
...
MozReview-Commit-ID: eupSpSpJU3
2016-09-30 16:42:45 -05:00
Byron Campen [:bwc]
f5fdbe93cc
Bug 1157323 - Part 5: Remove some unnecessary members. r=froydnj
...
MozReview-Commit-ID: Fhkq0CZoqQP
2016-08-05 13:39:34 -05:00
Byron Campen [:bwc]
dc4ed15132
Bug 1157323 - Part 4: Stop modifying mTimeout/mDelay from the TimerThread, plus some simplification. r=froydnj
...
MozReview-Commit-ID: 1pMCKLi9DLZ
2016-08-05 12:50:00 -05:00
Byron Campen [:bwc]
c2bcb35570
Bug 1157323 - Part 3: Do not allow mTimeout to change while a timer is in the queue. r=froydnj
...
MozReview-Commit-ID: 3ZyikUsix8D
2016-08-05 10:07:38 -05:00
Alexandre Lissy
b2834a3543
Bug 1284674 - Remove NUWA r=cyu
...
MozReview-Commit-ID: GyMRNzOBKw6
2016-08-02 14:54:00 +02:00
Nathan Froyd
cdd93ec8fb
Bug 1283151 - make nsTimerEvent final; r=tbsaunde
...
Nothing should be deriving from nsTimerEvent, and perhaps this will make
some of the timer code slightly more efficient.
2016-06-29 19:44:03 -04:00
L. David Baron
edcdccaa9b
Bug 1271182 - Remove MOZ_COUNT_[CD]TOR from nsTimerEvent, since it uses XPCOM reference counting macros. r=khuey
...
I suspect this will fix the odd behavior we're seeing, although I
haven't really thought through how very closely.
MozReview-Commit-ID: qHgBRAc1PE
2016-05-25 18:04:36 -07:00
L. David Baron
9d8500a797
Bug 1271182 - Add some deleted assignment operators and copy constructors. r=khuey
...
These are generally good practice for reference-counted objects; they
catch cases where these operations are used by accident, breaking
reference-counting.
This doesn't show any existing problems, though.
MozReview-Commit-ID: EvRkNCymOqT
2016-05-25 18:04:35 -07:00
Kyle Huey
a9cf047227
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
Kyle Huey
1f6993705a
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
Kyle Huey
a256ae1a91
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Wes Kocher
dd9b334d33
Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE
...
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)
MozReview-Commit-ID: LPEa05QobdQ
2016-04-11 12:50:56 -07:00
Kyle Huey
7a575c886c
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
Kyle Huey
41c353f8e9
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
Mike Conley
27f9186d07
Bug 1221846 - Get Task Tracer building on desktop r=cyu.
2015-12-02 20:55:38 -05:00
Andrea Marchesini
06ada61f9a
Bug 901097 - FileReader API in workers, r=sicking, r=nfroyd
2015-12-18 08:44:00 +00:00
Sebastian Hengst
012bf5fb95
Backed out changeset 30839ee209e8 (bug 901097) for mochitest failures on Android and Mulet. r=backout
2015-12-17 14:13:59 +01:00