Commit Graph

83 Commits

Author SHA1 Message Date
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cameron McCormack
5bbb806236 Bug 1427419 - Part 24: Move pseudo-class lock methods from inIDOMUtils to InspectorUtils. r=bz
MozReview-Commit-ID: ItruGMmf5Ih
2018-01-11 12:38:01 +08:00
Cameron McCormack
78ffaf7e6d Bug 1427419 - Part 21: Move content state methods from inIDOMUtils to InspectorUtils. r=bz
MozReview-Commit-ID: KfrUdNU4as3
2018-01-11 12:38:01 +08:00
btian
d31a19a4c0 Bug 1296264 - Part 2: Do not fire mouse events when user closes <select> popup by clicking outside. r=mconley 2017-10-18 14:36:49 +08:00
btian
3a48eba4ca Bug 1296264 - Part 1: Fire mouse events on <select> element no matter selected option changes or not. r=mconley 2017-10-05 16:12:47 +08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Peter Van der Beken
9267cac669 Bug 1391118 - xslt-generated select tag pull-down does not respond to clicks. r=jaws 2017-08-22 14:23:33 +02:00
Felipe Gomes
4dc64b5cd5 Bug 1383205 - Update transitionend properties of <option> elements on a deferred task. r=jaws
Also, we only care about the properties that we support and that are animatable, as the non-animatable ones do not generate transitionend events

MozReview-Commit-ID: 5KZvJeGwfP3
2017-07-30 23:06:29 -03:00
Ben Tian
bbf4df3f37 Bug 1351072 - [e10s] Clear active document when closing popup of <select>. r=smaug
MozReview-Commit-ID: IaRG67FwIPL
2017-06-14 13:42:03 +08:00
L. David Baron
c7c7849805 Bug 1367505 - Set and clear pseudo-class locks all at once to avoid restyle thrashing when sending select options to parent process. r=jaws
This removes nearly half of the time spent in the child process pause in
bug 1118086.  (On my laptop, it cuts the child process pause from about
1560ms to 860ms; the parent process pause is still just over 5 seconds.)

Using querySelectorAll to find only the options that need to be locked
is much faster than iterating over them and locking all of them both
because the iteration is slow and the locking is somewhat slow even when
it's a no-op.

MozReview-Commit-ID: 17h3WIt9c2O
2017-05-24 18:25:39 -04:00
Jared Wein
024ba531f3 Bug 1343569 - Delay hiding the popup on blur if the search field gains focus. r=enndeakin+6102
Since the order of events is 'blur' followed by 'focus', we send a message from the content process to the parent process and wait for a reply to give enough time for the parent process to signal that the 'blur' was related to the focusing of the search field. If the parent process hasn't signaled as such, then the content process will proceed with hiding the dropdown.

MozReview-Commit-ID: 6ngoo9uHcsM
2017-04-25 20:19:42 -04:00
Jared Wein
ffb4cdda2c Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling. r=mossop
MozReview-Commit-ID: 3jzZOIiJyXT
2017-04-10 16:03:03 -04:00
Jared Wein
aca12ccaa3 Bug 1352963 - Update the styling of the select popup after transitionend. r=mossop
MozReview-Commit-ID: 5WuRvMDYahZ
2017-04-03 22:52:16 -04:00
Jared Wein
61904581e9 Bug 1350670 - Extend the MutationObserver to cover attributes in case the page sets styles through style, class, ID or other attributes. r=mossop
MozReview-Commit-ID: 3tYjbqH9zYb
2017-03-29 12:47:13 -04:00
Phil Ringnalda
5394650534 Backed out changeset adf939cb9b0b (bug 1350670) for Mac and Windows browser_selectpopup_colors.js failures
CLOSED TREE
2017-03-28 19:37:49 -07:00
Jared Wein
cbf185c213 Bug 1350670 - Extend the MutationObserver to cover attributes in case the page sets styles through style, class, ID or other attributes. r=mossop
MozReview-Commit-ID: 3tYjbqH9zYb
2017-03-28 17:04:32 -04:00
Jared Wein
8dee2b77a2 Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation. r=mossop
MozReview-Commit-ID: D0WZU6wFctG
2017-03-28 15:43:33 -04:00
Jared Wein
86ce1a312b Bug 1349701 - Update the styles of <select> popups on focus. r=mossop
This patch also fixes a bug in our UpdateDropDown code where we weren't computing updated styles for <select> element, as well as another bug where we weren't passing the correct number of arguments to this.populate.

MozReview-Commit-ID: 8LAeIliRXhZ
2017-03-23 13:34:21 -04:00
Jared Wein
dc32b9ca7e Bug 1348617 - Use the alpha channel of custom styled select backgrounds by applying the requested color on top of the system's background. r=mossop
This matches parity with Google Chrome Canary Version 59.0.3046.0 (Official Build) canary (64-bit).

MozReview-Commit-ID: 3rkhiFv8ezX
2017-03-21 10:51:40 -04:00
Jared Wein
09d35cb1fa Bug 1346440 - Force the user-agent styles to apply when sampling the colors. r=mossop
Styles defined by the pages were getting applied to the dummy option and select, causing the wrong colors to be reported as the user-agent defaults.

MozReview-Commit-ID: 6rQy71hwzy6
2017-03-13 15:01:25 -04:00
Neil Deakin
7e25693319 Bug 1334155, close popup when select element is blurred, r=jaws 2017-02-09 11:28:22 -05:00
Jared Wein
43e67c7c8c Bug 1336301 - Styles that are applied directly to the select element should be forwarded to the popup. r=mconley
MozReview-Commit-ID: 29DjcUUqEkx
2017-02-04 00:33:13 -05:00
Jared Wein
e12169bf6e Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley
MozReview-Commit-ID: 8wqclzJr2si
2017-01-31 15:58:27 -05:00
Wes Kocher
8973294639 Backed out changeset 88872e0b68d2 (bug 1335483) for failures in browser_selectpopup.js a=backout
MozReview-Commit-ID: 39EV3LzTBiI
2017-02-03 11:54:32 -08:00
Jared Wein
1d335e9426 Bug 1335483 - Compare the user agent value for the select option styling to determine if content has opted-in to custom styling. r=mconley
MozReview-Commit-ID: 8wqclzJr2si
2017-01-31 15:58:27 -05:00
Jared Wein
eff6c54cb2 Bug 910022 - Allow websites to provide custom background colors and foreground colors for <select> popups. r=mconley
Portions of the patch were written by Jared Beach (beachjar@msu.edu)

MozReview-Commit-ID: 1SpUTJP8tPq
2017-01-30 17:35:14 -05:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Neil Deakin
80cfdcf004 Bug 1311279, when the mouse is released, check if it should be retargetted at the select element in the content process, so that a click event is received, r=mconley 2017-01-19 10:03:56 -05:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Mark Banner
dc46a8fba3 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
MozReview-Commit-ID: CiIsUjQzp4D
2016-11-09 22:06:32 +00:00
Neil Deakin
17743fa12c Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:56:43 -05:00
Carsten "Tomcat" Book
4a51e35bc2 Backed out changeset deec8c2ba931 (bug 1314647) for eslint failures 2016-11-17 15:42:59 +01:00
Neil Deakin
94b5ea1a03 Bug 1314647, clear active state of select on mouseup, r=mconley 2016-11-17 09:28:26 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Ryan VanderMeulen
650168c214 Merge inbound to m-c. a=merge 2016-10-23 13:16:27 -04:00
Jared Wein
a485808ad4 Bug 1311450 - Only show the 'touch' padding for the select dropdown when opened via touch. r=mconley,smaug
MozReview-Commit-ID: 521oAj1NzX7
2016-10-20 12:45:39 -04:00
Neil Deakin
bfb59f91a8 Bug 1309652, use computed display when determining option display values, r=felipe 2016-10-21 15:55:25 -04:00
Mike Conley
cb291759e9 Bug 1291078 - More closely mimic non-e10s order of events when choosing <select> elements in e10s mode. r=enndeakin+6102
MozReview-Commit-ID: 4CkFUy1nLbo
2016-08-02 15:09:59 -04:00
Neil Deakin
28758779ab Bug 1194027, add a flag to select elements to indicate if the parent process has the popup open, r=mrbkap 2016-08-03 07:45:46 -04:00
Neil Deakin
68d1763f98 Bug 1289528, don't fire click event when option selected with keyboard, r=mconley 2016-08-03 07:45:45 -04:00