Commit Graph

291 Commits

Author SHA1 Message Date
Boris Zbarsky
5575673cd0 Bug 1452329. Remove nsIDOMXMLDocument. r=mystor
MozReview-Commit-ID: LwbVo7Fx1SQ
2018-04-09 16:30:33 -04:00
Ed Lee
75bd9caa76 Bug 1449294 - Capture thumbnails with tracking protection always enabled. r=adw
MozReview-Commit-ID: Lt389lmJASW
2018-03-27 12:19:44 -07:00
Peter Van der Beken
d937bfceb7 Bug 1447705 - Make BackgroundPageThumbs._destroy actually called. Fix leak from BackgroundPageThumbs.jsm. r=kmag. 2018-02-26 17:48:35 +01:00
Kris Maglione
a7289e8164 Bug 1445551: Part 1c - Fix browser tests that attempt to use importGlobalProperties. r=mconley
When compartment-per-addon is disabled, browser mochitests will no longer
automatically run in an implicit Sandbox scope, which means that things like
Cu.importGlobalProperties will stop working.

MozReview-Commit-ID: AWloQ7gasEf
2018-03-13 18:18:27 -07:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
0f7796144a Bug 1440761 - Enable no-unused-vars for global scope on jsm files in toolkit/. r=mossop
MozReview-Commit-ID: 7Okqmw5dBcL
2018-02-23 19:25:59 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Nathan Watson
5d40195377 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc
2018-01-31 22:03:05 -08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Johann Hofmann
e6c0b3b0fe Bug 1167238 - Part 5 - Clean up sanitize.js usage in remaining tests. r=mak
This cleans up all tests that were not moved into the sanitize directory
as part of the previous commit, but still use sanitize.js

MozReview-Commit-ID: 1CVa0ByVYDk
2018-01-18 16:06:52 +01:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Anthony Ramine
d9baaff823 Bug 1431924 - Do not use URLParams::ParseInput in PageThumbsProtocol::ParseProtocolURL; r=bz
MozReview-Commit-ID: 79Pg9Vlq8Bu
2018-01-20 09:29:55 +01:00
Doug Thayer
5394d406e4 Bug 1421703 - replace onVisit with onVisits r=mak
There's a heavy enough overhead to going through XPConnect for
every observer for every visit on the nsINavHistoryObserver
interface, so this patch reduces that by replacing the single-
visit notification with one which accepts an array of visits.

Some notes: To avoid problems with the orderings of the various
ways in which we notify about visits, we have to send our bulk
onVisits notification before doing any of the others. This does
mean it technically behaves slightly different than the prior
approach of interleaving the notifications, but I can't find any
way in which this has any consequences to the end result, and it
doesn't break any tests.

MozReview-Commit-ID: GdeooH8mCkg
2017-12-20 14:27:24 -08:00
Valentin Gosu
88bf2bd0fd Bug 1426501 - Change C++ code to use NS_MutateURI when changing URI r=mayhemer
MozReview-Commit-ID: 4VzZlhWrtSJ
2018-01-08 15:20:35 +01:00
Florian Quèze
3f662053f3 Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Andreea Pavel
26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey
427710d960 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
81b4b85d01 Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
a0f07d3df7 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Mark Banner
becff57759 Bug 1409691 - Fix initialisation of doneReason in Capture (BackgroundPageThumbs.jsm). r=Mardak
MozReview-Commit-ID: G30XiYMScHr
2017-11-22 12:35:52 +00:00
JW Wang
ebd3a7bc7d Bug 1417869. P1 - Backed out changeset bf0e4dd83b3b of bug 1412505. r=adw,Mardak
MozReview-Commit-ID: KdxxwIsHZJS
2017-11-21 13:54:01 +08:00
Ed Lee
a8400c2356 Bug 1412505 - Background thumbnail request of go.twitch.tv strains CPU. r=adw
MozReview-Commit-ID: 9z20fvHMtcD
2017-11-13 16:09:00 -08:00
Ursula Sarracini
bd4fd952c9 Bug 1413650 - Capture loaded page instead of relying on background screenshot r=Mardak
MozReview-Commit-ID: FWToOSH8uL8
2017-11-07 17:33:44 -05:00
Margareta Eliza Balazs
597666b07b Backed out changeset 44f0f3508112 (bug 1413650) for eslint failure in /builds/worker/checkouts/gecko/toolkit/components/thumbnails/test/browser_thumbnails_bg_topsites.js:11:53 r=backout on a CLOSED TREE 2017-11-08 00:42:49 +02:00
Ursula Sarracini
3f18d928f8 Bug 1413650 - Capture loaded page instead of relying on background screenshot r=Mardak
MozReview-Commit-ID: 7O6c9uI6P8P
2017-11-07 16:48:07 -05:00
Mark Banner
6067ef1cb5 Bug 1412893 - Change instances of using getService to Services.jsm where possible in toolkit/components - Part 2. r=florian
MozReview-Commit-ID: 44oBXPP88Lc
2017-10-30 17:22:17 +00:00
Ursula Sarracini
a0c0d10efb Bug 1373258 - Convert PageThumbsProtocol.js to PageThumbsProtocol.cpp r=adw
MozReview-Commit-ID: tdNee2EPdV
2017-06-05 10:04:06 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Ursula Sarracini
2531f8001d Bug 1400562 - BackgroundPageThumbs.captureIfMissing leaks when hidden capturing_disabled pref is true r=Mardak
MozReview-Commit-ID: 6zb3uBCYTk5
2017-10-10 13:22:54 -04:00
Andrea Marchesini
792189dd57 Bug 1120178 - Migrate DOMError to DOMExtension in FileReader, IndexedDB, DOMRequest and so on, r=smaug 2017-08-06 20:47:00 +03:00
Kris Maglione
1ac293476d Bug 1399646: Part 1 - Destroy BackgroundPageThumbs instance at shutdown. r=Gijs
During extremely short sessions (such as the ones triggered by many tests),
the code run by BackgroundPageThumbs during shutdown can trigger
hard-to-diagnose issues, among the most serious being a deadlock in the
service worker registrar.

Calling the (currently unused) _destroy() method at the start of shutdown
seems to prevent the majority of these problems.

MozReview-Commit-ID: Go7OLzVM24G
2017-09-13 13:34:57 -07:00
ahillier
471446b851 Bug 1399200 - Don't stop loading thumbnail when image redirects r=Mardak
MozReview-Commit-ID: 1sADsZM6uYj
2017-09-12 14:07:33 -04:00
ahillier
6a467105bd Bug 1397390 - Support better thumbnails for image urls r=k88hudson,Mardak
MozReview-Commit-ID: Ksxo6Gj2rIO
2017-09-07 21:18:45 -04:00
Sebastian Hengst
6a22986845 Backed out changeset 4a955a640a52 (bug 1397390) for eslint failure at toolkit/components/thumbnails/PageThumbUtils.jsm:142: 'error' is not defined. r=backout 2017-09-07 23:59:05 +02:00
ahillier
651fd02ea7 Bug 1397390 - Support better thumbnails for image urls r=k88hudson,Mardak
MozReview-Commit-ID: Ksxo6Gj2rIO
2017-09-07 15:12:54 -04:00
Kirk Steuber
d9a2fae508 Bug 1348280 - Try to ensure thumbnail creation happens when the thread is idle r=markh
MozReview-Commit-ID: HoEb5J0QCyw
2017-08-16 13:24:22 -07:00
Masatoshi Kimura
747aea1659 Bug 938704 - Make OS.File support modern iterators. r=florian,Yoric
MozReview-Commit-ID: 8F1DtgakxM3
2017-08-19 15:04:13 +09:00
Perry Jiang
d391dd7ff6 Bug 1353584 - replace setTimeout with requestIdleCallback in _delayedCapture and return early on about: page in _shouldCapture. r=mconley
MozReview-Commit-ID: DaAcOTFBY6Q
2017-07-28 10:46:55 -07:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Ed Lee
1fe77cc83c Bug 1387682 - Screenshots missing when thumbnailer Promise is garbage collected. r=ursula
Properly clean up on unload from newTab.js to release strong references in the background thumbnailer.
MozReview-Commit-ID: IJNSYjwKUW3
2017-08-04 20:38:00 -07:00
Ed Lee
fe7df208a3 Bug 1387580 - Some top sites never get screenshots of redirected pages. r=adw
MozReview-Commit-ID: IzmzXhGnPcH
2017-08-05 00:34:25 -07:00
Masatoshi Kimura
0af76969af Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC
2017-08-04 17:49:22 +09:00
Geoff Brown
d1a55e2fed Bug 1314039 - Fix incorrect skip-if for browser_thumbnails_capture.js; r=me,test-only 2017-07-10 17:06:17 -06:00
Joel Maher
e86b104933 Bug 1314039 - Intermittent toolkit/components/thumbnails/test/browser_thumbnails_capture.js. temporarily disable on osx. r=gbrown
MozReview-Commit-ID: HJXMo89pJGd
2017-06-29 08:36:28 -04:00