Commit Graph

795 Commits

Author SHA1 Message Date
Gabriele Svelto
95ab44d7c1 Bug 1423715 - Add crash type keys to the crash manager histogram definitions; r=frank
This patch the list of process and crash types that can be recorded in a keyed
histogram by the crash manager; the relevant pattern was updated to match
these kesy. A test was also added to ensure that no new  crash types can be
added without also updating Histograms.json. This also fixes a related
existing test.

MozReview-Commit-ID: FKUZHd17a3V
2018-03-16 11:11:54 +01:00
Kris Maglione
7f6dd10ca6 Bug 1420908: Remove telemetry experiments. r=gfritzsche
MozReview-Commit-ID: 6KEEZ6nKXrU
2018-04-03 15:17:13 -07:00
Sebastian Hengst
3926a2643f merge mozilla-inbound to mozilla-central. a=merge 2018-04-12 22:20:13 +03:00
Chris H-C
fa2c77a132 bug 1452139 - Don't include cookies when posting Telemetry r=gfritzsche,franziskus
We don't need or want cookies sent to incoming.tmo. It just throws them on the
floor, but we needn't waste clients' bandwidth on it.

MozReview-Commit-ID: F9WjcDyKFGN
2018-04-12 09:50:40 -04:00
Chris H-C
8261db180b bug 1451333 - Convert last few Telemetry tests from generators to async r=Dexter
MozReview-Commit-ID: 2OtVsTFhDIF
2018-04-11 12:00:22 -04:00
Jan-Erik Rediger
e19ba9ed10 Bug 1450994 - Check for expected reason in payload. r=chutten
MozReview-Commit-ID: 48D449vIYgg
2018-04-11 09:58:00 -04:00
Chris H-C
c0fb2dfddc bug 1440673 - Test Event Summary's key limit pref r=Dexter
As requested, a test for the key limit pref.

This sets it to a value lower than the limit of events we can currently send
without truncation (100), but higher than is likely to be hit by tests (since
the first time we record an event, we read the pref, so we can't unsend it).

MozReview-Commit-ID: 7pGftCa1rz3
2018-04-03 18:32:53 -04:00
Chris H-C
a3c791329b bug 1440673 - Test Event Summarization in xpcshell r=Dexter
To test the TelemetryEvents portion of the code we need TelemetryEvents
tests. (The gtests only cover portions deeper than the TelemetryScalar API).

MozReview-Commit-ID: ExaiW0OiwFI
2018-04-03 14:38:51 -04:00
Jan-Erik Rediger
0da631208c Bug 1443600 - Remove legacy Telemetry component childPayloads r=chutten 2018-04-04 08:06:00 +03:00
Alessio Placitelli
50f5f1ff83 Bug 1450204 - Reset the ping id genrator after each test. r=chutten
MozReview-Commit-ID: UA6LWI0y67
2018-04-03 18:00:28 +02:00
Cosmin Sabou
b5fc3ab974 Merge inbound to mozilla-central. a=merge 2018-04-04 20:53:53 +03:00
Jan-Erik Rediger
d7e6592082 Bug 1443605 - Stop reporting legacy Telemetry component UITelemetry r=chutten 2018-04-03 02:34:00 +03:00
Chris H-C
3f94a518f5 bug 1450690 - Ensure extra_keys applies to more than just the first dynamic Telemetry Event r=Dexter,froydnj
(This is a partial revert of bug 1443587 part 2 where the `Move`s were added.)

When registering multiple methods and objects within the same `eventData` item,
we must copy the list of acceptable event keys into each new DynamicEventInfo.

Also includes a test.

MozReview-Commit-ID: 5PSH15nSWEB
2018-04-03 14:58:07 -04:00
Jan-Erik Rediger
d6213123f3 Bug 1443603 - Stop sending saved-session pings from Firefox Desktop r=chutten 2018-03-19 15:44:53 +01:00
Coroiu Cristina
cd70dce895 Merge mozilla-central to inbound a=merge on a CLOSED TREE 2018-03-27 01:33:50 +03:00
akriti
c5018a6ad5 Bug 972324 : Test for changes of the revision value in payloads , r=chutten
MozReview-Commit-ID: HaANh3cySNK
2018-03-23 22:29:44 +05:30
Aditya Bharti
4c45e24322 Bug 1442667 - Refactor internal_JSKeyedHistogram_Add r=chutten
Use the type checking utility function introduced in bug 1428893
Added more tests to increase code coveragea and ensure no regressions
2018-03-24 10:29:29 +05:30
Jan-Erik Rediger
f7bd649f34 Bug 1443608 - Stop reporting legacy Telemetry component Telemetry Experiments. r=chutten 2018-03-20 14:45:30 +01:00
Coroiu Cristina
603972ee16 Backed out changeset a8c4f87b7c3d (bug 1443605) for browser-chrome failures at browser/components/uitour/test/browser_UITour_registerPageID.js on a CLOSED TREE 2018-03-22 01:16:36 +02:00
Jan-Erik Rediger
5e8371cb61 Bug 1443614 - Stop reporting legacy Telemetry component Telemetry Log. r=chutten 2018-03-20 11:34:14 +01:00
Jan-Erik Rediger
aedd86279c Bug 1443605 - Stop reporting legacy Telemetry component UITelemetry. r=chutten 2018-03-20 14:22:52 +01:00
Kris Maglione
b4d543ffb2 Bug 1445551: Part 2 - Remove multiprocessCompatible flag. r=aswan
We no longer support legacy extensions with e10s shims, and the only remaining
uses that matter are in-tree test harnesses, which have been fixed. This flag
no longer serves a purpose.

MozReview-Commit-ID: EdCNqF4MttN
2018-03-13 19:02:42 -07:00
J. Ryan Stinnett
4271604996 Bug 1445386 - Use GreD for artifact build scalars. r=chutten
On macOS, the paths for the special directories `GreD` (Resources) vs. `GreBinD`
(MacOS) are different.  On other platforms, they are the same.

With scalar loading for artifact builds, we need to load a file from
`Resources`, so `GreD` should be used for this case.

MozReview-Commit-ID: 91JFwOISQCk
2018-03-12 19:24:30 -05:00
Kris Maglione
70769314ed Bug 1443642: Remove obsolete Addon.hasBinaryComponents flag. r=aswan
MozReview-Commit-ID: AlddwvjQmg1
2018-03-06 13:59:42 -08:00
Aaron Klotz
16aa025aba Bug 1434489: Add optional certSubject field to modules ping; r=chutten, data-review=francois (via bug 1430857) 2018-03-05 18:13:28 -07:00
Aditya Bharti
c1c7c6ee3d Bug 1428893 - Allow JSHistogram APIs to accumulate multiple values in one call. r=chutten
This patch adds support for value arrays to the internal_JSHistogram_Add method.

The histogram.add() js method can now be called with a single value or an array of values.
The accumulation is "all-or-nothing", i.e. if there is even a single invalid value in the
array, then nothing is accumulated.

The logic for type checking arguments before accumulation has been moved into a separate
function: internal_JSHistogram_CoerceValue. This function can also be used for
internal_JSKeyedHistogram_* methods in the future. This patch includes logic for clamping
values greater than UINT32_MAX to UINT32_MAX.

Added xpcshell tests in telemetry/tests/unit/test_TelemetryHistograms.js to check functionality.
2018-02-24 02:11:41 +05:30
Florian Quèze
5715aadbec Bug 1433175 - more aggressive scripted patch to replace remaining Components.classes, Components.interfaces, Components.utils and Components.results uses with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:35 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Alejandro Rodriguez
3fada46e52 Bug 1426139 - re-fetch only the relevant pref when a pref changes. r=chutten 2018-02-07 22:41:52 -05:00
Jared Wein
d5ab8bee00 Bug 1436575 - Manually fix the errors from no-compare-against-boolean-literal that the autofix couldn't change. r=standard8
MozReview-Commit-ID: 6NtfU76sPKv
2018-02-08 13:35:53 -05:00
Chris H-C
e6f1f01d10 bug 1437120 - Ensure pings sent after net shutdown are persisted to disk r=Dexter
bug 1397293 introduced a mechanism by which we would bail out early in trying
to send a ping if we were trying to send it after the network had been torn
down.

Unfortunately, it did so indistinguishably from the case where we weren't
allowed to send pings, so we neglected to save the ping (as "pending") and
just archived it.

This change cleanly rejects the ping, and correctly tests that the rejected
ping is persisted, not just ephemerally hanging in memory for but a few moments
longer.

MozReview-Commit-ID: 2g8cpeBEzSE
2018-02-13 15:52:28 -05:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Alessio Placitelli
eb7a868f0c Bug 1425909 - Enable adding scalars in artifact builds without rebuilding Firefox. r=chutten,froydnj
This patch enables generating a JSON file that mirrors the scalar definitions
in Scalars.yaml. On local developer builds, this file is loaded when Firefox
starts to register all the scalars. If some change was introduced in the
definition files, the new scalar will be dynamically added.
The JSON definition file will be regenerated every time an artifact build
is performed or the build faster command is invoked.

MozReview-Commit-ID: Do3WjE38aIK
2018-01-18 18:25:01 +01:00
Paul Bone
fffb026c20 Bug 1424760 (Part 7) - Don't insert an extra property into the GC telemetry r=Dexter
The properties limit was being exceeded because the telemetry code itself
added a num_slices property.  The GC already adds a slices property
(containing the number of slices) so I've fixed the issue by removing the
creation of the num_slices property, which will stop this limit from being
exceeded.
2018-02-01 22:24:26 +11:00
Mike Cooper
402ae54218 Bug 1434714 - Support Telemetry pings that are larger than 500,000 bytes after gzip r=gfritzsche
MozReview-Commit-ID: B1Bq5czcpdL
2018-01-31 13:05:21 -08:00
Andrew Swan
7b5e42ff82 Bug 1356331 Remove hotfix from telemetry r=chutten
MozReview-Commit-ID: GmNhsQnZ8Mh
2018-01-04 14:16:56 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Marco Castelluccio
024c8589bd Bug 1351197 - Re-enable TelemetryModules test on Android on Release and Beta. r=gfritzsche 2018-01-29 12:09:14 +01:00
Paul Bone
b9102e3777 Bug 1424760 (Part 6) - Fixup the regression in part 1 r=Dexter
I thought that I fixed an off-by-one error in part 1 of this patch series,
but I didn't, I introduced one.  I'm not sure why the original code didn't
work.

This patch also adds more testing (to avoid off-by-ones) and better logging
that may help if the original problem comes back.
2018-01-25 16:17:54 +11:00
Paul Bone
4096c008f6 Bug 1424760 (Part 5) - refactoring in test_TelemetryGC.js r=Dexter 2018-01-25 15:45:39 +11:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Andreea Pavel
7562acdf0e Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-01-16 11:52:04 +02:00
Paul Bone
43b94688d9 Bug 1424760 (Part 4) - Try to make GC telemetry pings more robust r=gfritzsche
+ Log limitProperties failures.
 + Don't remove all the properties from the main GC object, some are needed
   later, just reduce it to the 7 necessary properties.
2018-01-11 14:43:33 +11:00
Paul Bone
b9cd312703 Bug 1424760 (Part 3) - Add a TelemetryGC unit test r=gfritzsche
toolkit/components/telemetry/tests/unit/test_TelemetryGC.js:
toolkit/components/telemetry/tests/unit/xpcshell.ini:
    Add new unit test.

toolkit/components/telemetry/GCTelemetry.jsm:
    Add an extra method to make testing easier.

js/src/gc/Statistics.cpp:
    Add a reference to the unit test for anyone modifying this code.
2018-01-16 10:46:00 +11:00
Georg Fritzsche
65192db2de Bug 1429510 - Make last shutdown time a scalar. r=chutten 2018-01-15 13:22:56 +01:00
Aaron Klotz
2d4a8289fb Bug 1418131: Part 3 - Add Windows Security Center info to telemetry environment; r=gfritzsche
MozReview-Commit-ID: 3Cw7XIrROTn
2017-11-16 18:10:41 -07:00