Commit Graph

8 Commits

Author SHA1 Message Date
Gabriele Svelto
7ba85fd3ea Bug 1451288 - Do not force histogram keys to be valid C++ identifiers; r=Dexter
MozReview-Commit-ID: I8gxTgJrWwR
2018-04-04 13:31:18 +02:00
Andrew Halberstadt
3353b79e9c Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN
2018-01-31 14:32:08 -05:00
Alejandro Rodriguez
e4e7fae200 Bug 1422849 - Drop support for full display versions in Histograms.json, Scalar.yaml and Events.yaml. r=chutten 2018-01-24 19:36:12 -05:00
Margareta Eliza Balazs
9a5ad6de55 Backed out changeset 2b3180f034b0 (bug 1422849) for f8 lint failure in /builds/worker/checkouts/gecko/toolkit/components/telemetry/parse_histograms.py:319:14 on a CLOSED TREE 2018-01-24 17:26:14 +02:00
Alejandro Rodriguez
f708c645d1 Bug 1422849 - Drop support for full display versions in Histograms.json, Scalar.yaml and Events.yaml r=chutten 2018-01-23 19:09:32 -05:00
Aditya Bharti
e69637cc2c Bug 1424148 - Local duplicate of global constant used in function. r=chutten
Used the global variable CPP_IDENTIFIER_PATTERN instead of the local variable
'pattern' in check_name function in parse_histograms.py.
2017-12-19 13:56:39 +05:30
Aditya Bharti
cb63319c77 Bug 1401612 - Telemetry histogram validator now prints multiple error messages at a time. r=chutten
The histogram validator and other probe parsers printed a single error at a time and halted the build.
Extended the ParserError() class to support printing multiple errors at a time.
Changed the parse_histograms.py histograms validator and partitioned all ParserErrors into 'immediately fatal'
and 'eventually fatal'. Eventual errors are now accumulated and printed at one go upon exit.

Future work might involve changing the other probe parsers (scalars and events) to make use of the extended functionality.
2017-12-15 13:14:28 +05:30
Ryan Leake
d2b7f20af2 Bug 1419761 - Rename 'histogram_tools.py' to 'parse_histograms.py'. r=Dexter
MozReview-Commit-ID: J8wM1OZbMxd
2017-11-23 20:21:09 +00:00