Commit Graph

329 Commits

Author SHA1 Message Date
Mark Banner
29e56bce9b Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk
2018-03-06 12:01:59 +00:00
Masayuki Nakano
46555c3338 Bug 1434837 - Make autocomplete and satchel listen to keypress event at the system event group r=mak
The autocomplete module listens to keypress event for both printable keys and
non-printable keys a lot.  However, we'll stop dispatching keypress event for
non-printable keys in the default event group of web content.  So, autocomplete
should listen to keypress events at the system event group.

Note that it's difficult to change keypress event listeners to keydown event
listeners because if we stop keypress events at preceding keydown event in
autocomplete or satchel module, some other modules fail to handle keydown or
keypress event before autocomplete and it's not easy to investigate which
module's which keypress event listener should be changed to keydown event
listener.  Therefore, this patch doesn't do it at least for now.

MozReview-Commit-ID: 7e3aklmKrXu
2018-02-08 22:42:29 +09:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Masayuki Nakano
53a40055b6 Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK
2018-02-09 19:17:26 +09:00
Tom Ritter
5918a1f53d Bug 1435296 Address xpcshell test failures from increasing timer precision r=baku
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.

MozReview-Commit-ID: LrsucEPdZIo
2018-02-12 11:41:38 -06:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Masayuki Nakano
65ecb061b4 Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent() r=smaug
nsIDOMWindowUtils.sendKeyEvent() can dispatch any keyboard events, i.e.,
may dispatch different key events from actual Gecko's behavior.  Instead,
they should use nsITextInputProcessor directly or synthesizeKey() of
EventUtils which wraps nsITextInputProcessor.

MozReview-Commit-ID: EDWqXy1OxJp
2018-01-30 22:05:44 +09:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mike Conley
ee0816b4c9 Bug 888784 - Make satchel tests wait for FormHistory to be clear when shutting down. r=mak
MozReview-Commit-ID: 9rxyT48VnNj
2018-01-09 18:54:58 -05:00
Mike Conley
d173b25cfd Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak
MozReview-Commit-ID: EQBksMqeNm2
2017-11-30 17:00:07 -05:00
Narcis Beleuzu
293aa6f554 Backed out 14 changesets (bug 888784) for ESlint failure on /FormHistory.jsm. on a CLOSED TREE
Backed out changeset 8c3fc3cb35b7 (bug 888784)
Backed out changeset 4f1b033d3cc0 (bug 888784)
Backed out changeset 4f7816c12e0b (bug 888784)
Backed out changeset 456d0f3e4e34 (bug 888784)
Backed out changeset 5044e2244d17 (bug 888784)
Backed out changeset 8a44ddb5f2c2 (bug 888784)
Backed out changeset 9e70d1f4489e (bug 888784)
Backed out changeset a799d6cd42e4 (bug 888784)
Backed out changeset f33b9cc53b30 (bug 888784)
Backed out changeset dc3b1653e70c (bug 888784)
Backed out changeset 53cb7d7c71da (bug 888784)
Backed out changeset 5f88a6ef1aac (bug 888784)
Backed out changeset 291e111da6ef (bug 888784)
Backed out changeset b2682e434b20 (bug 888784)
2018-01-22 18:13:06 +02:00
Mike Conley
73f6d156bd Bug 888784 - Make satchel tests wait for FormHistory to be clear when shutting down. r=mak
MozReview-Commit-ID: 9rxyT48VnNj
2018-01-09 18:54:58 -05:00
Mike Conley
3b29c6b6d2 Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak
MozReview-Commit-ID: EQBksMqeNm2
2017-11-30 17:00:07 -05:00
Sebastian Hengst
92d31ee76f Backed out 9 changesets (bug 888784) for failing mochitest-bc browser_426329.js on Linux and on Android chrome's test_ext_browsingData_formdata.html and robocop's testFormHistory. r=backout on a CLOSED TREE
Backed out changeset 98722ab8c2f6 (bug 888784)
Backed out changeset d92599272745 (bug 888784)
Backed out changeset 67c58cb32ac9 (bug 888784)
Backed out changeset 46fb8f82f2bf (bug 888784)
Backed out changeset 73ad820d09ec (bug 888784)
Backed out changeset 18d185fa362e (bug 888784)
Backed out changeset 10c472d10264 (bug 888784)
Backed out changeset 51fb50c1ea68 (bug 888784)
Backed out changeset 80a207ed79ec (bug 888784)
2018-01-09 20:18:55 +02:00
Mike Conley
b7921244f5 Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak
MozReview-Commit-ID: EQBksMqeNm2
2017-11-30 17:00:07 -05:00
Florian Quèze
082ca8b2a3 Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Sean Lee
af49048c0b Bug 1406585 - Close the autocomplete popup when the crash of a content page or Message Manager disconnection happens. r=MattN
MozReview-Commit-ID: DjSc4R0WBQP
2017-11-10 17:00:33 +08:00
Edouard Oger
2b6aa00c6f Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
MozReview-Commit-ID: H7AmIBtFUOr
2017-11-06 15:50:28 -05:00
Narcis Beleuzu
a934667a54 Backed out 1 changesets (bug 1404427) for browser failures in browser_sanitize-timespans.js at some times of the day. r=backout a=backout on a CLOSED TREE
Backed out changeset e02d99be7eb0 (bug 1404427)
2017-11-11 05:48:15 +02:00
Edouard Oger
62783b8de9 Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
MozReview-Commit-ID: H7AmIBtFUOr
2017-11-06 15:50:28 -05:00
Sebastian Hengst
23db0d3ff9 Backed out changeset d9a7e2fba868 (bug 1404427) on suspicion of causing failures in browser_sanitize-timespans.js at some times of the day. r=backout a=backout on a CLOSED TREE 2017-11-10 15:28:16 +02:00
Edouard Oger
d78d1dc37b Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
MozReview-Commit-ID: H7AmIBtFUOr
2017-11-06 15:50:28 -05:00
Andreea Pavel
3af1cb71b6 Backed out changeset 6aa22b862a45 (bug 1404427) for failing browser-chrome browser/components/search/test/browser_426329.js r=backout on a CLOSED TREE 2017-11-09 21:26:40 +02:00
Edouard Oger
09e10faa93 Bug 1404427 - Sync multiple form history deletions. r=kitcambridge
MozReview-Commit-ID: H7AmIBtFUOr
2017-11-06 15:50:28 -05:00
Mark Banner
6067ef1cb5 Bug 1412893 - Change instances of using getService to Services.jsm where possible in toolkit/components - Part 2. r=florian
MozReview-Commit-ID: 44oBXPP88Lc
2017-10-30 17:22:17 +00:00
Edouard Oger
d341d6e1de Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Sebastian Hengst
46db05e661 Backed out changeset 553d26ab8ee8 (bug 1395427) 2017-09-27 17:10:26 +02:00
Edouard Oger
aefbf9f5b9 Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7
2017-09-22 15:19:56 -04:00
Jonathan Guillotte-Blouin
f44e3e4738 Bug 1372427 - enforce balanced-listeners. r=MattN
MozReview-Commit-ID: KpPZA2godKg
2017-06-16 15:12:32 -07:00
Jonathan Guillotte-Blouin
88b7a0d657 Bug 1372427 - prevent using arguments.caller. r=MattN
MozReview-Commit-ID: J6NceWWJzbP
2017-06-16 14:55:06 -07:00
Jonathan Guillotte-Blouin
9b9ea381d4 Bug 1372427 - add "no-unused-vars" rule, with laxist variation in head_satchel + satchel_common. r=MattN
MozReview-Commit-ID: 9HBxDyUF01Q
2017-06-15 16:39:50 -07:00
Jonathan Guillotte-Blouin
246e1d8e72 Bug 1372427 - enforce "comma-dangle". r=MattN
auto --fix

MozReview-Commit-ID: KKmDI0Pt43K
2017-06-14 17:46:42 -07:00
Jonathan Guillotte-Blouin
441be83e7f Bug 1372427 - add rule to not put spacing inside parens. r=MattN
auto --fix

MozReview-Commit-ID: 7jCl2Z0Q3SI
2017-06-14 17:37:09 -07:00
Jonathan Guillotte-Blouin
68432b1c69 Bug 1372427 - add rule to not put spacing inside arrays. r=MattN
auto --fix

MozReview-Commit-ID: BiEzl4OawuU
2017-06-14 17:35:30 -07:00
Jonathan Guillotte-Blouin
4fb78b27aa Bug 1372427 - enforce "var" declarations only at top-level. r=MattN
MozReview-Commit-ID: 1bzsOoyidnR
2017-06-14 17:30:32 -07:00
Jonathan Guillotte-Blouin
9076dd22f3 Bug 1372427 - force radix argument in parseInt. r=MattN
MozReview-Commit-ID: J4VoeedZpGa
2017-06-14 13:38:17 -07:00
Jonathan Guillotte-Blouin
8a8db1097e Bug 1372427 - add error to not pad blocks. r=MattN
auto --fix

MozReview-Commit-ID: 6tXXL7Ncmso
2017-06-14 13:28:01 -07:00
Jonathan Guillotte-Blouin
0b8e86ced6 Bug 1372427 - add rule to not throw litterals. r=MattN
MozReview-Commit-ID: F962Z4jhm2l
2017-06-14 12:01:50 -07:00
Jonathan Guillotte-Blouin
ddb9887bc4 Bug 1372427 - limit lines to a maximum of 100 chars. r=MattN
MozReview-Commit-ID: 3OSKaTMMBot
2017-06-13 16:48:31 -07:00
Jonathan Guillotte-Blouin
db59f9296e Bug 1372427 - add "dot-location" rule so that dots are on the same line as properties. r=MattN
MozReview-Commit-ID: A6IKfSiVXAN
2017-06-13 16:34:54 -07:00
Jonathan Guillotte-Blouin
815a325de3 Bug 1372427 - add cyclomatic-complexity limit. r=MattN
MozReview-Commit-ID: GRiJw8SBq9e
2017-06-13 15:56:31 -07:00
Jonathan Guillotte-Blouin
6e1ffff1ea Bug 1372427 - add "no-use-before-define" rule. r=MattN
MozReview-Commit-ID: BRhwhnxzlpG
2017-06-13 14:34:12 -07:00
Jonathan Guillotte-Blouin
065f07ec40 Bug 1372427 - add "block-scoped-var" rule. r=MattN.
MozReview-Commit-ID: K3Zwr0jy6U2
2017-06-13 14:23:11 -07:00
Jonathan Guillotte-Blouin
29b30a4a82 Bug 1372427 - add js-doc rule. r=MattN
MozReview-Commit-ID: YgDBHM88PW
2017-06-13 10:48:52 -07:00
Jonathan Guillotte-Blouin
4aee0d02d2 Bug 1372427 - add semi-colon rule. r=MattN
auto --fix

MozReview-Commit-ID: F9GvxcghPkt
2017-06-13 09:51:07 -07:00