Commit Graph

89 Commits

Author SHA1 Message Date
Nika Layzell
3d4a532d9d Bug 1434768 - Part 3: Rewrite JS consumers of .sessionHistory, r=bz 2018-04-10 17:49:45 -04:00
Boris Zbarsky
b048abbbb9 Bug 1452235 part 3. Stop using nsIDOMSerializer from JS. r=qdot
MozReview-Commit-ID: JbWGcfbmM4b
2018-04-09 16:30:32 -04:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
febbc31556 Bug 1396565, make reader mode fetch the article from within the content process on desktop, r=jaws
MozReview-Commit-ID: 11uTaQYwz2Y
2017-11-14 16:53:55 +00:00
Cameron McCormack
199ae02a34 Bug 1417837 - Part 2: Preserve class names in readerized output that we use in aboutReader.css. r=Gijs
MozReview-Commit-ID: 7qV2SRHeeOJ
2017-11-21 11:54:25 +08:00
Dorel Luca
29ccf2be4c Backed out 3 changesets (bug 1417837) for failing browser/chrome/test_media_playback.html r=backout on a CLOSED TREE
Backed out changeset 9556f12b4058 (bug 1417837)
Backed out changeset 49a463e85e42 (bug 1417837)
Backed out changeset 7a76f2363663 (bug 1417837)
2017-12-04 14:59:31 +02:00
Cameron McCormack
2a1e8c037d Bug 1417837 - Part 2: Preserve class names in readerized output that we use in aboutReader.css. r=Gijs
MozReview-Commit-ID: 7qV2SRHeeOJ
2017-11-21 11:54:25 +08:00
Coroiu Cristina
20dd07106d Backed out 3 changesets (bug 1417837) for ESlint failures at /builds/worker/checkouts/gecko/toolkit/components/narrate/NarrateControls.jsm r=backout on a CLOSED TREE
Backed out changeset 0d6b56293cbf (bug 1417837)
Backed out changeset 1c341a427a7a (bug 1417837)
Backed out changeset fa4f488ea88f (bug 1417837)
2017-12-04 12:34:37 +02:00
Cameron McCormack
3e7cd7958e Bug 1417837 - Part 2: Preserve class names in readerized output that we use in aboutReader.css. r=Gijs
MozReview-Commit-ID: 7qV2SRHeeOJ
2017-11-21 11:54:25 +08:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Jonathan Hao
582f234b99 Bug 1369327 - Remove low memory platform checks in reader mode. r=Gijs
MozReview-Commit-ID: 1VUprtntsK0
2017-07-18 14:44:56 +08:00
Mark Banner
b1b7a75372 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
MozReview-Commit-ID: EnhSBHMjurr
2017-07-11 22:49:55 +01:00
Gijs Kruitbosch
92f71a5369 Bug 1364056 - don't try to use doc reference when it might be dead, r=baku
MozReview-Commit-ID: Lt7aOU8hPSV
2017-05-15 22:01:40 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Sebastian Hengst
0fb690c415 Bug 1358248 - update uri call in log statement to fix failure detected by eslint. r=eslint-fix 2017-05-09 13:24:10 +02:00
Gijs Kruitbosch
8895838919 Bug 1358248, r=evanxd
MozReview-Commit-ID: 55otSuRxdsa
2017-04-22 15:07:41 +01:00
Gijs Kruitbosch
36091cb9cc Bug 1358248, r=nechen,evanxd
MozReview-Commit-ID: 1EBZFcyvmY1
2017-04-22 15:00:22 +01:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Evan Tseng
9106be5219 Bug 1177360 - Disable reader mode button for amazon.com, r=Gijs
MozReview-Commit-ID: Cg9Gm4HCHbA
2017-03-01 18:22:45 +08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jim Chen
a55ec92358 Bug 1328683 - Convert ReadingListHelper events to bundle events; r=sebastian 2017-01-10 23:01:27 -05:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
fiveNinePlusR
dc7b67c54e Bug 1265304 - Add an estimated time range to reader mode, r=gijs,ui-r=emanuela
Uses an upper and lower bound found from this study: http://iovs.arvojournals.org/article.aspx?articleid=2166061
2016-12-11 21:35:00 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Wes Kocher
1aa5b280a6 Merge inbound to central, a=merge 2016-11-08 13:58:20 -08:00
Sébastien Blin
7190bbc6af Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Evan Tseng
23e8bd1fd1 Bug 1173823 - Always use document.baseURI as the uri parameter of _readerParse method, r=Gijs
MozReview-Commit-ID: RnICyZALNb
2016-11-07 17:31:23 +08:00
Sebastian Hengst
3b219cba1e Backed out changeset 1cb8dac3eb40 (bug 1189491) for failing browser_readerMode.js. r=backout 2016-11-05 13:54:35 +01:00
Sébastien Blin
f3ee406553 Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Wes Kocher
d939df7bcf Backed out changeset 4da7d22ebcd2 (bug 1189491) for multiple eslint failures a=backout CLOSED TREE 2016-11-04 11:55:56 -07:00
Sébastien Blin
f1aba24f22 Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Gijs Kruitbosch
a7e5b8832f No bug, fix eslint errors introduced when enabling more rules in .eslintrc.js, rs=bustage
MozReview-Commit-ID: GADYtKhyd50
2016-11-02 11:33:21 +01:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
252bc6e582 Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes, r=margaret,data-r=bsmedberg
MozReview-Commit-ID: 2FSr4v4fPWU
2016-06-24 15:39:23 +01:00
Timothy Guan-tin Chien
0bab46ef0a Bug 1266372 - De-dup code to ReaderMode.leaveReaderMode, r=gijs
Additionally, implements ReaderMode.enterReaderMode.

MozReview-Commit-ID: 8MPvFhX4ws7
2016-04-26 12:52:50 +08:00
Andrzej Hunt
cf169ca80e Bug 1263628 - Ignore fragments when comparing URLs during reader view caching r=gijs
This seems to be a common issue with medium.com articles, but affects any page which was
opened using a fragment in the URL (e.g. foo.com/bar#baz is the same page as foo.com/bar,
however our reader view caching code didn't recognise the former as being equivalent to
the latter).

MozReview-Commit-ID: BtRmHq3sD9z
2016-04-15 11:17:36 -07:00
Andrzej Hunt
eb6f798dbd Bug 1263628 - meta-refresh can use a relative URL, ensure base URI is included r=gijs
E.g. articles on facebook.com provide a meta-refresh containing "0; URL=/foo/bar?....",
and we previously attempted to use just this URL component, instead of constructing it
using the current page URL.

MozReview-Commit-ID: 4vSoz5lc1e
2016-04-15 13:53:19 -07:00