Commit Graph

250 Commits

Author SHA1 Message Date
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Marco Bonardo
2c543eaafc Bug 1452660 - Tag queries pointing to an invalid folder are being rewritten as empty urls. r=standard8
MozReview-Commit-ID: FUmmYewl8Vt
2018-04-11 15:45:23 +02:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Marco Bonardo
63caae06bd Bug 1452376 - Replace GetDescendantFolders with a recursive subquery. r=standard8
MozReview-Commit-ID: 7eXfqzX2qLl
2018-04-10 00:20:36 +02:00
Marco Bonardo
3382b7442d Bug 1293445 - 5 - Rename RESULTS_AS_TAG_QUERY. r=standard8
MozReview-Commit-ID: 7HwPKkGvAvv
2018-04-04 16:14:20 +02:00
Marco Bonardo
b2e8b679a0 Bug 1293445 - 4 - Remove RESULTS_AS_TAG_CONTENTS. r=standard8
MozReview-Commit-ID: rybSCGrfnf
2018-04-03 18:32:00 +02:00
Marco Bonardo
36ec58e083 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW
2018-03-22 14:13:07 +01:00
milindl
669c5896c7 Bug 1421664 - 2 - Change SelectAsTag to use place: tag queries. r=mak
MozReview-Commit-ID: JauduB7A5TZ
2018-03-20 17:27:44 +01:00
milindl
ad09ac583a Bug 1421664 - 1 - Force any tag queries to have query result type bookmarks. r=mak
MozReview-Commit-ID: KG1mGZD5PNy
2018-03-20 16:42:04 +01:00
Marco Bonardo
076d488966 Bug 1447929 - Fix a few interface/concrete smart pointers in Places. r=standard8
MozReview-Commit-ID: IEoPxZseoyw
2018-03-22 11:17:58 +01:00
Marco Bonardo
d5c51cbe2d Bug 1446951 - 9 - Move EvaluateQueryForNode. r=standard8
MozReview-Commit-ID: 5YfaRfhcbxY
2018-03-20 12:24:05 +01:00
Marco Bonardo
fc61b0aea0 Bug 1446951 - 8 - Reduce the number of query node constructors to one. r=standard8
MozReview-Commit-ID: ICDxftFlePN
2018-03-20 11:29:54 +01:00
Marco Bonardo
fdad30e63f Bug 1446951 - 7 - Remove some internal use of GetHas* APIs. r=standard8
MozReview-Commit-ID: E4JudYNzLFT
2018-03-20 01:07:01 +01:00
Marco Bonardo
87ad90c95d Bug 1446951 - 6 - Change internal results code to support a single query. r=standard8
MozReview-Commit-ID: 5ceutaSM6Vk
2018-03-19 11:58:35 +01:00
Marco Bonardo
b18d35da18 Bug 1446951 - 5 - Remove QueryStringToQueryArray. r=standard8
MozReview-Commit-ID: H6nMhiXgDKA
2018-03-16 21:36:02 +01:00
Marco Bonardo
1e6e04064a Bug 1446951 - 3 - Make AsyncExecuteLegacyQueries singular. r=standard8
MozReview-Commit-ID: KyYw92tzyN6
2018-03-16 18:10:09 +01:00
Marco Bonardo
6925512606 Bug 1446951 - 1 - Remove nsINavHistory::ExecuteQueries. r=standard8
MozReview-Commit-ID: ATQLGKzMtnn
2018-03-16 15:38:05 +01:00
Mark Banner
bd36d1f655 Bug 1446672 - Correctly handle insertion of L10n strings into Places' built-in virtual queries for all bookmarks/left-pane. r=mak
MozReview-Commit-ID: 6wzdoJl5Sjo
2018-03-19 12:43:22 +00:00
Mark Banner
f190c32a0e Bug 1437516 - Remove nsINavHistoryService/nsINavBookmarksService::runInBatchMode. r=mak
MozReview-Commit-ID: D1H3xdjpMAx
2018-03-13 16:19:33 +00:00
Mark Banner
8bda7e6d85 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Dorel Luca
37af71af05 Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
2018-03-14 18:23:46 +02:00
Mark Banner
60c4119b69 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Kit Cambridge
8592094f9a Bug 1435446 - Use immediate transactions by default in Places. r=mak
MozReview-Commit-ID: L2rCMwqZZkQ
2018-02-28 23:32:57 -08:00
Mark Banner
4c2cffce71 Bug 1437250 - Bookmark url queries shouldn't return folder shortcuts. r=mak
URL queries don't need to return queries not shortcuts, as that isn't what the invoker is expecting.

MozReview-Commit-ID: 74LvXqc40Ps
2018-02-20 20:34:09 +00:00
Mark Banner
d4f537f98d Bug 1436966 - Remove the bookmark-observers & history-observers category listeners. r=mak
MozReview-Commit-ID: 2dsyxZG98IR
2018-02-09 11:21:14 +00:00
Mark Banner
7b945e40de Bug 1423896 - Make the new All Bookmarks folder query only update on the mobile folder status change for better performance. r=mak
MozReview-Commit-ID: 4sIR6d0ZabJ
2018-02-05 17:19:26 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Mark Banner
71b93930f8 Bug 1423896 - When excluding queries within places queries, we shouldn't exclude folder shortcuts. r=mak
MozReview-Commit-ID: 810igliCov8
2018-01-12 16:15:25 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
e6086011ae Bug 1423896 - Make the new All Bookmarks folder query only update on the mobile folder status change for better performance. r=mak
MozReview-Commit-ID: 4sIR6d0ZabJ
2018-02-05 17:19:26 +00:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Mark Banner
f298233b52 Bug 1423896 - When excluding queries within places queries, we shouldn't exclude folder shortcuts. r=mak
MozReview-Commit-ID: 810igliCov8
2018-01-12 16:15:25 +00:00
Marco Bonardo
443dfd2029 Bug 1432436 - Remove getItemType. r=standard8
MozReview-Commit-ID: 1gnQzJkYZgH
2018-01-23 16:02:03 +01:00
Marco Bonardo
d6511a0271 Bug 885247 - Remove History::GetPageTitle synchronous API. r=standard8
MozReview-Commit-ID: FleAOXBHyeK
2018-01-23 10:44:38 +01:00
Chris Peterson
677bf4030c Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
MozReview-Commit-ID: DCPTnyBooIe
2017-11-05 19:37:28 -08:00
Doug Thayer
5394d406e4 Bug 1421703 - replace onVisit with onVisits r=mak
There's a heavy enough overhead to going through XPConnect for
every observer for every visit on the nsINavHistoryObserver
interface, so this patch reduces that by replacing the single-
visit notification with one which accepts an array of visits.

Some notes: To avoid problems with the orderings of the various
ways in which we notify about visits, we have to send our bulk
onVisits notification before doing any of the others. This does
mean it technically behaves slightly different than the prior
approach of interleaving the notifications, but I can't find any
way in which this has any consequences to the end result, and it
doesn't break any tests.

MozReview-Commit-ID: GdeooH8mCkg
2017-12-20 14:27:24 -08:00
ayus
7e4145d4ca Bug 1421212 - Remove RESULTS_AS_FULL_VISIT. r=mak 2017-12-15 21:31:31 +05:30
MilindL
8408392103 Bug 1421654: Make tag queries case insensitive and associated tests. r=mak
Additional tests added include testing for queries where tags have special characters.

MozReview-Commit-ID: 7Hrcw6lTfMz
2017-11-17 23:29:03 +05:30
Doug Thayer
47643c47d0 Bug 1417266 - Cache calls to CryptAcquireContext r=mak
When running history imports, a large percentage of the time
is spend in CryptAcquireContext. This caches this for all guid
generation in the places system.

MozReview-Commit-ID: 43lig8F7Uww
2017-11-21 11:28:40 -08:00
Doug Thayer
e469da7af4 Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.

MozReview-Commit-ID: 5TUueknq3ng
2017-11-07 12:01:53 -08:00
Kit Cambridge
13d9ab0323 Bug 1412142 - Expose PlacesUtils.history.hashURL. r=mak
This patch exposes the Places `hash()` SQL function to JS.

MozReview-Commit-ID: C4Zj4FyMZpq
2017-08-16 16:01:40 -07:00
Kris Maglione
60872d7b31 Bug 1404198: Part 2f - Switch to NS_NewTimer* in toolkit. r=njn
MozReview-Commit-ID: 185rZ99R6zV
2017-10-15 23:14:00 -07:00
Marco Bonardo
7af44bf697 Bug 1405687 - Remove some deprecated code from Places related code. r=standard8
MozReview-Commit-ID: 411z07otlfN
2017-10-04 16:33:46 +02:00
Chris Peterson
90bcd3c611 Bug 870698 - Part 8: Replace Equals(NS_LITERAL_CSTRING("")) with EqualsLiteral(""). r=erahm
The NS_LITERAL_CSTRING macro creates a temporary nsLiteralCString to encapsulate the string literal and its length, but AssignLiteral() can determine the string literal's length at compile-time without nsLiteralCString.

MozReview-Commit-ID: B5Y8KyExPQ8
2017-09-06 15:00:31 -07:00
Chris Peterson
bd442bfa70 Bug 870698 - Part 6: Replace Append(NS_LITERAL_CSTRING("")) with AppendLiteral(""). r=erahm
The NS_LITERAL_CSTRING macro creates a temporary nsLiteralCString to encapsulate the string literal and its length, but AssignLiteral() can determine the string literal's length at compile-time without nsLiteralCString.

MozReview-Commit-ID: F750v6NN81s
2017-09-07 18:25:25 -07:00
Eric Rahm
b3a9bd1c4c Bug 1393235 - Fix improper usages of string functions. r=njn
This fixes usages of `Find`, `RFind` and the equality operator that kind of
work right now but will break with the proper type checking of a templatized
version of the string classes.

For `Find` and `RFind` it appears that `nsCString::(R)Find("foo", 0)` calls
were being coerced to the `Find(char*, bool, int, int)` versions. The intent was
probably to just start searching from position zero.

For the equality operator, the type of nullptr is nullptr_t rather than
char(16_t)* so we'd need to add an operator overload that takes nullptr_t. In
this case just using `IsVoid` is probably more appropriate.
2017-08-22 19:30:46 -07:00
Nicholas Nethercote
723f585d9c Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.

The patch also removes a couple of unused declarations from
nsIStringBundle.idl.

Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.
2017-08-04 14:40:52 +10:00
Kartikaya Gupta
14424677af Bug 1384233 - Remove SizePrintfMacros.h. r=froydnj
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.

MozReview-Commit-ID: 6s78RvPFMzv
2017-07-26 16:03:57 -04:00
Marco Bonardo
6dd1b175e4 Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=adw
MozReview-Commit-ID: A2sn2OreX4K
2016-05-19 23:50:27 +02:00
Kit Cambridge
db04d478e3 Bug 1380740 - Remove remaining visit title fallbacks for untitled bookmarks. r=mak
MozReview-Commit-ID: 1f4HMWzxXat
2017-07-13 19:08:40 -07:00