Commit Graph

40 Commits

Author SHA1 Message Date
Adrian Wielgosik
975ac50d53 Bug 1418077 - Remove nsIDOMHTMLFormElement. r=bz
MozReview-Commit-ID: 9eQxvfIMB22
2018-03-14 21:42:25 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Johann Hofmann
ce28526451 Bug 1364208 - Consider local IP address form actions secure for the insecure password warning. r=MattN
We whitelist local IP addresses for the in-content insecure password warning,
but many of them will have forms that point to e.g., /login.php. That should
not show the insecure password warning either.

MozReview-Commit-ID: KozEWAqKGIA
2017-05-24 22:04:01 +02:00
Kate McKinley
1bef155067 Bug 1410364 - Don't consider opener when calculating IsSecureContext. r=bz, r=dveditz
Per https://github.com/w3c/webappsec-secure-contexts/issues/42, the
section considering the window opener when calculating secure context is
to be dropped. Firefox already uses "isSecureContextIfOpenerIgnored" in
most places as this is the actual behavior we want. This patch aligns
with the upcoming spec changes by ignoring the window opener. We also no
longer have to keep information about whether our opener was secure as
that no longer factors in our calculations.
2017-11-29 10:40:00 -05:00
Masatoshi Kimura
b5473a8193 Bug 1387805 - Remove [deprecated] nsIScriptSecurityManager.getCodebasePrincipal(). r=bz
MozReview-Commit-ID: CY47PBaQ5oy
2017-08-06 15:31:31 +09:00
Johann Hofmann
37bf9c6724 Bug 1337246 - Part 2 - Detect local IP addresses to ignore for insecure password warnings. r=MattN
MozReview-Commit-ID: 2IWvOJNTnNB
2017-05-08 14:58:53 -04:00
Julian Descottes
54963c23b0 Bug 1358080 - add logic to get inner window id to InsecurePasswordUtils.jsm;r=MattN
InsecurePasswordUtils.jsm used to rely on a devtools util to get the innerWindowId
of window objects. As devtools are moving out of mozilla-central, this code needs
to be extracted and the dependency should be removed.

MozReview-Commit-ID: 8rI3Lxu16h5
2017-04-20 12:35:13 +02:00
Florian Quèze
a19e007056 Bug 1338585 - Add an eslint rule to require using .ownerGlobal instead of .ownerDocument.defaultView, r=jaws. 2017-02-13 13:01:32 +01:00
Johann Hofmann
19a80946a6 Bug 1334201 - Ignore window.opener for insecure form warnings. r=MattN
MozReview-Commit-ID: BLuwIAWEYHi
2017-01-31 10:34:06 +01:00
Kate McKinley
0277b62d89 Bug 1329940 - Ignore window.opener for password manager warnings r=baku,jwatt,MattN
MozReview-Commit-ID: KiIR6WEddgO
2017-01-12 16:57:44 -08:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Brian Grinstead
d3c7b73f76 Bug 1259603 - Use ConsoleEvents for cached messages and observing messages when webconsole actor is running;r=ejpbruel
MozReview-Commit-ID: E3oG451qPe9
2016-11-30 10:32:48 -08:00
Johann Hofmann
216959733b Bug 1302474 - Add a pref to disable login autofill on insecure forms. r=MattN
MozReview-Commit-ID: Fpz5108WvpR
2016-09-13 12:04:46 +02:00
Matthew Noorenberghe
3dbe67f6c2 Bug 1310049 - Refactor FormLikeFactory to its own module for use by Form Autofill. r=steveck
This introduces LoginFormFactory which wraps FormLikeFactory for use with login-specific contexts.

MozReview-Commit-ID: 6rPz5JOy3Yp
2016-10-18 13:31:09 -07:00
Matthew Noorenberghe
eb2a4fc18f Bug 1269568 - Remove LoginManagerContent's isDocumentSecure function in favor of Window.isSecureContext. r=johannh
MozReview-Commit-ID: 12o3WIr6zqS
2016-10-06 21:51:01 -04:00
Matthew Noorenberghe
dfc22c9e92 Bug 1299984 - Enable eslint no-unused-vars for shipping pwmgr code. r=johannh
I also fixed two test cases while I was looking at the results.

MozReview-Commit-ID: LpUj56UNV3r
2016-09-02 14:07:13 -07:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Brian Grinstead
4e42260d3e Bug 1288475 - Split webconsole utils.js into separate client and server parts;r=MattN,tromey
MozReview-Commit-ID: HlpiRvuMF1H
2016-08-05 10:44:38 -07:00
Matthew Noorenberghe
401dfedd01 Bug 1261234 - Handle <form> without @action properly. r=me
MozReview-Commit-ID: 4IwpOedgmP3
2016-05-11 14:06:59 -07:00
Sean Lee
5e1a41c907 Bug 1261234 - Use isOriginPotentiallyTrustworthy to verify the login form action.; r=MattN
MozReview-Commit-ID: CqkG54Qj9mm
2016-05-11 13:44:44 -07:00
Sean Lee
cc9c514dd1 Bug 1191092 - Warn about insecure <input type=password> outside of a <form>. r=MattN
MozReview-Commit-ID: Q5abQmgdhA
2016-04-14 15:54:31 -07:00
Matthew Noorenberghe
679993fe03 Bug 1257757 - Add filenames to insecure password warnings. r=bgrins
MozReview-Commit-ID: IT6yhL5hJvA
2016-03-21 15:31:00 -04:00
Matthew Noorenberghe
b6655f8722 No bug - Modernize style and improve comments of InsecurePasswordUtils.jsm
MozReview-Commit-ID: 6c2J4ncppPL
2016-03-17 22:24:33 -07:00
AJ Kerrigan
8917ed42db Bug 1246188 - Make webconsole.js ESLint-clean. r=lclark 2016-02-13 00:56:12 -05:00
Paolo Amadini
cfbe4569d1 Bug 1217766 - All PDFs trigger the insecure password warning. r=MattN,bz 2016-01-18 14:54:18 +00:00
J. Ryan Stinnett
687866dde2 Bug 1203159 - Rewrite DevTools resource URLs. r=ochameau 2015-10-21 12:48:53 -05:00
Paolo Amadini
6d24886cab Bug 1193341 - Detect presence of password fields in any subframe, flagging those on insecure connections. r=MattN 2015-10-13 13:40:34 +01:00
Vladan Djeric
2d7eaaba05 Backed out changeset 5d1ec6ca9374 (bug 1193341) for Talos regressions (bug 1213364) 2015-10-11 00:26:26 -04:00
Paolo Amadini
b16bed6eee Bug 1193341 - Detect presence of password fields in any subframe, flagging those on insecure connections. r=MattN 2015-10-07 19:51:33 +01:00
J. Ryan Stinnett
2dada8f365 Bug 912121 - Rewrite require / import to match source tree. rs=devtools
In a following patch, all DevTools moz.build files will use DevToolsModules to
install JS modules at a path that corresponds directly to their source tree
location.  Here we rewrite all require and import calls to match the new
location that these files are installed to.
2015-09-21 12:04:18 -05:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Tanvi Vyas
c2aea6ff68 Bug 1194352 - Add a check for insecure forms to the PWMGR_LOGIN_PAGE_SAFETY telemetry probe. r=MattN, p=ally 2015-08-28 15:51:26 -07:00
Kate McKinley
bcf6bfb803 Bug 1174333 - Telemetry for percentage of password fields on safe/unsafe pages. r=MattN,tanvi p=ally 2015-08-17 21:48:34 -07:00
Ivan Alagenchev
5251ee4a3d Bug 762593 TOOLKIT patch. Adds logic for validating if password input fields are insecure. r=dolske 2013-08-06 10:14:40 -04:00