Commit Graph

876 Commits

Author SHA1 Message Date
David Major
b148a2518f Bug 1338947: Add const to kBinaryFileExtensions. r=gcp
MozReview-Commit-ID: 5le3q56JRms
2017-02-14 15:24:55 +13:00
Cykesiopka
e99d55a74b Bug 1331983 - Avoid non-smart string IDL types in nsIX509CertDB.idl. r=gcp,keeler,nwgh
Smart string classes like nsCString are safer to use than raw |char*| strings,
and are typically easier to deal with as well.

MozReview-Commit-ID: 2PdrCa6cbpe
2017-02-09 23:11:29 +08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Andrea Marchesini
46a9207d60 Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby 2017-01-12 17:38:48 +01:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Thomas Nguyen
82e1caab63 Bug 1304623 - Create a pref to control the default referrer policy - part 3. r=bkelly
MozReview-Commit-ID: 1A6IHPeNYBQ
2017-01-05 11:29:56 +08:00
Mark Banner
d07f540195 Bug 1328338 - Fix more no-undef eslint issues in toolkit/ and browser/. r=mossop
MozReview-Commit-ID: 78dXLYVW1gC
2017-01-03 11:55:24 +00:00
Phil Ringnalda
1360dff918 Merge m-i to m-c, a=merge
MozReview-Commit-ID: FEe5yZfka5J
2017-01-03 18:40:26 -08:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
dimi
d2fb140df2 Bug 1320402 - Move url-classifier off of using appIds. r=ehsan, gcp
MozReview-Commit-ID: IqnAVrv2c9W
2017-01-03 14:21:58 +08:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Ting-Yu Chou
1cc96e042d Bug 1322465 part 11 - Use explicit/MOZ_IMPLICIT for the unary constructors in toolkit/. r=Ehsan
MozReview-Commit-ID: 7zdrF739NCL
2016-12-16 15:59:00 +08:00
Steve Jarvis
a2dc2fc4cf Bug 1319762 - Remove download.xul and related unused files. r=florian
Remove files and resources no longer shipped or referenced and update
the appropriate packaging files.

MozReview-Commit-ID: Apaa2JnOTMt
2016-12-15 07:47:07 -07:00
Bill McCloskey
5682d56ea8 Bug 1320753 - Add nsINamed and have Runnable implement it (r=ehsan)
MozReview-Commit-ID: 6Vuw3aJ3860
2016-11-30 18:01:59 -08:00
Thomas Nguyen
7064eed520 Bug 1315386 - Make Safe Browsing code more shutdown-aware. r=francois,gcp.
MozReview-Commit-ID: ATCVfh5YLZl
2016-11-25 16:02:37 +08:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Carsten "Tomcat" Book
cabaa5540f Merge mozilla-central to mozilla-inbound 2016-11-11 16:43:07 +01:00
Nathan Froyd
8a9bd5755c Bug 1316642 - convert giant logical OR expression in IsBinaryFile into a for loop; r=gcp
The giant logical OR expression was causing GCC on x86-64 to churn out a
200K function, which is completely unnecessary.  This revised
formulation is not maximally efficient, but it is a massive improvement
size-wise: IsBinaryFile + the table is about 2K on x86-64.
2016-11-11 01:00:11 -05:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM
MozReview-Commit-ID: I5LuDjnM7By
2016-11-05 11:29:22 +01:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
William Chen
ffb414a896 Bug 862395 - Part 1: Add requireInteraction property to web notifications. r=baku 2016-10-12 17:27:40 -07:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
MozReview-Commit-ID: 8svkCKZHxsq
2016-11-08 12:49:32 +00:00
Jared Wein
b6817d7876 Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: 1mhCWplknyN
2016-11-07 22:34:25 -05:00
Iris Hsiao
d24e67dbe4 Backed out changeset f6f28be8d8f2 (bug 1315781) for XPCShell test timed out 2016-11-10 14:53:46 +08:00
Jared Wein
0c41af265f Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: DnpVQRrG9Ec
2016-11-07 22:34:25 -05:00
Jim Chen
31d505d8ba Bug 1305271 - 2. Add and use jni::IsFennec() for Fennec-only code; r=snorp
Add jni::IsFennec() that returns whether we're in a Fennec environment
(defined as the presence of the GeckoApp class). Then, add
jni::IsFennec() checks to places where we use JNI for Fennec-only classes.
2016-09-28 23:49:25 -04:00
Jim Chen
bf2169c56b Bug 1291375 - 5. Use Fennec bindings where needed; r=snorp
Switch include statements from GeckoView bindings to Fennec bindings
where needed.
2016-09-16 15:13:48 -04:00
Francois Marier
0a7382402b Bug 1302211 - Sync file extension list with Chrome. r=gcp
Directly executable file types were added and types that Chrome
doesn't submit to the remote server were removed.

PDF is retained for now and many archive types are commented-out.

https://cs.chromium.org/chromium/src/chrome/browser/resources/safe_browsing/download_file_types.asciipb

MozReview-Commit-ID: 3lXUX9NV4Fw
2016-09-12 15:58:44 -07:00
Francois Marier
b6cfd4500e Bug 1302211 - Remove .osx extension from download protection. r=gcp
https://bugs.chromium.org/p/chromium/issues/detail?id=641614

MozReview-Commit-ID: 6m3bKNlnjIv
2016-09-12 13:23:25 -07:00
Francois Marier
6fb8593a43 Bug 1302211 - Import latest Safe Browsing CSD file from Chrome. r=gcp
MozReview-Commit-ID: Ax6TICKsQjv
2016-09-12 13:21:42 -07:00
Nicholas Nethercote
cc4d39daaa Bug 1297300 - Add missing checks to GetSpec() calls in toolkit/. r=froydnj. 2016-09-08 14:32:20 +10:00
Michael Layzell
419868d357 Bug 1018486 - Part 9: Changes to account for modifications to clang plugin, r=ehsan
MozReview-Commit-ID: EPQMbfHYxUK
2016-09-07 10:50:47 -04:00
Nicholas Nethercote
887efe04d5 Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Jared Wein
05088cc7cb Bug 336290 - remove --enable-safe-browsing from configure since its used everywhere. r=gcp
MozReview-Commit-ID: Duwu5vZOhtF
2016-08-31 19:28:29 -04:00
Yoshi Huang
a470396744 Bug 1244340 - Part 1: Use origin attributes as cstor arg for LoadContext r=sicking 2016-08-26 18:59:00 +08:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
2016-08-24 14:47:04 +08:00
Nicholas Nethercote
e1e19a4435 Bug 1296164 (part 3) - Use [must_use] on more nsIFile things. r=froydnj.
These ones don't require any extra checks to be added.
2016-08-18 16:43:28 +10:00
Francois Marier
5a0e9eda76 Bug 1296472 - Update csd.proto to the latest upstream version. r=gcp
MozReview-Commit-ID: 4a4AHMtUehN
2016-08-18 15:50:09 -07:00
Francois Marier
cc1dd59bd2 Bug 1296472 - Update the bug component for Application Reputation files. r=gcp
MozReview-Commit-ID: Ao4ng5Kdi4H
2016-08-18 15:50:09 -07:00
Francois Marier
182aac11ab Bug 1296472 - Move upstream chromium code into chromium directory. r=gcp
MozReview-Commit-ID: 3bjPtqtQlGb
2016-08-18 15:50:09 -07:00
Nicholas Nethercote
8f3c6e7c32 Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj.
Slightly less than half (93 / 210) of the NS_METHOD instances in the codebase
are because of the use of NS_CALLBACK in
nsI{Input,Output,UnicharInput},Stream.idl. The use of __stdcall on Win32 isn't
important for these callbacks because they are only used as arguments to
[noscript] methods.

This patch converts them to vanilla |nsresult| functions. It increases the size
of xul.dll by about ~600 bytes, which is about 0.001%.
2016-08-12 17:36:22 +10:00
Nicholas Nethercote
0550795f93 Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.
2016-08-08 10:54:47 +10:00
Carsten "Tomcat" Book
ce02c3ed29 merge mozilla-inbound to mozilla-central a=merge 2016-08-10 15:54:26 +02:00
Nicholas Nethercote
1f65390cc9 Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
2016-08-08 12:18:10 +10:00
Francois Marier
88ba1518b7 Bug 1291472 - Add more application reputation extensions. r=gcp
MozReview-Commit-ID: EKXupjU5JG4
2016-08-05 16:56:46 -07:00
Henry Chang
9708a23b7f Bug 1274112 - Part 1: Make update request v4. r=francois
MozReview-Commit-ID: NgV4QYbDll
2016-08-04 18:10:06 +08:00