Commit Graph

66 Commits

Author SHA1 Message Date
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Nika Layzell
b4c313c43d Bug 1437167 - Part 1: Stop using PRIntervalTime as the argument to CondVar::Wait and Monitor::Wait, r=mstange, r=froydnj 2018-04-10 17:49:47 -04:00
Doug Thayer
fa0141b0b2 Bug 1443688 - Ensure NotifyWait doesn't result in indefinite hangs r=mystor
If we enter a hang through the normal timed loop of RunMonitorThread, and then
call NotifyWait, it will result in a hang with an indefinite duration being
reported once NotifyActivity is called again.

MozReview-Commit-ID: 4vUip65L0qo
2018-03-18 09:28:17 -07:00
Julian Seward
1db3895a68 Bug 1442603 - Background Hang Reporter: increase timeouts when running on Valgrind. r=mystor. 2018-03-13 08:42:43 +01:00
Julian Seward
3702454f11 Bug 1443499 - Background Hang Reporter: use only one thread for unwinding and reporting. r=mystor.
When the BHR wants to report a tardy thread, it hands off the work of
getting a stacktrace to a helper thread.  The helper threads used are in the
Stream Transport Service threadpool, which has a default limit of 25
threads.

This has a bad effect when we are in a severely compute-resource constrained
situation.  Then, many threads will be late, and up to 25 STS worker threads
will be employed to do unwinding, a potentially expensive operation.  This
further restricts the compute resources available to progress the rest of
the system.

Another effect is that the unwinder work will compete against the "real" STS
work for the 25 workers, potentially further slowing forward progress.

This patch replaces the use of the STS thread pool with a single nsThread
dedicated to unwinding/reporting hangs.
2018-03-12 11:11:24 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Nika Layzell
56c7889a1e Bug 1424766 - Simplify HangStack and HangDetails by implementing using ipdl structs and unions, r=froydnj
MozReview-Commit-ID: qlBUnvYams
2018-01-16 14:07:38 -05:00
Nika Layzell
b2973a606d Bug 1430850 - Part 4: Rework BHR's profiler marker to use add_marker_for_thread, r=mstange
MozReview-Commit-ID: BivFEJD2KCY
2018-01-16 14:07:30 -05:00
Alexandre Poirot
1864c90465 Bug 1423890 - Add markers for background hangs r=dthayer,mstange
MozReview-Commit-ID: 484UZEbbd12
2017-12-07 02:35:36 -08:00
Ashwin Patil
14d64a9cdd Bug 1410101 - Replace "Preferences::GetBool("toolkit.telemetry.enabled")" with "Telemetry::CanRecordPrereleaseData()" in BackgroundHangMonitor.cpp to determine if it needs to be enabled or not. r=chutten
Indicates whether Telemetry pre-release data recording is turned on. Tends to be true on pre-release channels. Also, this attribute is read-only. @see nsITelemetry.canRecordPrereleaseData.
2018-01-04 00:30:56 +05:30
Florian Quèze
1838aa9e08 Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Alessio Placitelli
100390f189 Bug 1406392 - Make nsITelemetry.canRecordExtended true on pre release channels. r=chutten
MozReview-Commit-ID: 2FR5dekXbeV
2017-10-16 12:28:38 +02:00
Nicholas Nethercote
a35e82f193 Bug 1403868 (part 4) - Reduce tools/profiler/public/*.h to almost nothing in non-MOZ_GECKO_PROFILER builds. r=mstange.
Currently the Gecko Profiler defines a moderate amount of stuff when
MOZ_GECKO_PROFILER is undefined. It also #includes various headers, including
JS ones. This is making it difficult to separate Gecko's media stack for
inclusion in Servo.

This patch greatly simplifies how things are exposed. The starting point is:

- GeckoProfiler.h can be #included unconditionally;

- everything else from the profiler must be guarded by MOZ_GECKO_PROFILER.

In practice this introduces way too many #ifdefs, so the patch loosens it by
adding no-op macros for a number of the most common operations.

The net result is that #ifdefs and macros are used a bit more, but almost
nothing is exposed in non-MOZ_GECKO_PROFILER builds (including
ProfilerMarkerPayload.h and GeckoProfiler.h), and understanding what is exposed
is much simpler than before.

Note also that in BHR, ThreadStackHelper is now entirely absent in
non-MOZ_GECKO_PROFILER builds.
2017-10-04 09:11:18 +11:00
Nicholas Nethercote
e8236888ee Bug 1401813 - Rename Null[C]String() as Void[C]String(). r=erahm.
XPCOM's string API doesn't have the notion of a "null string". But it does have
the notion of a "void string" (or "voided string"), and that's what these
functions are returning. So the names should reflect that.
2017-09-22 14:35:46 +10:00
Michael Layzell
8b68e133eb Bug 1401685 - Don't skip sending BHR ping if it is empty, r=froydnj 2017-09-20 17:07:02 -04:00
Michael Layzell
6e4aa770b7 Bug 1391126 - Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER, r=froydnj 2017-09-14 11:00:06 -04:00
Michael Layzell
1d4372a6aa Bug 1389235 - Submit the bhr ping at least once a day, r=froydnj 2017-09-13 11:45:48 -04:00
Doug Thayer
67c03a21e3 Bug 1382440 - Watch CPU usage in BHR r=froydnj
We would like to be able to see if a given hang in BHR occurred
under high CPU load, as this is an indication that the hang is
of less use to us, since it's likely that the external CPU use
is more responsible for it.

The way this works is fairly simple. We get the system CPU usage
on a scale from 0 to 1, and we get the current process's CPU
usage, also on a scale from 0 to 1, and we subtract the latter
from the former. We then compare this value to a threshold, which
is 1 - (1 / p), where p is the number of (virtual) cores on the
machine. This threshold might need to be tuned, so that we
require an entire physical core in order to not annotate the hang,
but for now it seemed the most reasonable line in the sand.

I should note that this considers CPU usage in child or parent
processes as external. While we are responsible for that CPU usage,
it still indicates that the stack we receive from BHR is of little
value to us, since the source of the actual hang is external to
that stack.

MozReview-Commit-ID: JkG53zq1MdY
2017-07-24 13:46:09 -07:00
Michael Layzell
a8a2f5b7ab Bug 1394494 - Use a custom Frame::Kind for special BHR frame types, r=froydnj 2017-09-01 11:47:08 -04:00
Michael Layzell
6524e2195f Bug 1385316 - Include remoteType in BHR ping, r=froydnj 2017-08-30 12:04:16 -04:00
Michael Layzell
26e7d8518a Bug 1385366 - Include timeSinceLastPing in BHR ping payload, data-r=rweiss, r=froydnj 2017-08-30 12:04:11 -04:00
Michael Layzell
c11ceb92f9 Bug 1394331 - Check allocation of hang stack vector, r=froydnj 2017-08-29 13:16:30 -04:00
Michael Layzell
a9d4caa44d Bug 1393915 - Deduplicate consecutive (content script) frames, r=froydnj 2017-08-28 13:17:29 -04:00
Michael Layzell
d4107aaa55 Bug 1390585 - Check the state of BHRTelemetryService in test_BHRObserver.js, r=froydnj 2017-08-24 16:58:27 -04:00
Michael Layzell
4f163befde Bug 1367406 - Part 3: Expose computed modules through .modules getter, r=froydnj
MozReview-Commit-ID: F6aDnlwr9jt
2017-08-16 11:44:05 -04:00
Michael Layzell
8c9d3860d2 Bug 1367406 - Part 2: Add a method for reading module information for native stack frames, r=froydnj
MozReview-Commit-ID: 7gzFhygwXx4
2017-08-16 11:44:04 -04:00
Michael Layzell
9782242b7e Bug 1367406 - Part 1: Add interleaved stack functionality to HangStack, r=froydnj
- This patch was written in 3 interdependent parts, which are described below -

Part 1A: Allow HangStack to contain raw PCs and Module offsets, r=froydnj

The HangStack previously consisted of an array of const char* pointers into its
backing string buffer, which represented pseudostack entries. With interleaved
stacks, it is now possible for the stack to contain raw unresolved program
counters (Kind::PC), and module/offset pairs (Kind::MODOFFSET). To do this, we
use a discriminated union, and make the backing array use the discriminated
union instead of const char*s.

The code cannot use mozilla::Variant<const char*, uintptr_t, Module>
unfortuantely, as we cannot use the implementation of ParamTraits for Variant in
HangStack's ParamTraits implementation.

When deserializing a HangStack over IPC, we need to read the string frame
entries into the backing string buffer, and generate const char* entries for
each of the strings which we read in over IPC. The default implementation of
ParamTraits wouldn't give us access to the enclusing HangStack object while
deserializing each individual entry, so we couldn't use it. In fact, Entries
don't have ParamTraits implemented for them at all, and can only be sent over
IPC as part of a HangStack due to this dependency.

Part 1B: Remove nsIHangDetails.pseudoStack, replace ProcessedStack w/ new HangStack type, r=froydnj

Previously there were two stack objects on each HangDetails object: mStack and
mPseudoStack. mStack was a Telemetry::ProcessedStack, while mPseudoStack was a
HangStack. After the changes in part 1A, HangStack can now contain all of the
information of both the old HangStack and ProcessedStack, so the mPseudoStack
field is renamed to mStack, and the old mStack field is removed.

This patch also implements the new GetStack getter, which generates the JS data
format for the new HangStack type.

Part 1C: Collect interleaved stacks w/ ProfilerStackCollector API in ThreadStackHelper, r=froydnj

This new API was added by njn in bug 1380286, and provides both pseudostack and
native stack entries to the consumer of the API.

This patch changes ThreadStackHelper to use this new API instead of the previous
one, and use it to collect the frames directly into HangStack objects.
2017-08-16 11:44:02 -04:00
Michael Layzell
ab871b0fef Bug 1386369 - Part 2: Stop emitting bhr-thread-hang in the content process, r=froydnj
MozReview-Commit-ID: 1A7CorZepdQ
2017-08-15 16:36:26 -04:00
Michael Layzell
190ff63a67 Bug 1386369 - Part 1: Change test_BHRObserver to not listen to bhr-thread-hang in content, r=froydnj
MozReview-Commit-ID: 7nFBdtiXFc2
2017-08-15 16:36:24 -04:00
Michael Layzell
60af5f32f4 Bug 1380081 - Part 15: Don't try to submit bhr ping to telemetry while running tests, r=chutten 2017-08-15 16:36:22 -04:00
Michael Layzell
2a766e35f9 Bug 1380081 - Part 14: Include BHRTelemetryService and xpt files in the package, r=froydnj
MozReview-Commit-ID: IH56INaSOoK
2017-08-15 16:35:52 -04:00
Michael Layzell
db9fdc8dba Bug 1380081 - Part 12: Add a test for BHR observer notifications, r=froydnj
This patch just adds some tests for the new stuff which we added.

MozReview-Commit-ID: 2jG75AEUJfS
2017-08-15 16:35:48 -04:00
Michael Layzell
429b4e3eb7 Bug 1380081 - Part 11: Simplify the HangAnnotations abstraction, r=froydnj
HangAnnotations was very complex, required a separate allocation, and used this
unfortunate virtual interface implementation which made it harder to do
interesting things with it (such as serialize it over IPC).

This new implementation is much simpler and more concrete, making
HangAnnotations simply be a nsTArray<Annotation>. This also simplifies some of
the IPC code which was added in part 7.

MozReview-Commit-ID: EzaaxdHpW1t
2017-08-15 16:35:46 -04:00
Michael Layzell
f0df38d651 Bug 1380081 - Part 10: Stop running BHR on beta, r=froydnj
These changes are going to increase the amount of data which we collect from BHR
a lot. It would be dangerous to run it on beta, especially considering how soon
the next merge is.

This should turn it off for 100% of beta users if I understand the logic
correctly.

MozReview-Commit-ID: 3HyEKWdXaqU
2017-08-15 16:35:44 -04:00
Michael Layzell
8b6737b250 Bug 1380081 - Part 9: Transmit BHR Hangs from the Content and GPU process to the parent process, r=froydnj
BHRTelemetryService only runs in the parent process (and we can only submit
pings from there), so we need to send the data which we collect in the GPU and
Content processes over IPC to the parent process.

MozReview-Commit-ID: 8B5uZKbjNbU
2017-08-15 16:35:42 -04:00
Michael Layzell
82cfe949bd Bug 1380081 - Part 8: Report bhr-thread-hang hangs to telemetry in a custom bhr ping, r=froydnj
This patch adds the BHRTelemetryService which is a JS implemented XPCOM service
that simply listens to the bhr-thread-hang observer notification, and uses the
data it collects from it to submit telemetry pings.

MozReview-Commit-ID: 2hPXAFmHrm5
2017-08-15 16:35:41 -04:00
Michael Layzell
f2fe978e6f Bug 1380081 - Part 7: Add all necessary data for BHR to nsIHangDetails, r=froydnj
We're going to use HangDetails as the type containing hang information. We'll
have a JS component which reads the data out of nsIHangDetails, builds the
payload, and submits it to telemetry for us.

We'll do it in JS because telemetry has to be submitted from JS.

This patch also adds IPC serization for the relevant types so that we can send
HangDetails objects over IPDL.

MozReview-Commit-ID: CeikKabY9Vs
2017-08-15 16:35:39 -04:00
Michael Layzell
7b4695ef97 Bug 1380081 - Part 4: Move BHR into its own component, r=froydnj
MozReview-Commit-ID: 7TOGofAYM6W
2017-08-15 16:35:00 -04:00
Sebastian Hengst
8b5eefd3f4 Backed out changeset 68bec6464338 (bug 1380081) 2017-08-11 09:28:42 +02:00
Sebastian Hengst
e67b0c168b Backed out changeset 6bc453505dc3 (bug 1380081) 2017-08-11 09:28:27 +02:00
Sebastian Hengst
9e599f14b6 Backed out changeset 8d0b5e469b69 (bug 1380081) 2017-08-11 09:28:21 +02:00
Sebastian Hengst
8f0930b207 Backed out changeset 0b6c4c95323e (bug 1380081) 2017-08-11 09:28:16 +02:00
Sebastian Hengst
f65468ad4e Backed out changeset d34e59a86079 (bug 1380081) 2017-08-11 09:28:11 +02:00
Sebastian Hengst
403fe2bb62 Backed out changeset 9158ca4292bb (bug 1380081) 2017-08-11 09:28:06 +02:00