Jonathan Watt
485934e076
Bug 1110460, part 5 - Factor out a nsStyleBasicShape::GetShapeTypeName method. r=dholbert
2016-02-17 00:19:27 +00:00
CJKu
ae0aff30d1
Bug 1244628: compare nsStyleImageLayers::mAttachmentCount in nsStyleImageLayers::CalcDifference. r=dbaron.
2016-02-04 14:11:35 +08:00
Markus Stange
c1663a433e
Bug 1241275 - Change the way -moz-window-dragging works. r=heycam,roc
...
This adds the value -moz-window-dragging: default as the initial value of the property,
and makes it a [reset] property. This allows us to change the way the window dragging
region is calculated: Elements with -moz-window-dragging: no-drag will now always be
undraggable, even if they are overlapped by -moz-window-dragging: drag elements. That
way we can keep the region calculation simple and don't have to add code to respect
z-ordering.
2016-01-27 11:58:33 +01:00
CJKu
3ac42bd03c
Bug 686281 - Rename nsStyleSVGReset::mLayers to nsStyleSVGReset::mMask; Rename nsStyleBackground::mLayers to nsStyleBackground::mImage. r=dbaron
2016-01-28 06:39:00 +01:00
CJKu
4aebbc124c
Bug 686281 - Remove nsStyleSVGReset::mMask; r=dbaron
2016-01-28 06:37:00 +01:00
CJKu
bf17fc7340
Bug 686281 - Implement CSS mask style; r=dbaron.
2016-01-28 06:28:00 +01:00
CJKu
ff44f07acd
Bug 686281 - Rename *background* to *imagelayer*; r=dbaron.
2016-01-28 06:27:00 +01:00
CJKu
d5371994d3
Bug 686281 - Implement nsStyleImageLayers; r=dbaron
2016-01-28 06:24:00 +01:00
Cameron McCormack
bef1844e92
Bug 1238403 - Fix inconsistent indenting in layout/style/. r=xidorn
2016-01-11 10:28:35 +11:00
Mats Palmgren
6d8ef8591f
Bug 1233106 part 1 - [css-align] Update align-/justify-* properties to the current CSS Align spec (adding 'normal' keyword, dropping 'auto' in some cases etc). r=dholbert
...
The CSSWG minutes for reference:
https://lists.w3.org/Archives/Public/www-style/2015Dec/0233.html
With subsequent correction for the root node:
https://lists.w3.org/Archives/Public/www-style/2016Jan/0015.html
2016-01-05 21:27:13 +01:00
Chris Peterson
e7aeaf5747
Bug 1235306 - Fix -Wimplicit-fallthrough warnings in layout/. r=dholbert
...
layout/base/nsCSSRendering.cpp:3913:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:3943:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:4066:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:4096:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRenderingBorders.cpp:646:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:4639:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:4659:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:5004:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:5200:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/TouchManager.cpp:192:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/TouchManager.cpp:196:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2497:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2687:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2973:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4277:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4310:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4313:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:6703:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:6751:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsGridContainerFrame.cpp:2649:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsGridContainerFrame.cpp:935:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1141:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1145:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1148:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:2942:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:2958:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:3134:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:3150:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/printing/nsPrintPreviewListener.cpp:199:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/CSSLexer.cpp:129:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:1069:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:366:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:442:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:981:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:3597:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:3616:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:539:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:540:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:542:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10628:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10630:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10671:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10673:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10769:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10770:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10774:43 [-Wimplicit-fallthrough] fallthrough annotation does not directly precede switch label
layout/style/nsCSSParser.cpp:10775:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10776:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10780:43 [-Wimplicit-fallthrough] fallthrough annotation does not directly precede switch label
layout/style/nsCSSParser.cpp:2542:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:2715:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:4124:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:4313:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9513:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9697:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9699:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9743:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9745:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9826:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9827:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9832:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9833:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9980:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:160:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:187:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:722:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:753:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:139:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:1687:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:1869:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/FixedTableLayoutStrategy.cpp:264:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/FixedTableLayoutStrategy.cpp:267:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:1043:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:930:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:953:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:997:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6943:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6953:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6959:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6966:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6974:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7151:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7161:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7170:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7177:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7186:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableRowFrame.cpp:663:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:112:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:142:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:157:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:86:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:87:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:88:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:90:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsSliderFrame.cpp:551:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsSliderFrame.cpp:560:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsXULPopupManager.cpp:2268:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-22 21:33:47 -08:00
Xidorn Quan
91bf3a9273
Bug 1229278 - Fix dynamic changes to text-emphasis-style. r=dbaron
2015-12-08 12:55:01 -05:00
Xidorn Quan
ea486eaa10
Bug 1225018 part 1 - Trigger reflow on some text emphasis changes for line height calculation. r=dbaron
2015-12-08 12:55:01 -05:00
Xidorn Quan
e2a9789117
Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013) for reftest failures on CLOSED TREE
2015-12-04 13:08:17 +11:00
Xidorn Quan
3c82f99766
Bug 1229278 - Fix dynamic changes to text-emphasis-style. r=dbaron
2015-12-04 11:58:59 +11:00
Xidorn Quan
485964af30
Bug 1225018 part 1 - Trigger reflow on some text emphasis changes for line height calculation. r=dbaron
2015-12-04 11:58:59 +11:00
L. David Baron
9882014b12
Bug 1224251 patch 3 - Return nsChangeHint_UpdateUsesOpacity when opacity changes between 1 and non-1. r=xidorn
2015-11-30 21:25:54 -08:00
L. David Baron
136a157a4f
Bug 1227766 patch 3 - Make will-change cause creation of a containing block for fixed and absolutely positioned elements when needed. r=dholbert
2015-11-30 15:46:44 -08:00
L. David Baron
fd5897e3cd
Bug 1228501 patch 4 - Remove nsStyleFont::CalcFontDifference, which now duplicates the list of tests in nsFont::Equals. r=jdaggett
2015-11-30 14:02:25 -08:00
L. David Baron
fe8e08e802
Bug 1228501 patch 2 - Remove nsFont::decorations member variable. r=jdaggett
...
The member variable was always set to 0 or to NS_FONT_DECORATION_NONE,
which is 0.
Although this does leave a gap in the structure, I don't see any
opportunities for reordering members to actually shrink nsFont.
2015-11-30 14:02:25 -08:00
Carsten "Tomcat" Book
17dd3eef29
Backed out changeset 91898a35b414 (bug 1224251)
2015-11-30 12:10:43 +01:00
Carsten "Tomcat" Book
e54a0bc16a
Backed out changeset 3a3cd254f508 (bug 1228501)
2015-11-30 12:10:38 +01:00
Carsten "Tomcat" Book
1c3df9533b
Backed out changeset ec79945130ff (bug 1228501)
2015-11-30 12:10:35 +01:00
L. David Baron
3a88c49bad
Bug 1228501 patch 4 - Remove nsStyleFont::CalcFontDifference, which now duplicates the list of tests in nsFont::Equals. r=jdaggett
2015-11-29 23:15:26 -08:00
L. David Baron
98e2ba466f
Bug 1228501 patch 2 - Remove nsFont::decorations member variable. r=jdaggett
...
The member variable was always set to 0 or to NS_FONT_DECORATION_NONE,
which is 0.
Although this does leave a gap in the structure, I don't see any
opportunities for reordering members to actually shrink nsFont.
2015-11-29 23:15:01 -08:00
L. David Baron
1596db2fce
Bug 1224251 patch 3 - Return nsChangeHint_UpdateUsesOpacity when opacity changes between 1 and non-1. r=xidorn
2015-11-29 23:15:01 -08:00
Mats Palmgren
b1738be95a
Bug 1225376 part 1 - [css-align] Don't compute left/right to start in the style system anymore (due to pending spec change). Map the used value instead (in layout). r=dholbert
...
For background, see this www-style thread:
https://lists.w3.org/Archives/Public/www-style/2015Nov/0280.html
2015-11-28 21:37:44 +01:00
Xidorn Quan
e437717e1e
Bug 1040668 part 15 - Make the default value of text-emphasis-position aware of the language. r=dbaron
2015-11-28 11:56:33 +11:00
Xidorn Quan
c91d09b415
Bug 1040668 part 13 - Move first part of nsStyleFont::GetLanguage to nsPresContext::GetContentLanguage. r=dbaron
2015-11-28 11:56:33 +11:00
Xidorn Quan
713c472a8d
Bug 1040668 part 10 - Implement emphasis mark rendering. r=jfkthame
2015-11-28 11:56:33 +11:00
Xidorn Quan
0856abb2ea
Bug 1040668 part 2 - Parse and compute text emphasis properties. r=dbaron
2015-11-28 11:56:33 +11:00
L. David Baron
5c3ac7c18c
Bug 1227501 patch 3 - Handle custom properties correctly in transition-property. r=xidorn
...
Without the code change, the property_database.js changes lead to:
* 3 failures in test_value_cloning.html (one each for
transition-property, -moz-transition-property, and
-webkit-transition-property) that "computed value should be nonempty"
* 6 failures in test_value_computation.html (two each for
*transition-property) that "should not get empty value"
* 16 failures in test_value_storage.html "parse+compute+serialize...
should be idempotent": 2 for each longhand, 2 for the shorthand for
the unprefixed, and 4 for the shorthand for each prefixed
2015-11-24 17:45:02 -08:00
Mats Palmgren
f0324b0370
Bug 1226627 - Truncate the result in ZoomText/UnZoomText rather than rounding it for better performance. r=roc
2015-11-21 04:41:00 +01:00
Boris Chiou
842f2123db
Bug 1215406 - Part 2: Change the types of direction and fillmode in StyleAnimation. r=heycam
...
Use scoped enum mozilla::dom::FillMode and mozilla::dom::PlaybackDirection,
instead of uint8_t in StyleAnimation.
2015-11-20 06:09:00 +01:00
L. David Baron
cab615e8d5
Bug 1223653 patch 2 - Use an enum class for NS_STYLE_BOX_SIZING_*. r=heycam
...
The casts in nsCSSProps.cpp (defining kBoxSizingKTable) and in
nsComputedDOMStyle::DoGetBoxSizing (using
nsCSSProps::ValueToKeywordEnum) are a little bit annoying, though aren't
a net reduction in typesafety.
The casts in nsRuleNode.cpp (SetDiscrete) are a little more annoying,
though the change in this patch should be sufficient for converting all
properties -- but that may also mean reducing typesafety a bit for all
properties.
I'd like to find something better to do about them, but I think I'm ok
landing this before doing that. Bug 1224918 covers doing better.
2015-11-19 18:09:29 -08:00
Mats Palmgren
f0d397f047
Bug 1176792 part 1 - [css-grid] Implement the 'grid-column-gap', 'grid-row-gap', and 'grid-gap' properties in the style system. r=dholbert,dbaron
2015-11-18 19:52:27 +01:00
Mats Palmgren
82bc9e2c9b
Bug 576927 - Use saturating multiply when calculating zoomed app units to avoid integer overflow. r=roc
2015-11-16 17:32:39 +01:00
Wes Kocher
56a494823d
Backed out changeset cbc8ceae73a2 (bug 576927) for test_value_cloning.html bustage CLOSED TREE
2015-11-16 11:00:32 -08:00
Mats Palmgren
4cb197ac1a
Bug 576927 - Use saturating multiply when calculating zoomed app units to avoid integer overflow. r=roc
2015-11-16 17:32:39 +01:00
Daniel Holbert
97641f1556
Bug 1223568: Don't let fallback alignment values break flexbox special-case for "justify-content: stretch". r=mats
2015-11-11 14:42:21 -08:00
Mats Palmgren
3149757e26
Bug 1176782 part 6 - [css-align] Implement additional syntax and values for the 'align-content' property in the style system. r=cam
2015-11-03 15:18:06 +01:00
Mats Palmgren
623054f187
Bug 1176782 part 5 - [css-align] Implement additional syntax and values for the 'align-self' property in the style system. r=cam
2015-11-03 15:18:06 +01:00
Mats Palmgren
e0422d1e26
Bug 1176782 part 4 - [css-align] Implement additional syntax and values for the 'align-items' property in the style system. r=cam
2015-11-03 15:18:05 +01:00
Mats Palmgren
c3f3c9abcd
Bug 1176782 part 3 - [css-align] Implement additional syntax and values for the 'justify-content' property in the style system. r=cam
2015-11-03 15:18:05 +01:00
Mats Palmgren
1b223d253e
Bug 1176782 part 2 - [css-align] Implement the 'justify-self' property in the style system. r=SimonSapin
2015-11-03 15:18:05 +01:00
Mats Palmgren
f9f7acdb17
Bug 1176782 part 1 - [css-align] Implement the 'justify-items' property in the style system. r=SimonSapin
2015-11-03 15:18:05 +01:00
Markus Stange
e088587ab1
Bug 1201327 - Don't repaint the whole frame subtree when background-position changes. r=dbaron
2015-11-02 17:36:35 +01:00
L. David Baron
831fc09979
Bug 1216431 patch 2 - Pass nsStyleVisibility to nsStylePosition::CalcDifference to avoid computing new nsStyleVisibility during nsStyleContext::CalcStyleDifference. r=heycam
...
This is needed to avoid hitting the assertion:
Assertion failure: !!(structsFound & (1 << uint64_t(eStyleStruct_Visibility))) == !!PeekStyleVisibility() (PeekStyleData results must not change in the middle of difference calculation.), at ./nsStyleStructList.h:62
once exact PeekStyleData is backed out in the later patches.
Without this patch, we can compute a new nsStyleVisibility struct inside
of nsStylePosition::CalcDifference. This patch ensures we use
PeekStyleVisibility() instead of StyleVisibility().
2015-10-23 08:57:35 +09:00
Nicholas Nethercote
92e5e88b56
Bug 1038663 (part 1) - Make nsStyleText::mWordSpacing an nsStyleCoord. r=heycam.
...
This makes mWordSpacing a lot more like mLetterSpacing, while maintaining the
existing "'normal' computes to 0px" behaviour.
2015-10-21 22:13:11 -07:00
Xidorn Quan
66e929986f
Bug 1165538 part 2 - Add -moz-min-font-size-ratio internal property. r=heycam
2015-10-08 10:19:29 +11:00