Commit Graph

1056 Commits

Author SHA1 Message Date
Cameron McCormack
1fc3436c96 Back out a0488e9c0024..5ebcedea1fa5 (bug 1288302 and bug 1310463) for Talos RSS regressions.
MozReview-Commit-ID: JB5uwDeO0We
2016-11-01 08:42:49 +08:00
Cameron McCormack
01a9551268 Backed out changeset 288d92c34790 (bug 1311921) for being an inadequate Talos regression fix.
MozReview-Commit-ID: DMQ4Hibdm6h
2016-11-01 08:33:26 +08:00
Cameron McCormack
9716f55b56 Bug 1310463 - Part 1: Make list-style-image use nsStyleImageRequest for storage. r=xidorn
MozReview-Commit-ID: ENTo2HNbBpN
---
 layout/style/nsRuleNode.cpp    |  8 ++++----
 layout/style/nsStyleStruct.cpp | 15 +++++++++++++--
 layout/style/nsStyleStruct.h   | 18 ++++++------------
 3 files changed, 23 insertions(+), 18 deletions(-)
2016-10-20 08:53:45 +08:00
Cameron McCormack
b874e422c9 Bug 1288302 - Part 5: Make nsStyleImage use nsStyleImageRequest. r=bholley
This makes background-image, mask-image and border-image settable
from Servo.

Since imgRequestProxy resolution in nsStyleImages can now happen later than
at computed value setting time, and that resolution can fail,
nsStyleImage::GetImageData() might now return null.  So all of the users of
nsStyleImage now null check its result.

MozReview-Commit-ID: FMRUrC3SfOs
2016-10-20 08:36:25 +08:00
Cameron McCormack
b2af7454a9 Bug 1288302 - Part 3: Add nsStyleImageRequest. r=xidorn,bholley
MozReview-Commit-ID: F763Dv0Nfzp
2016-10-20 08:36:21 +08:00
Cameron McCormack
3f9607e7d4 Bug 1288302 - Part 2: Pass ImageTracker to style struct image tracking methods instead of nsPresContext. r=xidorn
MozReview-Commit-ID: AsGfXliHLRf
2016-10-20 08:36:16 +08:00
Adam Velebil
72138e6b9f Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ; r=manishearth,xidorn
MozReview-Commit-ID: LHT6Aa2ojlf
2016-10-28 06:17:20 +02:00
Adam Velebil
76d136e726 Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ; r=manishearth,xidorn
MozReview-Commit-ID: 7I7Z4q7mLtC
2016-10-29 10:51:05 +02:00
Adam Velebil
8425f11c26 Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ; r=manishearth,xidorn
MozReview-Commit-ID: IA4bGLgRxd6
2016-10-23 22:41:49 +02:00
Cameron McCormack
be15f6f37d Bug 1311921 - Store base and relative URIs explicitly in nsStyleImageRequests for comparison purposes, rather than use css::ImageValues. r=bholley
MozReview-Commit-ID: 5aArKCI7Rhx
2016-10-28 14:34:33 +08:00
cku
8e3d719b1c Bug 1309646 - Part 3. Use nsChangeHint_UpdateBackgroundPosition in position mask. r=mstange
MozReview-Commit-ID: CeLPAN8OdhF
2016-10-13 18:35:35 +08:00
L. David Baron
532b9389f2 Bug 1307853 - Set inline-resize flag when the content-box size is changing (in addition to border-box). r=mats
MozReview-Commit-ID: FjUwuQB8g5j
2016-10-13 11:41:52 -07:00
Ting-Yu Lin
4d21b059b4 Bug 1309813 - Reland list-initialization for array. r=heycam
This effectively reverts this patch.
https://hg.mozilla.org/mozilla-central/rev/cf209d9bc29c

MozReview-Commit-ID: GQSvTiKvoaC
2016-10-13 03:33:00 +08:00
Cameron McCormack
92e70f0cf6 Bug 1309082 - Part 2: Rename some ImageTracker members. r=bholley
MozReview-Commit-ID: 6yOIKKl8npT
2016-10-13 15:04:19 +08:00
Cameron McCormack
a8ce0e16c4 Bug 1309082 - Part 1: Extract image tracking from nsDocument into a separate, refcounted object. r=bholley
This is refcounted as we'll need to hold strong references to the ImageTracker
from style structs that load images.

MozReview-Commit-ID: 994gE9tOjAn
2016-10-13 15:04:15 +08:00
cku
dcd73f0282 Bug 1308963 - Part 3. Set initial value of mask-position as (0, 0). r=xidorn
MozReview-Commit-ID: DN7q6FrGEMA
2016-10-13 23:13:11 +08:00
cku
42b203b91b Bug 1308963 - Part 1. Set initial value of mask-repeat as repeat. r=xidorn
MozReview-Commit-ID: 8VrPiEyKF4n
2016-10-13 22:57:10 +08:00
Cameron McCormack
a9fde7344c Bug 1298774 - Part 9: Remove FragmentOrURL. r=cjku
MozReview-Commit-ID: Du10tRgKtQ4
2016-10-11 14:56:12 +08:00
Cameron McCormack
433830e46c Bug 1298774 - Part 8: Make mask-image use css::URLValueData for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: 2Xm3IP3SXK0
2016-10-11 14:56:12 +08:00
Cameron McCormack
1a1523e02c Bug 1298774 - Part 7: Make nsStyleFilter use css::URLValue for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: FyhH9QG9vYq
2016-10-11 14:56:12 +08:00
Cameron McCormack
0dc5a78c72 Bug 1298774 - Part 6: Make SVG marker properties use css::URLValue for storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: 8OQWmDpP7Ax
2016-10-11 14:56:11 +08:00
Cameron McCormack
7e89cd1f28 Bug 1298774 - Part 5: Make nsStyleSVGPaint use css::URLValue for url() storage instead of FragmentOrURL. r=cjku
MozReview-Commit-ID: CkNcSxVToTL
2016-10-11 14:56:11 +08:00
Cameron McCormack
4925674adc Bug 1298774 - Part 2: Rename URLValueData::mLocalURLFlag to match FragmentOrURL::mIsLocalRef naming. r=cjku
MozReview-Commit-ID: A9NHxMfPRSF
2016-10-11 14:56:11 +08:00
Brad Werth
dd331658a6 Bug 1305844 - Make most align/justify nsStylePosition members public, and remove trivial accessors. r=dholbert 2016-10-03 13:05:35 -07:00
Xidorn Quan
0c3f0f9582 Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
MozReview-Commit-ID: J5Fp0iAEnkg
2016-10-25 17:25:10 +11:00
Wes Kocher
14ee8c57e9 Backed out changeset 9b715399e585 (bug 1310123) for build failures a=backout CLOSED TREE 2016-10-25 16:54:45 -07:00
Xidorn Quan
145fe0f429 Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
MozReview-Commit-ID: J5Fp0iAEnkg
2016-10-25 17:25:10 +11:00
Adam Velebil
2c22de0ff7 Bug 1312173 - Convert NS_STYLE_USER_INPUT_* to an enum class; r=manishearth,xidorn
MozReview-Commit-ID: sYiJrZryrA
2016-10-23 00:08:18 +02:00
Manish Goregaokar
f35d90e274 Bug 1311959 - Remove marker-offset; r=tromey,xidorn
MozReview-Commit-ID: 72Fse0z1BiY
2016-10-21 15:34:46 +05:30
Brad Werth
1148c21217 Bug 1304012 -- Part 2: Rename nsStyleStruct Computed**Self functions to Used**Self. r=dholbert
MozReview-Commit-ID: FCBuT2Z7sy6
2016-09-30 09:15:57 -07:00
Carsten "Tomcat" Book
8ec316a2dc merge mozilla-inbound to mozilla-central a=merge 2016-09-30 12:02:16 +02:00
Xidorn Quan
1cfc0298d4 Bug 1266621 part 5 - Convert border-color to store complex color. r=heycam
MozReview-Commit-ID: 19sl9f3EVgt
2016-09-27 20:16:35 +10:00
Xidorn Quan
793cd1a575 Bug 1266621 part 3 - Convert outline-color to store complex color. r=heycam
MozReview-Commit-ID: 70tre2pYqi3
2016-09-27 20:44:19 +10:00
Xidorn Quan
af621198c0 Bug 1266621 part 2 - Convert column-rule-color to store complex color. r=heycam
MozReview-Commit-ID: AB2b5CPABOZ
2016-09-27 20:12:08 +10:00
Xidorn Quan
0e32e46079 Bug 1266621 part 1 - Convert text-decoration-color to store complex color. r=heycam
MozReview-Commit-ID: LEGICgvgQDY
2016-09-27 20:19:48 +10:00
Cameron McCormack
46699975f3 Bug 1305376 - Use nsTArray for cursor image list storage. r=xidorn
MozReview-Commit-ID: 2uRGInQmNYU
2016-09-29 10:55:55 +08:00
L. David Baron
782a7e5b57 Bug 1301500 - Separate change hint for adding/removing transform from UpdateContainingBlock. r=heycam
MozReview-Commit-ID: FwEQDA327EI
2016-09-29 14:15:32 -07:00
Jeremy Chen
c4d8177681 Bug 1305004 - fix ReResolveStyleContext related comments. r=heycam
Fix comment only, NPOTB, DONTBUILD.

MozReview-Commit-ID: APxOg5yVw7A
2016-09-23 18:08:01 +08:00
cku
b4e17130be Bug 1304437 - Part 1. Return nsChangeHint_UpdateEffects when the length of the mask-image property has changed. r=heycam
MozReview-Commit-ID: 8ETx873Atu7
2016-09-22 18:24:52 +08:00
Cameron McCormack
4c081b683c Bug 1304632 - Part 2: Remove unnecessary nsStyleImage::mImage null checking. r=bholley
nsStyleImage::mImage is always set to a non-null object when its mType
is eStyleImageType_Image, so let's just assert that and stop null
checking in that case.

MozReview-Commit-ID: 2ect4coV0LV
2016-08-15 09:57:13 +08:00
Xidorn Quan
dcfa696ded Bug 1299741 part 11 - Change text-{emphasis,fill,stroke}-color to using StyleComplexColor. r=dbaron
MozReview-Commit-ID: 1MlgGAkdPn8
2016-09-16 14:40:45 +10:00
Carsten "Tomcat" Book
e426d2d1e9 Merge mozilla-central to autoland 2016-09-09 12:19:59 +02:00
Manish Goregaokar
49b3b83008 Bug 1300337 - Replace None_ variants from nsStyleConsts.h with None; r=heycam,TYLin
MozReview-Commit-ID: CxHzbEzjLxT
2016-09-04 00:16:58 +05:30
Nicholas Nethercote
c57fffaa55 Bug 1297300 - Add missing checks to GetSpec() calls in layout/. r=dholbert,heycam. 2016-08-31 20:10:10 +10:00
Jeremy Chen
351de41d83 Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. r=xidorn
After using enum class, a switch-case warning in CombineBreakType is caught.
This is one of such kind safty checks that we would like to gain.
Fix it by adding default case for switch-case in CombineBreakType.

MozReview-Commit-ID: BdS3LPN6qzX
2016-09-07 10:20:17 +08:00
Cameron McCormack
1432f1a16b Bug 1297963 - Part 3: Use OMT-safe function for -moz-binding comparisons in CalcDifference. r=emilio
MozReview-Commit-ID: 6n7j2DrAVFv
2016-09-03 00:22:48 +10:00
Emilio Cobos Álvarez
2efcfaad38 Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz
The main renaming was generated with the following python script:

```

import sys
import re

CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)")
DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b")

def to_camel_case(ident):
  return re.sub(CAMEL_CASE_REGEX,
                lambda m: m.group(2) + m.group(3).lower(), ident)

def constant_to_enum(constant):
  return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "")

def process_line(line):
  return re.sub(DISPLAY_REGEX,
                lambda m: constant_to_enum(m.group(1)), line)

lines = []
with open(sys.argv[1], "r") as f:
  for line in f:
    lines.append(process_line(line))

with open(sys.argv[1], "w") as f:
  for line in lines:
    f.write(line)
```

And the following shell commands:

```
find . -name '*.cpp' -exec python display.py {} \;
find . -name '*.h' -exec python display.py {} \;
```

MozReview-Commit-ID: 91xYCbLC2Vf
2016-09-01 20:41:17 -07:00
Ryan VanderMeulen
baab66fb35 Backed out 5 changesets (bug 1298768, bug 1297963) for causing widespread mochitest-bc failures.
Backed out changeset dedd56fa5c54 (bug 1297963)
Backed out changeset bc1ac59cfe8f (bug 1297963)
Backed out changeset a2e337d5aa02 (bug 1297963)
Backed out changeset e73da71408a3 (bug 1297963)
Backed out changeset 56f8bca8f8e8 (bug 1298768)

CLOSED TREE
2016-09-01 08:05:43 -04:00
Cameron McCormack
6245348615 Bug 1297963 - Part 3: Use OMT-safe function for -moz-binding comparisons in CalcDifference. r=emilio
MozReview-Commit-ID: 2PkR5tUMMy0
2016-08-29 18:17:26 +08:00
Ravi Shankar
27b0e2b9f2 Bug 1297982 - Replace NS_STYLE_BOX_ORIENT_* with enum class; r=xidorn
MozReview-Commit-ID: GC0VRyHUM4V
2016-08-26 12:48:41 +05:30