corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
535,524 Commits 1 Branch 0 Tags
fea80dfb51a70ceb871386c7aab9fb396e4f255e
Commit Graph

108 Commits

Author SHA1 Message Date
Xidorn Quan
154deecdcc Bug 1372790 - Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. r=heycam 
MozReview-Commit-ID: DddIzhJqmcZ
 2017-06-14 14:26:48 +10:00
L. David Baron
03d37750a7 Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam 
As I've said before, as module owner I prefer that MOZ_ASSERT_IF not be
used in the module because I consider it to be unreadable.  However, a
few uses have crept in, and this patch removes them.

I consider it to be unreadable because the name looks like a name that
uses smalltalk-ish naming conventions, i.e., with a part of the name
corresponding to each parameter, in order.  However, the parameters are
in the order opposite the name.

This was written primarily with the vim commands:
:%s/MOZ_ASSERT_IF(\([^,]*\),/MOZ_ASSERT(!\1 ||/
:wn
followed by manual cleanup for indentation and removal of !!.

MozReview-Commit-ID: G6rLbOn7k8d
 2017-06-06 22:27:17 -07:00
Xidorn Quan
b68a3b8b64 Bug 1262963 - Add env var for bypassing origin check of cssom. r=heycam 
MozReview-Commit-ID: 2iMx3sz1QKS
 2016-11-29 18:03:01 +11:00
Emilio Cobos Álvarez
02e12853ab Bug 1368986: Cleanup stylesheet copy-constructor. r=heycam 
MozReview-Commit-ID: I8vUuJfET24
 2017-05-31 13:12:33 +02:00
Emilio Cobos Álvarez
0d0c9b1ab4 Bug 1368690: Move EnsureUniqueInner call after all the members have been initialized. r=xidorn 
MozReview-Commit-ID: GoeLsjSAU00
 2017-05-31 13:05:15 +02:00
Xidorn Quan
08c91e75e4 Bug 1352968 part 7 - Make RuleHasPendingChildSheet a static method of StyleSheet. r=heycam 
MozReview-Commit-ID: HPJgsFftT6f
 2017-05-30 11:10:25 +10:00
Xidorn Quan
6a6b1408bb Bug 1352968 part 4 - Change the direction of child stylesheet list. r=heycam 
It seems no one actually care about the order of the list, and the order
is completely meaningless if the script insert new @import rules.

Changing the order makes inserting faster, and make it easier for later
patch to get the latest inserted child sheet.

MozReview-Commit-ID: 72eKqVoPbZ7
 2017-05-30 11:10:25 +10:00
Xidorn Quan
477205b2b5 Bug 1352968 part 2 - Move mOwnerRule to StyleSheet and use dom::CSSImportRule instead of css::ImportRule. r=heycam 
MozReview-Commit-ID: DTAWGHIUAQX
 2017-05-30 11:10:25 +10:00
Emilio Cobos Álvarez
b7a7a08a94 Bug 1357583: Remove ServoStyleSheet::ClearRuleCascades. r=heycam 
These invalidations are already handled from the PresShell notifications, no
need to handle it somewhere else.

MozReview-Commit-ID: G9KDVvSKMJY
 2017-05-29 23:01:26 +02:00
Emilio Cobos Álvarez
d94e8fcc32 Bug 1367553: Avoid import hell in StyleSheet.h. r=emilio 
MozReview-Commit-ID: DR4xURkcFcA
 2017-05-25 16:11:13 +02:00
Brad Werth
fdeacb1873 Bug 1339629 Part 10: Implement ServoStyleSet::EnsureUniqueInnerOnCSSSheets. r=heycam 
MozReview-Commit-ID: GuUqKYrV60z
 2017-05-15 17:11:08 -07:00
Brad Werth
84b701f39e Bug 1339629 Part 9: Uplift EnsureUniqueInnerOnCSSSheets and SetNeedsRestyleAfterEnsureUniqueInner into StyleSetHandle, and eliminate CSSStyleSheet::EnsureUniqueInner. r=heycam 
MozReview-Commit-ID: LH7vTKUmuv8
 2017-05-15 16:30:10 -07:00
Brad Werth
d5d552db30 Bug 1339629 Part 8: Uplift ClearRuleCascades into StyleSheet. r=heycam 
MozReview-Commit-ID: CCYIYjWrw86
 2017-05-18 14:21:11 -07:00
Brad Werth
26ed5d2848 Bug 1339629 Part 6: Uplift mStyleSets into StyleSheet. r=heycam 
MozReview-Commit-ID: G8xQ5gLJ3dr
 2017-05-15 16:27:15 -07:00
Brad Werth
720274de63 Bug 1339629 Part 4: Uplift CloneFor into StyleSheetInfo, and EnsureUniqueInner into StyleSheet. r=heycam 
MozReview-Commit-ID: 4aZJYAsmZ2h
 2017-05-15 16:19:17 -07:00
Brad Werth
2fae31f0d5 Bug 1339629 Part 3: Uplift mDirty into StyleSheet. r=heycam 
MozReview-Commit-ID: iZKdg0fWss
 2017-05-15 14:48:24 -07:00
Boris Zbarsky
6fa1539ab5 Bug 1358056. Fix stylesheet handling of associated documents in various edge cases. r=heycam 2017-04-24 15:44:19 -04:00
Emilio Cobos Álvarez
1b872a5700 Bug 1325878: Simplify MediaList creation. r=xidorn 
MozReview-Commit-ID: Jre50YpuD7F
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
 2017-04-13 00:30:12 +08:00
Emilio Cobos Álvarez
33c6bc1551 Bug 1325878: Don't hardode nsMediaList in dom::StyleSheet. r=xidorn 
MozReview-Commit-ID: IynF1NFUSLf
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
 2017-04-13 00:30:09 +08:00
Xidorn Quan
bf22378ea2 Bug 1352763 part 3 - Have ServoStyleSheet also implement nsICSSLoaderObserver. r=heycam 
MozReview-Commit-ID: 1Z6jAmQ9CY6
 2017-04-03 19:55:06 +10:00
Andrea Marchesini
8f5f953fba Bug 1343933 - Renaming Principal classes - part 2 - NullPrincipal, r=qdot 2017-03-22 11:38:40 +01:00
Xidorn Quan
799b5f1cd0 Bug 1315601 part 14 - Add InsertRuleIntoGroup support to ServoStyleSheet. r=heycam 
MozReview-Commit-ID: GUHtvjQXECW
 2017-03-08 18:27:53 +11:00
Xidorn Quan
abb46b4fde Bug 1315601 part 13 - Move common code of DeleteRuleFromGroup/InsertRuleIntoGroup from CSSStyleSheet to StyleSheet. r=heycam 
MozReview-Commit-ID: BDxnYb0OkCk
 2017-03-08 18:04:15 +11:00
Xidorn Quan
a1f85f934d Bug 1315601 part 3 - Add base class MediaList and move part of nsMediaList to it. r=heycam 
MozReview-Commit-ID: A2uJpbGgO55
 2016-11-09 17:28:24 +11:00
Brad Werth
533d5ac5ed Bug 1342869 Part 1: Uplift ChildSheetListBuilder into StyleSheet so that all StyleSheet subclasses can fixup parent chains when children are removed. r=heycam 
MozReview-Commit-ID: F9KnuPC0h7K
 2017-03-06 16:27:32 -08:00
Brad Werth
a2095b5907 Bug 1290218 Part 4b: Fixup cycle collector declarations for mInner moving into StyleSheetInfo. r=heycam 
MozReview-Commit-ID: 9cAvEf7y8JN
 2017-02-15 16:19:33 -08:00
Brad Werth
35fe39a003 Bug 1290218 Part 4: Implement shared mInners for ServoStyleSheets, and standardize calling of AddSheet into CSSStyleSheet and ServoStyleSheet constructors. r=heycam 
MozReview-Commit-ID: 7u89J0WfMcX
 2017-02-17 15:48:35 -08:00
Brad Werth
0ef4bd93de Bug 1290218 Part 2: Uplift mInner pointer from CSSStyleSheetInner into StyleSheetInfo. r=heycam 
MozReview-Commit-ID: K6FbTN1r4Qg
 2017-02-14 09:41:33 -08:00
Brad Werth
6403dc67fc Bug 1328420 Part 8: Uplift SizeOfIncludingThis into StyleSheet, with override in CSSStyleSheet. r=heycam 
MozReview-Commit-ID: 5f1WldhnP2
 2017-01-23 16:42:31 -08:00
Brad Werth
7468980400 Bug 1328420 Part 7: Uplift List debug method into StyleSheet. r=heycam 
MozReview-Commit-ID: 7aqC6N6cZst
 2017-01-23 16:40:28 -08:00
Brad Werth
034e91ce4d Bug 1328420 Part 6: Implement ServoStyleSheet destructor. r=heycam 
MozReview-Commit-ID: iVaza2s7d
 2017-01-23 16:37:59 -08:00
Brad Werth
637dfced70 Bug 1328420 Part 5: Uplift AppendStyleSheet to StyleSheet. r=heycam 
MozReview-Commit-ID: CwNGWsJi65G
 2017-01-23 16:23:40 -08:00
Brad Werth
d2b2e92def Bug 1328420 Part 4: Uplift SetOwningDocument into StyleSheet. r=heycam 
MozReview-Commit-ID: 3TnTaFYkZS3
 2017-01-24 13:12:40 -08:00
Brad Werth
88ca4998cc Bug 1328420 Part 3: Uplift the first child to StyleSheet via a new method, abstracting out the inner sheet concept (which is not present in Stylo sheets). r=heycam 
MozReview-Commit-ID: KUeIlOhAJXr
 2017-01-23 15:52:56 -08:00
Brad Werth
d6c2d2c058 Bug 1328420 Part 1: Uplift parent pointer and accessor to StyleSheet class. r=heycam 
MozReview-Commit-ID: C63yRZM3ORC
 2017-01-24 13:09:33 -08:00
Boris Zbarsky
cdbd6b5265 Bug 1332353. Make it clearer when a stylesheet is really owned by its mDocument. r=heycam 2017-01-19 23:49:44 -05:00
Cameron McCormack
cb58119236 Bug 1323665 - Part 2: Allow StyleSheet.disabled CSSOM access to disable/enable a ServoStyleSheet. r=xidorn 
Now that bug 1290209 has landed, we can make StyleSheet.disabled work in Servo
styled documents.  This fixes a bunch of test crashes due to the assertion no
longer firing.

MozReview-Commit-ID: 6sLrdrxWlvK
 2017-01-09 17:44:30 +08:00
Cameron McCormack
58cbf1f191 Bug 1290209 - Part 8: Move CSSStyleSheet::SetEnabled up to StyleSheet. r=xidorn 
MozReview-Commit-ID: 7shpy5ghnVR
 2017-01-06 15:05:24 +08:00
Cameron McCormack
859fc6143f Bug 1290209 - Part 6: Move CSSStyleSheet::mMedia up to StyleSheet. r=bzbarsky 
MozReview-Commit-ID: LZraHzme6vj
 2017-01-06 15:05:24 +08:00
Xidorn Quan
1125f5e9ab Bug 1323919 - Rename nsIMediaList.h to nsMediaList.h. r=heycam 
MozReview-Commit-ID: Ake5srkKJbf
 2016-12-16 14:50:36 +11:00
Xidorn Quan
3b74963c68 Bug 1307357 part 2 - Fix issues appear after adding file to unified source. r=heycam 
MozReview-Commit-ID: 5FkisMn3LKq
 2016-11-23 10:26:20 +11:00
Xidorn Quan
850976ea9c Bug 1292432 part 9 - Change WebIDL interface of CSSStyleSheet to StyleSheet. r=heycam 
MozReview-Commit-ID: 5AXhsuvvrwe
 2016-10-14 22:25:38 +11:00
Xidorn Quan
3631ceaf3e Bug 1292432 part 8 - Move XPCOM IDL methods which just call WebIDL methods to StyleSheet. r=heycam 
MozReview-Commit-ID: 3xpdLGc6hqH
 2016-10-14 22:25:38 +11:00
Xidorn Quan
d438ebf740 Bug 1292432 part 6 - Make StyleSheet implement GetCssRules/InsertRule/DeleteRule. r=heycam 
MozReview-Commit-ID: KD552jWZnA3
 2016-10-14 22:25:38 +11:00
Xidorn Quan
eef885dbe9 Bug 1292432 part 5 - Unify completeness check and security check to StyleSheet. r=heycam 
MozReview-Commit-ID: CmQ2Q9UrLAA
 2016-10-14 22:25:38 +11:00
Xidorn Quan
4f732ccfd6 Bug 1292432 part 4 - Move SubjectSubsumesInnerPrincipal to StyleSheet. r=heycam 
MozReview-Commit-ID: 1DItyq2QrDz
 2016-10-14 22:25:38 +11:00
Xidorn Quan
42a86c72db Bug 1292432 part 2 - Make StyleSheet inherit nsIDOMCSSStyleSheet. r=heycam 
Some method impls are also moved from CSSStyleSheet to StyleSheet so
that they can be shared between the two subclasses.

The new interface methods added to ServoStyleSheet is currently left
unimplemented. They would be implemented in later patches.

MozReview-Commit-ID: 45wHT9BSHTK
 2016-10-14 22:25:38 +11:00
Xidorn Quan
83118574f0 Bug 1306212 part 3 - Move the only constructor of StyleSheetInfo to StyleSheet.cpp. r=heycam 
MozReview-Commit-ID: Fv2AyBE1Js0
 2016-09-29 16:19:06 +10:00
Xidorn Quan
7d6c4129ab Bug 1304302 part 10 - Replace all uses of StyleSheetHandle. r=heycam 
This commit is generated by the following commands with some minor
manual adjustment:

find . \( -name '*.h' -or -name '*.cpp' \) -not -path './layout/style/StyleSheet*' -exec sed -i -b \
  -e '/^\(#include\|using\)/s/StyleSheetHandle/StyleSheet/g' \
  -e 's/\(mozilla::\)\?StyleSheetHandle::RefPtr/RefPtr<\1StyleSheet>/g' \
  -e 's/StyleSheetHandle()/nullptr/g' \
  -e 's/->AsStyleSheet()//g' \
  -e 's/StyleSheetHandle/StyleSheet*/g' {} +
sed -i -b 's/sheet->AsVoidPtr()/sheet.get()/' layout/style/Loader.cpp
sed -i -b 's/AsHandle()/this/' layout/style/StyleSheet.cpp

MozReview-Commit-ID: 7abdvlKHukd
 2016-09-26 22:03:25 +10:00
Xidorn Quan
1074b680ca Bug 1304302 part 9 - Make StyleSheet::SheetInfo inline. r=heycam 
MozReview-Commit-ID: 9ZvnIBw6emI
 2016-09-26 22:03:25 +10:00