Ting-Yu Lin
122e5b9aeb
Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
2016-01-29 22:42:14 +08:00
Xidorn Quan
ca146f45ac
Bug 1230034 part 5 - Convert all frame properties which use DeleteValue and ReleaseValue as destructor to be typesafe. r=dbaron
...
By changing signature of those two functions, we make compiler complain about
all their existing uses, so we can find all of them and convert them.
Some of the callsites of Get() with those properties are also converted, but not
all of them. It is fine because if there is any incorrect conversion, compilers
is able to find out now. So they are completely typesafe.
2016-01-28 14:23:59 +11:00
Nicholas Nethercote
7fabd8754f
Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
...
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.
The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:
- It adds a comment about the null check in
gfxGlyphExtents::GetTightGlyphExtentsAppUnits().
- A couple of functions simply had an unused gfxContext or nsRenderingContext
parameter removed, e.g. SetLineBreaks().
2015-12-15 13:56:41 -08:00
Xidorn Quan
4c7aca9a84
Bug 1216332 - Remove framearena helpers from abstract frame classes and stop them from being instantiated. r=dbaron
2015-11-04 20:57:35 +11:00
Nathan Froyd
4e6d8f6705
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Nicholas Nethercote
15a618076e
Bug 1207944 (part 4) - Use SetColor(const Color&) when setting from an nscolor. r=jwatt.
...
In various places SetColor() gets passed an nscolor. These are converted
(either implicitly or explicitly) to a gfxRBGA, and then to a gfx::Color.
This patch changes all these cases to avoid the middle step, by (a)
constructing a gfx::Color directly instead of an nscolor, or (b) by converting
an nscolor with Color::FromABGR().
2015-09-23 23:41:30 -07:00
Mats Palmgren
3f92be8fe8
Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc
2015-03-29 22:38:40 +00:00
Mats Palmgren
311a693db5
Bug 1148833 part 1 - Remove nsMathMLContainerFrame::WillReflow, reset the NS_MATHML_ERROR bit at the start of Reflow instead. r=roc
2015-03-29 22:38:39 +00:00
Ehsan Akhgari
ea41d8de48
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Robert O'Callahan
61a73162c5
Bug 1139709. Address review comments. r=mats
2015-03-05 17:22:26 +13:00
Robert O'Callahan
243150e068
Bug 1139709. Cache nsMathMLContainerFrame's intrinsic width. r=mats
...
For me, this reduces the load time of the testcase in bug 1139709 from
68s to 34s.
2015-03-05 14:30:07 +13:00
Andrea Marchesini
7a0dde83e6
Bug 1134280 - Get rid of Tag() - patch 2.4 - layout/mathml - Fix all the occurrences, m=smaug, r=surkov
2015-03-03 11:09:00 +00:00
Andrea Marchesini
6b10d5e43e
Bug 1134280 - Get rid of Tag() - patch 1 - Is{HTML,XUL,MathML,SVG}Element and IsAnyOf{HTML,XUL,MathML,SVG}Elements, r=smaug
2015-03-03 11:08:59 +00:00
Seth Fowler
72fb0505de
Bug 1128356 - Add template functions for common frame property destructors. r=dbaron
2015-02-04 15:22:27 -08:00
Frédéric Wang
1988927944
Bug 1002526 - Part 1 - Pass the font inflation parameter to nsLayoutUtils::GetFontMetricsFor* methods. b=1002526. r=karl
2014-10-25 08:29:00 +02:00
Jonathan Watt
a459e03874
Bug 1088625, part 3 - Remove nsRenderingContext's SetFont, FontMetrics and SetTextRunRTL methods now that no one uses them any more. r=mstange
2014-10-24 16:28:15 +01:00
Jonathan Watt
3c69ad6faa
Bug 1088625, part 2 - Pass nsFontMetrics objects through to code that needs it instead of storing it on the nsRenderingContext. r=mstange
2014-10-24 16:28:14 +01:00
Jonathan Watt
abbc6ac8ac
Bug 1088599 - Move nsRenderingContext::GetBoundingMetrics to nsLayoutUtils. r=mstange
2014-10-24 16:28:14 +01:00
Jonathan Watt
16e135bc53
Bug 1088071, part 1 - Wrap the callers of the final nsRenderingContext::DrawString method up in a new nsLayoutUtils::DrawUniDirString method. r=jfkthame
2014-10-24 11:00:23 +01:00
Jonathan Watt
3b52cf43ad
Bug 1086708 - Rename the snapping variant of NSRectToRect to NSRectToSnappedRect. r=mattwoodrow
2014-10-22 12:29:06 +01:00
Jonathan Watt
066c3125f2
Bug 1085165 - Get rid of the nsRenderingContext::SetColor() method. r=mattwoodrow
2014-10-20 10:55:49 +01:00
Jonathan Watt
40da0a5dbd
Bug 1083753, part 2 - Port the code that uses nsRenderingContext::FillRect(nsRect) to Moz2D. r=mattwoodrow
2014-10-19 13:22:22 +01:00
James Kitchener
6f6282dbda
Bug 687807 - Improvements to stretching of embellished operators. r=karlt
2014-09-19 20:13:00 +02:00
Markus Stange
a617534584
Bug 1021564 - Make sure that FinishAndStoreOverflow is called for MathML frames even if they are in an error state. r=roc
2014-08-30 18:22:42 +02:00
Seth Fowler
33363dcb3e
Bug 981924 - Update ReportToConsole calls in layout code to use the right category. r=dbaron
2014-08-11 16:52:01 -07:00
Jonathan Kew
f6c74bf220
bug 1031241 pt 4 - Rename the {MIN,PREF}_WIDTH constants used to identify the type of intrinsic inline-size. r=smontagu
2014-07-24 18:03:26 +01:00
Jonathan Kew
fe8090d7de
bug 1031241 pt 3 - Also rename Intrinsic{Width,Height} to Intrinsic{I,B}Size. r=smontagu
2014-07-24 18:03:26 +01:00
Jonathan Kew
c7e5b8d9dc
bug 1031241 pt 1 - Rename Get{Min,Pref}Width to Get{Min,Pref}ISize throughout layout. r=dbaron,smontagu
2014-07-24 18:03:25 +01:00
Simon Montagu
659c93475e
Bug 789096 patch 10: make Reflow set nsHTMLReflowMetrics.ISize and BSize instead of Width and Height. r=jfkthame
2014-07-24 01:30:07 -07:00
Simon Montagu
0132cc9646
Bug 789096 patch 9: use logical coordinates in nsHTMLReflowState available size. r=jfkthame
2014-07-24 01:28:46 -07:00
Simon Montagu
de56d03df4
Bug 1028521: Use the nsHTMLReflowMetrics' writing mode passed in from the container in nsMathMLContainerFrame::ReflowChild, not the child frame's. r=jfkthame
2014-06-24 01:36:45 -07:00
Simon Montagu
614fa9614f
Replace GetBaseline with GetLogicalBaseline and use logical coordinates in the line position and baseline getters in nsLayoutUtils. Bug 789096, r=jfkthame
2014-06-17 05:19:38 -07:00
Simon Montagu
7182a1b8b9
Replace Get/SetTopAscent with Get/SetBlockStartAscent. Bug 789096, r=jfkthame
2014-06-11 02:45:31 -07:00
Mats Palmgren
a43fc7a0a3
Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc
2014-05-28 19:36:58 +00:00
Mats Palmgren
81f3a21c91
Bug 508665 - part 15, s/mParent/GetParent()/ in a bunch of nsIFrame sub-classes. r=roc
2014-05-24 22:20:41 +00:00
Mats Palmgren
a73e99dbc1
Bug 508665 - part 1, Change the signature of SetParent/GetParent from nsIFrame* to nsContainerFrame*. r=roc
2014-05-24 22:20:39 +00:00
Mats Palmgren
e03220a2e3
Bug 1008917 - part 5,6,7, make ReflowChild() and FinishReflowChild() return type 'void', and make a few related helper methods 'void' too. r=roc
2014-05-13 00:47:53 +00:00
Mats Palmgren
84ce46d68c
Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc
2014-05-13 00:47:52 +00:00
Mats Palmgren
c2732adc4b
Bug 1008917 - part 1, stop using the nsresult from Reflow methods in MathML code. r=fredw
2014-05-13 00:47:52 +00:00
Wes Kocher
2669e87017
Backed out 11 changesets (bug 1008917) for apparently introducing an intermittent failure of B2G Crashtest-2 on a CLOSED TREE
...
Backed out changeset e2ab653f688a (bug 1008917)
Backed out changeset b52154d8d900 (bug 1008917)
Backed out changeset 2ab5b01da4de (bug 1008917)
Backed out changeset f7a38df1d44f (bug 1008917)
Backed out changeset 80304bb9a572 (bug 1008917)
Backed out changeset 10ed89a302e9 (bug 1008917)
Backed out changeset 161c41991d46 (bug 1008917)
Backed out changeset 25b2475d2368 (bug 1008917)
Backed out changeset b8000b31277c (bug 1008917)
Backed out changeset 9afa5e7715e1 (bug 1008917)
Backed out changeset 5c380c21351f (bug 1008917)
2014-05-12 15:47:41 -07:00
Mats Palmgren
88bd1a0a98
Bug 1008917 - part 5,6,7, make ReflowChild() and FinishReflowChild() return type 'void', and make a few related helper methods 'void' too. r=roc
2014-05-12 17:40:29 +00:00
Mats Palmgren
4a79e08cae
Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc
2014-05-12 17:40:28 +00:00
Mats Palmgren
c59a9558ec
Bug 1008917 - part 1, stop using the nsresult from Reflow methods in MathML code. r=fredw
2014-05-12 17:40:28 +00:00
James Kitchener
36a43e3d2d
Bug 875563 - Zero dictionary lspace/rspace when not in (inferred) mrow r=fredw
2014-04-04 17:54:00 +02:00
James Kitchener
dbe419e5c3
Bug 518592 - Fix single char <mi> frame type and add a test for dotless i. r=karlt
2014-03-21 08:49:51 -04:00
Ryan VanderMeulen
d2992547bb
Backed out changeset 1028c462d120 (bug 518592) for Werror bustage on a CLOSED TREE.
2014-03-19 11:16:36 -04:00
James Kitchener
ddd3c10d9f
Bug 518592 - Fix single char <mi> frame type and add a test for dotless i. r=karlt
2014-03-19 10:36:27 -04:00
Jonathan Kew
3487faa35b
bug 735577 - followup 1 (v2) - allow reflow-state to be passed to the reflow-metrics constructor to get the writing mode. r=roc
2013-12-31 13:50:31 +00:00
Reuben Morais
16c1e76108
Bug 458300 - Rename nsINameSpaceManager.h to nsNameSpaceManager.h. r=jst r=hsivonen
2014-02-27 20:04:46 -03:00
Arnaud Sourioux
fe6152ac7a
Bug 974687 - Part 1: Add about 300 MOZ_OVERRIDE in layout/. r=dholbert
2014-02-24 09:41:56 -05:00